From: Thomas Monjalon <thomas@monjalon.net>
To: Liang Ma <liangma@liangbit.com>
Cc: dev@dpdk.org, Usama Arif <usama.arif@bytedance.com>
Subject: Re: [PATCH] devtools: fix symbols check
Date: Tue, 08 Mar 2022 23:05:49 +0100 [thread overview]
Message-ID: <4176712.K71DO8KEF6@thomas> (raw)
In-Reply-To: <YifKXgTiaR11M5r5@C02GF04TMD6V>
08/03/2022 22:27, Liang Ma:
> On Tue, Mar 08, 2022 at 10:18:59PM +0100, Thomas Monjalon wrote:
> > In some environments, the check of local symbols catch-all
> > was failing. Note: this script is called during the build.
> >
> > The reason is that grep returns an error if nothing is found.
> > The option -e of the shell script makes this error fatal.
> > It is not always fatal because the grep is in a command substitution.
> >
> > Fixes: b403498e1422 ("build: hide local symbols in shared libraries")
> >
> > Reported-by: Usama Arif <usama.arif@bytedance.com>
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
> > devtools/check-symbol-maps.sh | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/devtools/check-symbol-maps.sh b/devtools/check-symbol-maps.sh
> > index 8266fdf9ea..32e1fa5c8f 100755
> > --- a/devtools/check-symbol-maps.sh
> > +++ b/devtools/check-symbol-maps.sh
> > @@ -53,7 +53,7 @@ if [ -n "$duplicate_symbols" ] ; then
> > ret=1
> > fi
> >
> > -local_miss_maps=$(grep -L 'local: \*;' $@)
> > +local_miss_maps=$(grep -L 'local: \*;' $@ || true)
> reviewed-by Liang Ma <liangma@liangbit.com>
>
> I'm curious to know how can the CI passed with original patch.....
You are suggesting I did not check the CI.
The Intel check failed because of an apply issue,
so I was not able to see the compilation result:
http://mails.dpdk.org/archives/test-report/2022-March/267685.html
Later in the day, the UNH CI failed for the good reason
but it was too late, the patch was applied:
http://mails.dpdk.org/archives/test-report/2022-March/267723.html
That's what happens when I want to introduce a little additional check
at the last minute before a release candidate.
next prev parent reply other threads:[~2022-03-08 22:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-08 21:18 Thomas Monjalon
2022-03-08 21:21 ` Thomas Monjalon
2022-03-08 21:27 ` Liang Ma
2022-03-08 22:05 ` Thomas Monjalon [this message]
2022-03-08 23:02 ` Liang Ma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4176712.K71DO8KEF6@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=liangma@liangbit.com \
--cc=usama.arif@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).