From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>,
"Mcnamara, John" <john.mcnamara@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Singh, Jasvinder" <jasvinder.singh@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/softnic: fix resource leak
Date: Wed, 13 May 2020 16:32:23 +0100 [thread overview]
Message-ID: <418f3f9c-187c-193b-5c33-8bb4a3280ef3@intel.com> (raw)
In-Reply-To: <BYAPR11MB293530E7C425DFBC420F7DC5EBBF0@BYAPR11MB2935.namprd11.prod.outlook.com>
On 5/13/2020 2:55 PM, Dumitrescu, Cristian wrote:
>
>
>> -----Original Message-----
>> From: Mcnamara, John <john.mcnamara@intel.com>
>> Sent: Wednesday, May 13, 2020 1:46 PM
>> To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
>> Cc: dev@dpdk.org; Singh, Jasvinder <jasvinder.singh@intel.com>
>> Subject: RE: [dpdk-dev] [PATCH] net/softnic: fix resource leak
>>
>>> -----Original Message-----
>>> From: dev <dev-bounces@dpdk.org> On Behalf Of Jasvinder Singh
>>> Sent: Monday, April 27, 2020 3:03 PM
>>> To: dev@dpdk.org
>>> Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
>>> Subject: [dpdk-dev] [PATCH] net/softnic: fix resource leak
>>>
>>> When sending request messages to data plane pipelines, the caller must
>>> free the memory allocated to request message on receiving error
>> response.
>>>
>>> Coverity Issues: 357676, 357680, 357681, 357682, 357690, 357693, 357711,
>>> 357722, 357725, 357734, 357739, 357743, 357747,357762, 357766, 357787
>>>
>>> Fixes: 6d4d05402501 ("net/softnic: add command to read stats")
>>> Fixes: 202905f3ee4d ("net/softnic: add command to create objects")
>>> Fixes: ee19326a4b1e ("net/softnic: add command for pipeline table
>>> entries")
>>> Fixes: 9bc0ce0ad17c ("net/softnic: add command for meter action")
>>> Fixes: 2505030a8383 ("net/softnic: add command for TTL action")
>>>
>>> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
>>
>>
>>
>>
>> Cristian,
>>
>> Can you merge this and other Coverity fixes. They need to be cleared for
>> DPDK 20.05.
>>
>> John
>
> Ferruh and Jasvinder confirmed these are already merged.
>
Patches are in the tree Cristian, but I think they are not addressing the
coverity issue correctly, that looks the reason that coverity issues are still
there.
prev parent reply other threads:[~2020-05-13 15:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 14:03 Jasvinder Singh
2020-04-27 17:15 ` [dpdk-dev] [PATCH v2] net/softnic: fix resource leak for pipeline Jasvinder Singh
2020-05-01 15:48 ` Ferruh Yigit
2020-05-13 12:45 ` [dpdk-dev] [PATCH] net/softnic: fix resource leak Mcnamara, John
2020-05-13 13:55 ` Dumitrescu, Cristian
2020-05-13 15:32 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=418f3f9c-187c-193b-5c33-8bb4a3280ef3@intel.com \
--to=ferruh.yigit@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=john.mcnamara@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).