From: Thomas Monjalon <thomas@monjalon.net>
To: Jan Blunck <jblunck@infradead.org>
Cc: dev@dpdk.org, Gaetan Rivet <gaetan.rivet@6wind.com>,
Stephen Hemminger <stephen@networkplumber.org>,
Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH v7 00/17] Generic devargs parsing
Date: Sun, 09 Jul 2017 12:17:42 +0200 [thread overview]
Message-ID: <4219460.8ez8IeSCfv@xps> (raw)
In-Reply-To: <CALe+Z00_K_7V8=PNaFOLB3u2Pq_L-nTg+ngFfkoNu4NhRbgk+Q@mail.gmail.com>
09/07/2017 10:37, Jan Blunck:
> On Sat, Jul 8, 2017 at 6:28 PM, Thomas Monjalon <thomas@monjalon.net> wrote:
> > 07/07/2017 02:04, Gaetan Rivet:
> >> In this patchset, the representation of devices in rte_devargs is made generic
> >> to remove some dependencies of the EAL on specific buses implementations.
> >> Following the device types being characterized by their bus, the DEVTYPE
> >> flags are updated not to reference virtual / PCI devices anymore.
> > [...]
> >> Gaetan Rivet (16):
> >> net/bonding: properly reference PCI header
> >> net/bnxt: properly reference PCI header
> >> net/mlx5: properly reference PCI header
> >> net/e1000: properly reference PCI header
> >> net/ixgbe: properly reference PCI header
> >> net/sfc: properly reference PCI header
> >> app/testpmd: properly reference PCI header
> >> test: properly reference PCI header
> >> dev: device kernel module is a device attribute
> >> bus: introduce bus scan policies
> >> devargs: parse bus policies
> >> devargs: generic device representation
> >> net/virtio: do not reference device type
> >> devargs: generic device types
> >> devargs: introduce cleaner parsing helper
> >> eal: change whitelist / blacklist command line doc
> >>
> >> Thomas Monjalon (1):
> >> examples/ethtool: properly reference PCI header
> >
> > Series applied, except last patch (17), as explained before. Thanks
> >
>
> I wonder why you complain about not having enough reviewers if you
> anyway ignoring their feedback!
I am not ignoring your feedback at all.
There are 2 things in this series:
1/ decouple devargs and PCI/vdev
2/ couple devargs policies to rte_bus
I agree that we should not have policies in rte_bus (2).
However it is the only patches we have for now to achieve (1),
which is a required step to move PCI and vdev as real bus drivers.
As explained in the following email, I prefer progressing on (1)
and rework (2) in 17.11:
http://dpdk.org/ml/archives/dev/2017-July/070203.html
What do you think of my proposal, adding a callback in probe?
> I pointed out multiple times that parsing a device name to deduce the
> bus is not the right thing to do.
Yes, so we need to change the parameter syntax to make the bus name
explicit and mandatory. We need a deprecation notice.
> This series also tightly couples rte_devargs to rte_bus.
> It adds hidden functionality to have
> blacklist/whitelist mode for all busses and even sticks that
> functionality on the wrong object (devargs).
Yes, as said above, we must rework it in 17.11.
next prev parent reply other threads:[~2017-07-09 10:17 UTC|newest]
Thread overview: 145+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-24 15:14 [dpdk-dev] [PATCH 00/14] " Gaetan Rivet
2017-05-24 15:14 ` [dpdk-dev] [PATCH 01/14] net/bonding: properly reference PCI header Gaetan Rivet
2017-05-24 15:14 ` [dpdk-dev] [PATCH 02/14] net/bnxt: " Gaetan Rivet
2017-05-24 15:14 ` [dpdk-dev] [PATCH 03/14] net/mlx5: " Gaetan Rivet
2017-05-24 15:14 ` [dpdk-dev] [PATCH 04/14] net/e1000: " Gaetan Rivet
2017-05-24 15:14 ` [dpdk-dev] [PATCH 05/14] net/ixgbe: " Gaetan Rivet
2017-05-24 15:14 ` [dpdk-dev] [PATCH 06/14] net/sfc: " Gaetan Rivet
2017-05-24 15:14 ` [dpdk-dev] [PATCH 07/14] app/testpmd: " Gaetan Rivet
2017-05-24 15:14 ` [dpdk-dev] [PATCH 08/14] dev: device kernel module is a device attribute Gaetan Rivet
2017-05-24 15:14 ` [dpdk-dev] [PATCH 09/14] bus: introduce bus scan policies Gaetan Rivet
2017-05-24 15:14 ` [dpdk-dev] [PATCH 10/14] devargs: parse bus policies Gaetan Rivet
2017-05-24 15:14 ` [dpdk-dev] [PATCH 11/14] devargs: generic device representation Gaetan Rivet
2017-05-24 15:14 ` [dpdk-dev] [PATCH 12/14] net/virtio: do not reference device type Gaetan Rivet
2017-05-24 15:14 ` [dpdk-dev] [PATCH 13/14] devargs: generic device types Gaetan Rivet
2017-05-24 15:14 ` [dpdk-dev] [PATCH 14/14] devargs: introduce cleaner parsing helper Gaetan Rivet
2017-05-24 16:16 ` [dpdk-dev] [PATCH v2 00/14] Generic devargs parsing Gaetan Rivet
2017-05-24 16:16 ` [dpdk-dev] [PATCH v2 01/14] net/bonding: properly reference PCI header Gaetan Rivet
2017-05-24 16:16 ` [dpdk-dev] [PATCH v2 02/14] net/bnxt: " Gaetan Rivet
2017-05-24 16:16 ` [dpdk-dev] [PATCH v2 03/14] net/mlx5: " Gaetan Rivet
2017-05-24 16:16 ` [dpdk-dev] [PATCH v2 04/14] net/e1000: " Gaetan Rivet
2017-05-24 16:16 ` [dpdk-dev] [PATCH v2 05/14] net/ixgbe: " Gaetan Rivet
2017-05-24 16:16 ` [dpdk-dev] [PATCH v2 06/14] net/sfc: " Gaetan Rivet
2017-05-24 16:16 ` [dpdk-dev] [PATCH v2 07/14] app/testpmd: " Gaetan Rivet
2017-05-24 16:16 ` [dpdk-dev] [PATCH v2 08/14] dev: device kernel module is a device attribute Gaetan Rivet
2017-05-24 16:16 ` [dpdk-dev] [PATCH v2 09/14] bus: introduce bus scan policies Gaetan Rivet
2017-05-24 16:16 ` [dpdk-dev] [PATCH v2 10/14] devargs: parse bus policies Gaetan Rivet
2017-05-24 16:16 ` [dpdk-dev] [PATCH v2 11/14] devargs: generic device representation Gaetan Rivet
2017-05-24 16:16 ` [dpdk-dev] [PATCH v2 12/14] net/virtio: do not reference device type Gaetan Rivet
2017-05-24 16:16 ` [dpdk-dev] [PATCH v2 13/14] devargs: generic device types Gaetan Rivet
2017-05-24 16:16 ` [dpdk-dev] [PATCH v2 14/14] devargs: introduce cleaner parsing helper Gaetan Rivet
2017-06-01 10:10 ` [dpdk-dev] [PATCH v3 00/14] Generic devargs parsing Gaetan Rivet
2017-06-01 10:10 ` [dpdk-dev] [PATCH v3 01/14] net/bonding: properly reference PCI header Gaetan Rivet
2017-06-01 10:10 ` [dpdk-dev] [PATCH v3 02/14] net/bnxt: " Gaetan Rivet
2017-06-01 10:10 ` [dpdk-dev] [PATCH v3 03/14] net/mlx5: " Gaetan Rivet
2017-06-01 10:10 ` [dpdk-dev] [PATCH v3 04/14] net/e1000: " Gaetan Rivet
2017-06-01 10:10 ` [dpdk-dev] [PATCH v3 05/14] net/ixgbe: " Gaetan Rivet
2017-06-01 10:10 ` [dpdk-dev] [PATCH v3 06/14] net/sfc: " Gaetan Rivet
2017-06-01 10:10 ` [dpdk-dev] [PATCH v3 07/14] app/testpmd: " Gaetan Rivet
2017-06-01 10:10 ` [dpdk-dev] [PATCH v3 08/14] dev: device kernel module is a device attribute Gaetan Rivet
2017-06-01 10:10 ` [dpdk-dev] [PATCH v3 09/14] bus: introduce bus scan policies Gaetan Rivet
2017-06-01 10:10 ` [dpdk-dev] [PATCH v3 10/14] devargs: parse bus policies Gaetan Rivet
2017-06-01 10:10 ` [dpdk-dev] [PATCH v3 11/14] devargs: generic device representation Gaetan Rivet
2017-06-01 10:10 ` [dpdk-dev] [PATCH v3 12/14] net/virtio: do not reference device type Gaetan Rivet
2017-06-01 10:10 ` [dpdk-dev] [PATCH v3 13/14] devargs: generic device types Gaetan Rivet
2017-06-01 10:10 ` [dpdk-dev] [PATCH v3 14/14] devargs: introduce cleaner parsing helper Gaetan Rivet
2017-06-07 23:56 ` [dpdk-dev] [PATCH v4 00/19] Generic devargs parsing Gaetan Rivet
2017-06-07 23:56 ` [dpdk-dev] [PATCH v4 01/19] net/bonding: properly reference PCI header Gaetan Rivet
2017-06-07 23:56 ` [dpdk-dev] [PATCH v4 02/19] net/bnxt: " Gaetan Rivet
2017-06-07 23:56 ` [dpdk-dev] [PATCH v4 03/19] net/mlx5: " Gaetan Rivet
2017-06-07 23:56 ` [dpdk-dev] [PATCH v4 04/19] net/e1000: " Gaetan Rivet
2017-06-07 23:56 ` [dpdk-dev] [PATCH v4 05/19] net/ixgbe: " Gaetan Rivet
2017-06-14 9:33 ` Dai, Wei
2017-06-14 9:48 ` Gaëtan Rivet
2017-06-07 23:56 ` [dpdk-dev] [PATCH v4 06/19] net/sfc: " Gaetan Rivet
2017-06-07 23:56 ` [dpdk-dev] [PATCH v4 07/19] app/testpmd: " Gaetan Rivet
2017-06-07 23:56 ` [dpdk-dev] [PATCH v4 08/19] test: " Gaetan Rivet
2017-06-07 23:56 ` [dpdk-dev] [PATCH v4 09/19] dev: device kernel module is a device attribute Gaetan Rivet
2017-06-07 23:56 ` [dpdk-dev] [PATCH v4 10/19] bus: introduce bus scan policies Gaetan Rivet
2017-06-07 23:56 ` [dpdk-dev] [PATCH v4 11/19] devargs: parse bus policies Gaetan Rivet
2017-06-07 23:56 ` [dpdk-dev] [PATCH v4 12/19] devargs: generic device representation Gaetan Rivet
2017-06-07 23:56 ` [dpdk-dev] [PATCH v4 13/19] pci: update device name Gaetan Rivet
2017-06-07 23:57 ` [dpdk-dev] [PATCH v4 14/19] net/virtio: do not reference device type Gaetan Rivet
2017-06-07 23:57 ` [dpdk-dev] [PATCH v4 15/19] devargs: generic device types Gaetan Rivet
2017-06-07 23:57 ` [dpdk-dev] [PATCH v4 16/19] devargs: introduce cleaner parsing helper Gaetan Rivet
2017-06-07 23:57 ` [dpdk-dev] [PATCH v4 17/19] devargs: clone function Gaetan Rivet
2017-06-07 23:57 ` [dpdk-dev] [PATCH v4 18/19] devargs: remove function Gaetan Rivet
2017-06-07 23:57 ` [dpdk-dev] [PATCH v4 19/19] eal: change whitelist / blacklist command line doc Gaetan Rivet
2017-06-20 23:35 ` [dpdk-dev] [PATCH v5 00/19] Generic devargs parsing Gaetan Rivet
2017-06-20 23:35 ` [dpdk-dev] [PATCH v5 01/19] net/bonding: properly reference PCI header Gaetan Rivet
2017-06-20 23:35 ` [dpdk-dev] [PATCH v5 02/19] net/bnxt: " Gaetan Rivet
2017-06-20 23:35 ` [dpdk-dev] [PATCH v5 03/19] net/mlx5: " Gaetan Rivet
2017-06-20 23:35 ` [dpdk-dev] [PATCH v5 04/19] net/e1000: " Gaetan Rivet
2017-06-20 23:35 ` [dpdk-dev] [PATCH v5 05/19] net/ixgbe: " Gaetan Rivet
2017-06-20 23:35 ` [dpdk-dev] [PATCH v5 06/19] net/sfc: " Gaetan Rivet
2017-06-20 23:35 ` [dpdk-dev] [PATCH v5 07/19] app/testpmd: " Gaetan Rivet
2017-06-20 23:35 ` [dpdk-dev] [PATCH v5 08/19] test: " Gaetan Rivet
2017-06-20 23:35 ` [dpdk-dev] [PATCH v5 09/19] dev: device kernel module is a device attribute Gaetan Rivet
2017-06-20 23:35 ` [dpdk-dev] [PATCH v5 10/19] bus: introduce bus scan policies Gaetan Rivet
2017-07-04 23:01 ` Thomas Monjalon
2017-06-20 23:35 ` [dpdk-dev] [PATCH v5 11/19] devargs: parse bus policies Gaetan Rivet
2017-06-20 23:35 ` [dpdk-dev] [PATCH v5 12/19] devargs: generic device representation Gaetan Rivet
2017-06-28 7:44 ` Thomas Monjalon
2017-06-28 8:05 ` Gaëtan Rivet
2017-06-28 14:18 ` [dpdk-dev] [PATCH] examples/ethtool: explicit PCI header dependency Thomas Monjalon
2017-06-20 23:35 ` [dpdk-dev] [PATCH v5 13/19] pci: update device name Gaetan Rivet
2017-06-20 23:35 ` [dpdk-dev] [PATCH v5 14/19] net/virtio: do not reference device type Gaetan Rivet
2017-06-20 23:35 ` [dpdk-dev] [PATCH v5 15/19] devargs: generic device types Gaetan Rivet
2017-06-20 23:35 ` [dpdk-dev] [PATCH v5 16/19] devargs: introduce cleaner parsing helper Gaetan Rivet
2017-06-27 22:19 ` Thomas Monjalon
2017-06-27 23:46 ` Wiles, Keith
2017-07-04 21:50 ` Gaëtan Rivet
2017-06-20 23:35 ` [dpdk-dev] [PATCH v5 17/19] devargs: clone function Gaetan Rivet
2017-06-20 23:35 ` [dpdk-dev] [PATCH v5 18/19] devargs: remove function Gaetan Rivet
2017-06-20 23:35 ` [dpdk-dev] [PATCH v5 19/19] eal: change whitelist / blacklist command line doc Gaetan Rivet
2017-06-26 14:58 ` Mcnamara, John
2017-07-04 23:56 ` [dpdk-dev] [PATCH v6 00/19] Generic devargs parsing Gaetan Rivet
2017-07-04 23:56 ` [dpdk-dev] [PATCH v6 01/19] net/bonding: properly reference PCI header Gaetan Rivet
2017-07-04 23:56 ` [dpdk-dev] [PATCH v6 02/19] net/bnxt: " Gaetan Rivet
2017-07-04 23:56 ` [dpdk-dev] [PATCH v6 03/19] net/mlx5: " Gaetan Rivet
2017-07-04 23:56 ` [dpdk-dev] [PATCH v6 04/19] net/e1000: " Gaetan Rivet
2017-07-04 23:56 ` [dpdk-dev] [PATCH v6 05/19] net/ixgbe: " Gaetan Rivet
2017-07-04 23:56 ` [dpdk-dev] [PATCH v6 06/19] net/sfc: " Gaetan Rivet
2017-07-04 23:56 ` [dpdk-dev] [PATCH v6 07/19] app/testpmd: " Gaetan Rivet
2017-07-04 23:56 ` [dpdk-dev] [PATCH v6 08/19] test: " Gaetan Rivet
2017-07-04 23:56 ` [dpdk-dev] [PATCH v6 09/19] dev: device kernel module is a device attribute Gaetan Rivet
2017-07-04 23:56 ` [dpdk-dev] [PATCH v6 10/19] bus: introduce bus scan policies Gaetan Rivet
2017-07-04 23:56 ` [dpdk-dev] [PATCH v6 11/19] devargs: parse bus policies Gaetan Rivet
2017-07-04 23:56 ` [dpdk-dev] [PATCH v6 12/19] devargs: generic device representation Gaetan Rivet
2017-07-04 23:56 ` [dpdk-dev] [PATCH v6 13/19] pci: update device name Gaetan Rivet
2017-07-04 23:56 ` [dpdk-dev] [PATCH v6 14/19] net/virtio: do not reference device type Gaetan Rivet
2017-07-05 0:09 ` Gaëtan Rivet
2017-07-04 23:56 ` [dpdk-dev] [PATCH v6 15/19] devargs: generic device types Gaetan Rivet
2017-07-04 23:56 ` [dpdk-dev] [PATCH v6 16/19] devargs: introduce cleaner parsing helper Gaetan Rivet
2017-07-04 23:56 ` [dpdk-dev] [PATCH v6 17/19] devargs: clone function Gaetan Rivet
2017-07-04 23:56 ` [dpdk-dev] [PATCH v6 18/19] devargs: remove function Gaetan Rivet
2017-07-04 23:56 ` [dpdk-dev] [PATCH v6 19/19] eal: change whitelist / blacklist command line doc Gaetan Rivet
2017-07-05 0:23 ` Thomas Monjalon
2017-07-05 10:27 ` Mcnamara, John
2017-07-05 0:32 ` [dpdk-dev] [PATCH v6 00/19] Generic devargs parsing Thomas Monjalon
2017-07-05 7:46 ` Gaëtan Rivet
2017-07-07 0:04 ` [dpdk-dev] [PATCH v7 00/17] " Gaetan Rivet
2017-07-07 0:04 ` [dpdk-dev] [PATCH v7 01/17] net/bonding: properly reference PCI header Gaetan Rivet
2017-07-07 0:04 ` [dpdk-dev] [PATCH v7 02/17] net/bnxt: " Gaetan Rivet
2017-07-07 0:04 ` [dpdk-dev] [PATCH v7 03/17] net/mlx5: " Gaetan Rivet
2017-07-07 0:04 ` [dpdk-dev] [PATCH v7 04/17] net/e1000: " Gaetan Rivet
2017-07-07 0:04 ` [dpdk-dev] [PATCH v7 05/17] net/ixgbe: " Gaetan Rivet
2017-07-07 0:04 ` [dpdk-dev] [PATCH v7 06/17] net/sfc: " Gaetan Rivet
2017-07-07 0:04 ` [dpdk-dev] [PATCH v7 07/17] app/testpmd: " Gaetan Rivet
2017-07-07 0:04 ` [dpdk-dev] [PATCH v7 08/17] test: " Gaetan Rivet
2017-07-07 0:04 ` [dpdk-dev] [PATCH v7 09/17] examples/ethtool: " Gaetan Rivet
2017-07-07 0:04 ` [dpdk-dev] [PATCH v7 10/17] dev: device kernel module is a device attribute Gaetan Rivet
2017-07-07 0:04 ` [dpdk-dev] [PATCH v7 11/17] bus: introduce bus scan policies Gaetan Rivet
2017-07-07 0:04 ` [dpdk-dev] [PATCH v7 12/17] devargs: parse bus policies Gaetan Rivet
2017-07-09 14:50 ` Thomas Monjalon
2017-07-07 0:04 ` [dpdk-dev] [PATCH v7 13/17] devargs: generic device representation Gaetan Rivet
2017-07-07 0:04 ` [dpdk-dev] [PATCH v7 14/17] net/virtio: do not reference device type Gaetan Rivet
2017-07-07 0:04 ` [dpdk-dev] [PATCH v7 15/17] devargs: generic device types Gaetan Rivet
2017-07-07 0:04 ` [dpdk-dev] [PATCH v7 16/17] devargs: introduce cleaner parsing helper Gaetan Rivet
2017-07-07 0:04 ` [dpdk-dev] [PATCH v7 17/17] eal: change whitelist / blacklist command line doc Gaetan Rivet
2017-07-08 22:25 ` Thomas Monjalon
2017-07-08 22:28 ` [dpdk-dev] [PATCH v7 00/17] Generic devargs parsing Thomas Monjalon
2017-07-09 8:37 ` Jan Blunck
2017-07-09 10:17 ` Thomas Monjalon [this message]
2017-07-09 11:16 ` Jan Blunck
2017-07-09 11:29 ` Gaëtan Rivet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4219460.8ez8IeSCfv@xps \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=gaetan.rivet@6wind.com \
--cc=jblunck@infradead.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).