From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
To: Ferruh Yigit <ferruh.yigit@amd.com>
Cc: Ruifeng Wang <Ruifeng.Wang@arm.com>,
Neel Patel <neel.patel@amd.com>,
R Mohamed Shah <mohamedshah.r@amd.com>,
Alfredo Cardigliano <cardigliano@ntop.org>,
Andrew Boyer <andrew.boyer@amd.com>,
"dev@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>,
Wathsala Wathawana Vithanage <wathsala.vithanage@arm.com>
Subject: Re: [PATCH 3/3] net/ionic: add vdev support for embedded applications
Date: Tue, 20 Feb 2024 14:39:41 +0000 [thread overview]
Message-ID: <424539C4-E490-4D73-9FE3-AD674ADE4D26@arm.com> (raw)
In-Reply-To: <e7a4b05c-7628-4810-b5bd-20e2e34afc15@amd.com>
> On Feb 20, 2024, at 2:28 AM, Ferruh Yigit <ferruh.yigit@amd.com> wrote:
>
> On 2/16/2024 5:07 PM, Andrew Boyer wrote:
>> +#if defined(RTE_LIBRTE_IONIC_PMD_BARRIER_ERRATA)
>> + /* On some devices the standard 'dmb' barrier is insufficient */
>> + asm volatile("dsb st" : : : "memory");
>> + rte_write64_relaxed(rte_cpu_to_le_64(val), q->db);
>> +#else
>> rte_write64(rte_cpu_to_le_64(val), q->db);
>> +#endif
>>
>
> Hi Honnappa, Ruifeng,
>
> Should we have an API for the above asm instruction? What do you think?
We do not expect “dsb st” to be used as per the architecture in DPDK. This is being used here due to a hardware errata. Hence, we do not need an API for this.
>
next prev parent reply other threads:[~2024-02-20 14:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-16 17:07 [PATCH 0/3] net/ionic, common/ionic: add vdev support Andrew Boyer
2024-02-16 17:07 ` [PATCH 1/3] common/ionic: create common code library for ionic Andrew Boyer
2024-02-16 17:07 ` [PATCH 2/3] net/ionic: remove duplicate barriers Andrew Boyer
2024-02-19 22:16 ` Wathsala Wathawana Vithanage
2024-02-20 2:02 ` Wathsala Wathawana Vithanage
2024-02-20 18:31 ` Boyer, Andrew
2024-02-16 17:07 ` [PATCH 3/3] net/ionic: add vdev support for embedded applications Andrew Boyer
2024-02-19 15:24 ` Ferruh Yigit
2024-02-19 22:02 ` Boyer, Andrew
2024-02-20 2:02 ` Honnappa Nagarahalli
2024-02-21 1:16 ` Boyer, Andrew
2024-02-20 8:28 ` Ferruh Yigit
2024-02-20 14:39 ` Honnappa Nagarahalli [this message]
2024-02-16 19:39 ` [PATCH 0/3] net/ionic, common/ionic: add vdev support Ferruh Yigit
2024-02-20 20:42 ` [PATCH v2 " Andrew Boyer
2024-02-20 20:42 ` [PATCH v2 1/3] common/ionic: create common code library for ionic Andrew Boyer
2024-02-20 20:42 ` [PATCH v2 2/3] net/ionic: remove duplicate barriers Andrew Boyer
2024-02-20 20:42 ` [PATCH v2 3/3] net/ionic: add vdev support for embedded applications Andrew Boyer
2024-02-23 1:52 ` Honnappa Nagarahalli
2024-02-21 16:36 ` [PATCH v2 0/3] net/ionic, common/ionic: add vdev support Ferruh Yigit
2024-02-23 13:48 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=424539C4-E490-4D73-9FE3-AD674ADE4D26@arm.com \
--to=honnappa.nagarahalli@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=andrew.boyer@amd.com \
--cc=cardigliano@ntop.org \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=mohamedshah.r@amd.com \
--cc=nd@arm.com \
--cc=neel.patel@amd.com \
--cc=wathsala.vithanage@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).