From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Raslan Darawsheh <rasland@nvidia.com>,
Michael Baum <michaelba@nvidia.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: Matan Azrad <matan@nvidia.com>, Slava Ovsiienko <viacheslavo@nvidia.com>
Subject: Re: [PATCH v2] common/mlx5: fix missing default devargs initialization
Date: Thu, 3 Mar 2022 16:14:24 +0000 [thread overview]
Message-ID: <42a71aed-610f-8f32-508d-b474662490d2@intel.com> (raw)
In-Reply-To: <BYAPR12MB30789536AB2FED615498BAFFCF039@BYAPR12MB3078.namprd12.prod.outlook.com>
On 3/2/2022 4:33 PM, Raslan Darawsheh wrote:
> Hi,
>
>> -----Original Message-----
>> From: Michael Baum <michaelba@nvidia.com>
>> Sent: Tuesday, March 1, 2022 1:10 PM
>> To: dev@dpdk.org
>> Cc: Matan Azrad <matan@nvidia.com>; Raslan Darawsheh
>> <rasland@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>
>> Subject: [PATCH v2] common/mlx5: fix missing default devargs initialization
>>
>> Device arguments list is provided along with its identifier as part of EAL
>> arguments.
>> The arguments specified in the list are taken from it, and the rest is initialized
>> to the default values.
>>
>> When no list is provided at all, all arguments should have been initialized to
>> their default values. However, they are mistakenly initialized to zero which
>> may be a valid value for some.
>>
>> This patch initializes the default values before checking whether arguments
>> have been specified.
>>
>> Fixes: a729d2f093e9 ("common/mlx5: refactor devargs management")
> added:
> Reported-at: https://bugs.dpdk.org/show_bug.cgi?id=945
We have a defined keyword for it, and it should go before Fixes tag, like:
Bugzilla ID: 945
Fixes: a729d2f093e9 ("common/mlx5: refactor devargs management")
updated accordingly in next-net
>>
>> Signed-off-by: Michael Baum <michaelba@nvidia.com>
>> Acked-by: Matan Azrad <matan@nvidia.com>
>> ---
>>
>> v2: updating Fixes reference hash.
>>
>> drivers/common/mlx5/mlx5_common.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>
> Patch applied to next-net-mlx,
>
> Kindest regards,
> Raslan Darawsheh
prev parent reply other threads:[~2022-03-03 16:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-27 7:57 [PATCH] " Michael Baum
2022-03-01 11:09 ` [PATCH v2] " Michael Baum
2022-03-02 16:33 ` Raslan Darawsheh
2022-03-03 16:14 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42a71aed-610f-8f32-508d-b474662490d2@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=michaelba@nvidia.com \
--cc=rasland@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).