From: Thomas Monjalon <thomas@monjalon.net>
To: Wei Dai <wei.dai@intel.com>
Cc: dev@dpdk.org, wenzhuo.lu@intel.com, harish.patil@cavium.com,
rasesh.mody@cavium.com, stephen.hurd@broadcom.com,
ajit.khaparde@broadcom.com, helin.zhang@intel.com,
konstantin.ananyev@intel.com, jingjing.wu@intel.com,
jing.d.chen@intel.com, adrien.mazarguil@6wind.com,
nelio.laranjeiro@6wind.com, bruce.richardson@intel.com,
yuanhan.liu@linux.intel.com, maxime.coquelin@redhat.com,
shepard.siegel@atomicrules.com, ed.czeck@atomicrules.com,
john.miller@atomicrules.com
Subject: Re: [dpdk-dev] [PATCH v5 0/3] MAC address fail to be added shouldn't be stored
Date: Mon, 01 May 2017 00:59:54 +0200 [thread overview]
Message-ID: <4318072.gYggGDVejI@xps> (raw)
In-Reply-To: <1493525507-56304-1-git-send-email-wei.dai@intel.com>
30/04/2017 06:11, Wei Dai:
> Current ethdev always stores MAC address even it fails to be added.
> Other function may regard the failed MAC address valid and lead to
> some errors. So There is a need to check if the addr is added
> successfully or not and discard it if it fails.
>
> In 3rd patch, add a command "add_more_mac_addr port_id base_mac_addr count"
> to add more than one MAC address one time.
> This command can simplify the test for the first patch.
> Normally a MAC address may fails to be added only after many MAC
> addresses have been added.
> Without this command, a tester may only trigger failed MAC address
> by running many times of testpmd command 'mac_addr add' .
>
> For v4 patch set, have got acknowledgement from
> Nelio Laranjeiro <nelio.laranjeiro@6wind.com> for mlx changes
> Yuanhan Liu <yuanhan.liu@linux.intel.com> for virtio changes
You have not taken the ack from Konstantin,
and you have again forgot --in-reply-to, so review is hard.
Checkpatch reports:
ERROR:EXECUTE_PERMISSIONS: do not set execute permissions for source files
Please make a perfect v6.
next prev parent reply other threads:[~2017-04-30 22:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-30 4:11 Wei Dai
2017-04-30 4:11 ` [dpdk-dev] [PATCH v5 1/3] ethdev: fix adding invalid MAC addr Wei Dai
2017-04-30 4:11 ` [dpdk-dev] [PATCH v5 2/3] doc: change type of return value of adding " Wei Dai
2017-04-30 4:11 ` [dpdk-dev] [PATCH v5 3/3] app/testpmd: add a command to add many MAC addrs Wei Dai
2017-04-30 22:59 ` Thomas Monjalon [this message]
2017-05-02 12:44 ` [dpdk-dev] [PATCH v6 0/3] MAC address fail to be added shouldn't be stored Wei Dai
2017-05-02 12:44 ` [dpdk-dev] [PATCH v6 1/3] ethdev: fix adding invalid MAC addr Wei Dai
2017-05-03 0:57 ` Lu, Wenzhuo
2017-05-03 1:46 ` Yuanhan Liu
2017-05-05 0:16 ` Dai, Wei
2017-05-02 12:44 ` [dpdk-dev] [PATCH v6 2/3] doc: change type of return value of adding " Wei Dai
2017-05-02 12:44 ` [dpdk-dev] [PATCH v6 3/3] app/testpmd: add a command to add many MAC addrs Wei Dai
2017-05-05 0:39 ` [dpdk-dev] [PATCH v7 0/3] MAC address fail to be added shouldn't be stored Wei Dai
2017-05-05 0:40 ` [dpdk-dev] [PATCH v7 1/3] ethdev: fix adding invalid MAC addr Wei Dai
2017-05-05 1:46 ` Yang, Qiming
2017-05-05 14:07 ` Thomas Monjalon
2017-05-05 14:21 ` Thomas Monjalon
2017-05-07 4:39 ` Yuanhan Liu
2017-05-05 14:24 ` Thomas Monjalon
2017-05-05 0:40 ` [dpdk-dev] [PATCH v7 2/3] doc: change type of return value of adding " Wei Dai
2017-05-05 14:23 ` Thomas Monjalon
2017-05-05 0:40 ` [dpdk-dev] [PATCH v7 3/3] app/testpmd: add a command to add many MAC addrs Wei Dai
2017-05-05 14:24 ` Thomas Monjalon
2017-05-08 1:01 ` Wu, Jingjing
2017-05-08 6:17 ` Wu, Jingjing
-- strict thread matches above, loose matches on Subject: below --
2017-04-29 6:08 [dpdk-dev] [PATCH v5 0/3] MAC address fail to be added shouldn't be stored Wei Dai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4318072.gYggGDVejI@xps \
--to=thomas@monjalon.net \
--cc=adrien.mazarguil@6wind.com \
--cc=ajit.khaparde@broadcom.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ed.czeck@atomicrules.com \
--cc=harish.patil@cavium.com \
--cc=helin.zhang@intel.com \
--cc=jing.d.chen@intel.com \
--cc=jingjing.wu@intel.com \
--cc=john.miller@atomicrules.com \
--cc=konstantin.ananyev@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=nelio.laranjeiro@6wind.com \
--cc=rasesh.mody@cavium.com \
--cc=shepard.siegel@atomicrules.com \
--cc=stephen.hurd@broadcom.com \
--cc=wei.dai@intel.com \
--cc=wenzhuo.lu@intel.com \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).