From: "Chen, Jing D" <jing.d.chen@intel.com>
To: "Zhang, Helin" <helin.zhang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] i40e: fix of PF interrupt handling
Date: Tue, 4 Nov 2014 08:13:32 +0000 [thread overview]
Message-ID: <4341B239C0EFF9468EE453F9E9F4604D0160625F@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1415088494-10248-1-git-send-email-helin.zhang@intel.com>
> -----Original Message-----
> From: Zhang, Helin
> Sent: Tuesday, November 04, 2014 4:08 PM
> To: dev@dpdk.org
> Cc: Cao, Waterman; Cao, Min; Xu, HuilongX; Chen, Jing D; Zhang, Helin
> Subject: [PATCH] i40e: fix of PF interrupt handling
>
> 'PFINT_ICR0_ENA' shouldn't be cleared in user space ISR,
> otherwise adminq interrupts might be missed during
> co-working with VF initialization.
>
> Signed-off-by: Helin Zhang <helin.zhang@intel.com>
> ---
> lib/librte_pmd_i40e/i40e_ethdev.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c
> b/lib/librte_pmd_i40e/i40e_ethdev.c
> index 661d146..ea10c26 100644
> --- a/lib/librte_pmd_i40e/i40e_ethdev.c
> +++ b/lib/librte_pmd_i40e/i40e_ethdev.c
> @@ -3574,7 +3574,6 @@ i40e_dev_interrupt_delayed_handler(void *param)
> i40e_dev_link_update(dev, 0);
> _rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_LSC);
>
> - I40E_WRITE_REG(hw, I40E_PFINT_ICR0_ENA,
> I40E_PFINT_ICR0_ENA_MASK);
> i40e_pf_enable_irq0(hw);
> rte_intr_enable(&(dev->pci_dev->intr_handle));
> }
> @@ -3601,7 +3600,6 @@ i40e_dev_interrupt_handler(__rte_unused struct
> rte_intr_handle *handle,
>
> /* Disable interrupt */
> i40e_pf_disable_irq0(hw);
> - I40E_WRITE_REG(hw, I40E_PFINT_ICR0_ENA, 0);
>
> /* read out interrupt causes */
> icr0 = I40E_READ_REG(hw, I40E_PFINT_ICR0);
> @@ -3663,7 +3661,6 @@ i40e_dev_interrupt_handler(__rte_unused struct
> rte_intr_handle *handle,
>
> done:
> /* Enable interrupt */
> - I40E_WRITE_REG(hw, I40E_PFINT_ICR0_ENA,
> I40E_PFINT_ICR0_ENA_MASK);
> i40e_pf_enable_irq0(hw);
> rte_intr_enable(&(dev->pci_dev->intr_handle));
> }
> --
> 1.8.1.4
Acked-by : Jing Chen <jing.d.chen@intel.com>
next prev parent reply other threads:[~2014-11-04 8:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 8:08 Helin Zhang
2014-11-04 8:13 ` Chen, Jing D [this message]
2014-11-04 10:20 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4341B239C0EFF9468EE453F9E9F4604D0160625F@shsmsx102.ccr.corp.intel.com \
--to=jing.d.chen@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).