From: "Chen, Jing D" <jing.d.chen@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] fm10k: add debug info for actual Rx/Tx func
Date: Wed, 25 Nov 2015 08:47:47 +0000 [thread overview]
Message-ID: <4341B239C0EFF9468EE453F9E9F4604D02B0D7D1@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20151124084159.57bae59d@xeon-e3>
> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Wednesday, November 25, 2015 12:42 AM
> To: Thomas Monjalon
> Cc: Chen, Jing D; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] fm10k: add debug info for actual Rx/Tx func
>
> On Tue, 24 Nov 2015 11:32:46 +0100
> Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
>
> > 2015-11-24 14:00, Chen Jing D:
> > > This patch adds debug info to notify user what actual Rx/Tx
> > > func are used.
> > [...]
> > > + if (rx_using_sse)
> > > + PMD_INIT_LOG(ERR, "Use vector Rx func");
> > > + else
> > > + PMD_INIT_LOG(ERR, "Use regular Rx func");
> >
> > debug info != LOG(ERR
>
> Really should be DEBUG.
> Developers need to remember you don't wan to see those log messages
> in a production system.
Thanks for the comments. I'll change accordingly.
next prev parent reply other threads:[~2015-11-25 8:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-24 6:00 Chen Jing D(Mark)
2015-11-24 10:32 ` Thomas Monjalon
2015-11-24 16:41 ` Stephen Hemminger
2015-11-25 8:47 ` Chen, Jing D [this message]
2015-11-27 1:54 ` [dpdk-dev] [PATCH v2] " Chen Jing D(Mark)
2015-11-27 18:53 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4341B239C0EFF9468EE453F9E9F4604D02B0D7D1@shsmsx102.ccr.corp.intel.com \
--to=jing.d.chen@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).