From: "Chen, Jing D" <jing.d.chen@intel.com>
To: "Mcnamara, John" <john.mcnamara@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] doc: add Vector FM10K introductions
Date: Tue, 23 Feb 2016 07:37:03 +0000 [thread overview]
Message-ID: <4341B239C0EFF9468EE453F9E9F4604D044460A5@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <B27915DBBA3421428155699D51E4CFE20245DDAE@IRSMSX103.ger.corp.intel.com>
Hi, John,
Best Regards,
Mark
> -----Original Message-----
> From: Mcnamara, John
> Sent: Monday, February 22, 2016 9:47 PM
> To: Chen, Jing D; dev@dpdk.org
> Subject: RE: [PATCH v2] doc: add Vector FM10K introductions
>
> > -----Original Message-----
> > From: Chen, Jing D
> > Sent: Saturday, February 6, 2016 6:48 AM
> > To: dev@dpdk.org
> > Cc: Mcnamara, John <john.mcnamara@intel.com>; Chen, Jing D
> > <jing.d.chen@intel.com>
> > Subject: [PATCH v2] doc: add Vector FM10K introductions
> >
> > From: "Chen Jing D(Mark)" <jing.d.chen@intel.com>
> >
> > Add introductions on how to enable Vector FM10K Rx/Tx functions, the
> > preconditions and assumptions on Rx/Tx configuration parameters.
>
> Hi Mark,
>
> Thanks for the update. A few minor comments below.
>
>
>
> > +Vector PMD (vPMD) uses Intel® SIMD instructions to optimize packet I/O.
> > +It improves load/store bandwidth efficiency of L1 data cache by using a
> > +wider SSE/AVX register 1 (1).
>
> This should probably be "register (1)"
>
>
> > +The wider register gives space to hold multiple packet buffers so as to
> > +save instruction number when processing bulk of packets.
>
> Maybe a little clearer as:
>
> The wider register gives space to hold multiple packet buffers so as to save
> on the number of instructions when bulk processing packets.
>
>
> > +
> > +There is no change to PMD API. The RX/TX handler are the only two
> > +entries for vPMD packet I/O. They are transparently registered at
> > +runtime RX/TX execution if all condition checks pass.
>
> s/if all condition checks pass./if all conditions are met./
>
>
> > +As vPMD is focused on high throughput, it 4 packets at a time. So it
>
> s/it 4 packets at a time/it processes 4 packets at a time/
>
> John
Many thanks for the comments. I'll change and send a new version soon.
next prev parent reply other threads:[~2016-02-23 7:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-23 8:59 [dpdk-dev] [PATCH] " Chen Jing D(Mark)
2016-02-06 6:48 ` [dpdk-dev] [PATCH v2] " Chen Jing D(Mark)
2016-02-22 13:47 ` Mcnamara, John
2016-02-23 7:37 ` Chen, Jing D [this message]
2016-02-26 5:56 ` [dpdk-dev] [PATCH v3] " Chen Jing D(Mark)
2016-03-08 8:06 ` Mcnamara, John
2016-03-09 17:42 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4341B239C0EFF9468EE453F9E9F4604D044460A5@shsmsx102.ccr.corp.intel.com \
--to=jing.d.chen@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).