From: "Chen, Jing D" <jing.d.chen@intel.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3 1/3] fm10k: enable FTAG based forwarding
Date: Thu, 25 Feb 2016 15:45:45 +0000 [thread overview]
Message-ID: <4341B239C0EFF9468EE453F9E9F4604D044503C3@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20160225133518.GB20868@bricha3-MOBL3>
Hi, Bruce,
> -----Original Message-----
> From: Richardson, Bruce
> Sent: Thursday, February 25, 2016 9:35 PM
> To: Chen, Jing D <jing.d.chen@intel.com>
> Cc: Thomas Monjalon <thomas.monjalon@6wind.com>; Wang, Xiao W
> <xiao.w.wang@intel.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3 1/3] fm10k: enable FTAG based
> forwarding
>
> On Thu, Feb 25, 2016 at 10:04:02AM +0000, Chen, Jing D wrote:
> > Hi, Bruce, Thomas,
> >
> > Best Regards,
> > Mark
> >
> > > -----Original Message-----
> > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas
> Monjalon
> > > Sent: Thursday, February 25, 2016 12:38 AM
> > > To: Richardson, Bruce; Wang, Xiao W
> > > Cc: dev@dpdk.org
> > > Subject: Re: [dpdk-dev] [PATCH v3 1/3] fm10k: enable FTAG based
> > > forwarding
> > >
> > > 2016-02-24 15:42, Bruce Richardson:
> > > > On Thu, Feb 04, 2016 at 11:38:47AM +0800, Wang Xiao W wrote:
> > > > > This patch enables reading sglort info into mbuf for RX and
> > > > > inserting an FTAG at the beginning of the packet for TX. The
> > > > > vlan_tci_outer field selected from rte_mbuf structure for sglort is not
> used in fm10k now.
> > > > > In FTAG based forwarding mode, the switch will forward packets
> > > according
> > > > > to glort info in FTAG rather than mac and vlan table.
> > > > >
> > > > > To activate this feature, user needs to turn
> > > ``CONFIG_RTE_LIBRTE_FM10K_FTAG_FWD``
> > > > > to y in common_linuxapp or common_bsdapp. Currently this feature
> > > > > is
> > > supported
> > > > > only on PF, because FM10K_PFVTCTL register is read-only for VF.
> > > > >
> > > > > Signed-off-by: Wang Xiao W <xiao.w.wang@intel.com>
> > > >
> > > > Any comments on this patch?
> > > >
> > > > My thoughts: is there a way in which this could be done without
> > > > adding in a
> > > new
> > > > build time config option?
> > >
> > > Bruce, it's simpler to explain that build time options are forbidden
> > > to enable such options.
> > > Or the terrific kid's approach: one day, the Big Build-Option Eater
> > > will come and will eat every undecided features! ;)
> >
> > This feature is trying to use FTAG (a unique tech in fm10k) instead of
> > mac/vlan to forward packets. App need a way to tell PMD driver that
> > which forwarding style it would like to use.
>
> Why not just specify this in the port configuration at setup time?
>
Please educate me. I think the port configuration flags are also common to all PMD
Drivers. Is it possible to add a flag like "RTE_USE_FTAG" and pass to PMD driver?
> > So, the best option is to let packets carry a flag in mbuf to tell drive in fast
> path.
> > You can see that this is unique to fm10k and we thought community
> > won't like to see this flag introduced into mbuf. If you do agree, we can
> introduce a new flag.
>
> Why does it need to be specified per-mbuf? The existing config flag added is
> global, so a per-mbuf flag shouldn't be needed to get equivalent behaviour.
>
> > So, we step backwards and assume customer will use static
> > configurations to enable this feature. After it is enabled, we'll assume app
> will use FTAG for all packets.
>
> Yes, but instead of compile time option, why not port config-time option
> instead?
>
> /Bruce
next prev parent reply other threads:[~2016-02-25 15:45 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 8:07 [dpdk-dev] [PATCH 0/3] " Wang Xiao W
2016-01-25 8:07 ` [dpdk-dev] [PATCH 1/3] " Wang Xiao W
2016-02-02 3:07 ` Qiu, Michael
2016-02-02 10:03 ` Wang, Xiao W
2016-02-02 10:50 ` [dpdk-dev] [PATCH v2 0/3] " Wang Xiao W
2016-02-02 10:50 ` [dpdk-dev] [PATCH v2 1/3] " Wang Xiao W
2016-02-03 6:52 ` Chen, Jing D
2016-02-04 2:39 ` Wang, Xiao W
2016-02-04 3:38 ` [dpdk-dev] [PATCH v3 0/3] " Wang Xiao W
2016-02-04 3:38 ` [dpdk-dev] [PATCH v3 1/3] " Wang Xiao W
2016-02-24 15:42 ` Bruce Richardson
2016-02-24 16:37 ` Thomas Monjalon
2016-02-24 17:05 ` Bruce Richardson
2016-02-25 10:04 ` Chen, Jing D
2016-02-25 13:35 ` Bruce Richardson
2016-02-25 15:45 ` Chen, Jing D [this message]
2016-02-25 16:14 ` Bruce Richardson
2016-02-26 4:31 ` Wang, Xiao W
2016-02-26 9:06 ` Thomas Monjalon
2016-02-26 9:24 ` Wang, Xiao W
2016-02-26 14:48 ` Bruce Richardson
2016-02-26 15:00 ` David Marchand
2016-02-26 16:33 ` Bruce Richardson
2016-02-29 1:47 ` Wang, Xiao W
2016-02-26 20:48 ` Thomas Monjalon
2016-03-01 5:36 ` [dpdk-dev] [PATCH v4 0/3] " Wang Xiao W
2016-03-01 5:36 ` [dpdk-dev] [PATCH v4 1/3] " Wang Xiao W
2016-03-01 7:35 ` Thomas Monjalon
2016-03-01 11:06 ` Wang, Xiao W
2016-03-01 22:37 ` Stephen Hemminger
2016-03-02 6:05 ` Wang, Xiao W
2016-03-02 13:47 ` Thomas Monjalon
2016-03-02 11:19 ` [dpdk-dev] [PATCH v5 0/2] " Wang Xiao W
2016-03-02 11:19 ` [dpdk-dev] [PATCH v5 1/2] " Wang Xiao W
2016-03-10 16:32 ` Bruce Richardson
2016-03-02 11:19 ` [dpdk-dev] [PATCH v5 2/2] doc: add introduction for fm10k " Wang Xiao W
2016-03-08 7:57 ` [dpdk-dev] [PATCH v5 0/2] fm10k: enable " Liu, Yong
2016-03-10 3:34 ` Wang, Xiao W
2016-03-10 16:40 ` Bruce Richardson
2016-03-01 5:36 ` [dpdk-dev] [PATCH v4 2/3] doc: add introduction for fm10k " Wang Xiao W
2016-03-01 5:36 ` [dpdk-dev] [PATCH v4 3/3] doc: update release note for fm10k FTAG support Wang Xiao W
2016-02-04 3:38 ` [dpdk-dev] [PATCH v3 2/3] doc: add introduction for fm10k FTAG based forwarding Wang Xiao W
2016-02-22 14:06 ` Mcnamara, John
2016-02-04 3:38 ` [dpdk-dev] [PATCH v3 3/3] doc: update release note for fm10k FTAG support Wang Xiao W
2016-02-22 13:51 ` Mcnamara, John
2016-02-04 9:47 ` [dpdk-dev] [PATCH v3 0/3] fm10k: enable FTAG based forwarding Chen, Jing D
2016-02-02 10:50 ` [dpdk-dev] [PATCH v2 2/3] doc: add introduction for fm10k " Wang Xiao W
2016-02-02 10:50 ` [dpdk-dev] [PATCH v2 3/3] doc: update release note for fm10k FTAG support Wang Xiao W
2016-01-25 8:07 ` [dpdk-dev] [PATCH 2/3] doc: add introduction for fm10k FTAG based forwarding Wang Xiao W
2016-01-25 8:07 ` [dpdk-dev] [PATCH 3/3] doc: update release note for fm10k FTAG support Wang Xiao W
2016-02-01 16:20 ` Mcnamara, John
2016-01-26 6:01 ` [dpdk-dev] [PATCH 0/3] fm10k: enable FTAG based forwarding Liu, Yong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4341B239C0EFF9468EE453F9E9F4604D044503C3@shsmsx102.ccr.corp.intel.com \
--to=jing.d.chen@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).