From: "Chen, Jing D" <jing.d.chen@intel.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"Zhang, Helin" <helin.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Zhang, Qi Z" <qi.z.zhang@intel.com>
Subject: Re: [dpdk-dev] [PATCH 0/3] net: fix out of order rx read issue
Date: Mon, 17 Oct 2016 15:55:07 +0000 [thread overview]
Message-ID: <4341B239C0EFF9468EE453F9E9F4604D3A39CE44@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1476692614-35793-1-git-send-email-qi.z.zhang@intel.com>
Hi,
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qi Zhang
> Sent: Monday, October 17, 2016 1:24 AM
> To: Wu, Jingjing <jingjing.wu@intel.com>; Zhang, Helin
> <helin.zhang@intel.com>
> Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: [dpdk-dev] [PATCH 0/3] net: fix out of order rx read issue
>
> Volatile point has been cast to non-volatile point when call _mm_loadu_si128,
> so add compile barrier to prevent compiler reorder.
>
> Qi Zhang (3):
> net/i40e: fix out of order rx read issue
> net/ixgbe: fix out of order rx read issue
> net/fm10k: fix out of order rx read issue
>
> drivers/net/fm10k/fm10k_rxtx_vec.c | 3 +++
> drivers/net/i40e/i40e_rxtx_vec.c | 3 +++
> drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c | 3 +++
> 3 files changed, 9 insertions(+)
I have an overall comment on the committed message. You'd better to describe
why we have out of order issue here and the requirement on the execution order
of the 4 loads.
prev parent reply other threads:[~2016-10-17 15:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 8:23 Qi Zhang
2016-10-17 8:23 ` [dpdk-dev] [PATCH 1/3] net/i40e: " Qi Zhang
2016-10-17 8:23 ` [dpdk-dev] [PATCH 2/3] net/ixgbe: " Qi Zhang
2016-10-17 8:23 ` [dpdk-dev] [PATCH 3/3] net/fm10k: " Qi Zhang
2016-10-17 15:55 ` Chen, Jing D [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4341B239C0EFF9468EE453F9E9F4604D3A39CE44@shsmsx102.ccr.corp.intel.com \
--to=jing.d.chen@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=jingjing.wu@intel.com \
--cc=qi.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).