From: Thomas Monjalon <thomas@monjalon.net>
To: Anoob Joseph <anoob.joseph@caviumnetworks.com>
Cc: dev@dpdk.org, Akhil Goyal <akhil.goyal@nxp.com>,
Declan Doherty <declan.doherty@intel.com>,
Radu Nicolau <radu.nicolau@intel.com>,
Jerin Jacob <jerin.jacob@caviumnetworks.com>,
Narayana Prasad <narayanaprasad.athreya@caviumnetworks.com>,
Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Subject: Re: [dpdk-dev] [PATCH v3 1/5] lib/ethdev: support for inline IPsec events
Date: Tue, 10 Apr 2018 11:11:43 +0200 [thread overview]
Message-ID: <4378194.OM6g8PXIhp@xps> (raw)
In-Reply-To: <1521630685-5179-2-git-send-email-anoob.joseph@caviumnetworks.com>
Hi,
21/03/2018 12:11, Anoob Joseph:
> Adding support for IPsec events in rte_eth_event framework. In inline
> IPsec offload, the per packet protocol defined variables, like ESN,
> would be managed by PMD. In such cases, PMD would need IPsec events
> to notify application about various conditions like, ESN overflow.
>
> Signed-off-by: Anoob Joseph <anoob.joseph@caviumnetworks.com>
No comment about IPsec handling.
The documentation could try to better link things together, see below:
> /**
> + * Subtypes for IPsec offload events raised by eth device.
> + */
> +enum rte_eth_event_ipsec_subtype {
> + RTE_ETH_EVENT_IPSEC_UNKNOWN = 0,
> + /** Unknown event type */
> + RTE_ETH_EVENT_IPSEC_ESN_OVERFLOW,
> + /** Sequence number overflow in security offload */
> + RTE_ETH_EVENT_IPSEC_SA_TIME_EXPIRY,
> + /** Soft time expiry of SA */
> + RTE_ETH_EVENT_IPSEC_SA_BYTE_EXPIRY,
> + /** Soft byte expiry of SA */
> + RTE_ETH_EVENT_IPSEC_MAX
> + /** Max value of this enum */
> +};
> +
> +/**
> + * Descriptor for IPsec event. Used by eth dev to send extra information of the
> + * event.
> + */
You could link it to the event type RTE_ETH_EVENT_IPSEC in this doxygen comment.
> +struct rte_eth_event_ipsec_desc {
> + enum rte_eth_event_ipsec_subtype stype;
stype is not easy to read & understand. What about subtype?
> + /** Type of IPsec event */
You could add the prefix of the events in this comment: RTE_ETH_EVENT_IPSEC_*
> + uint64_t md;
What about metadata?
> + /** Event specific metadata */
Could you describe what is the metadata, depending on each sub-type?
> +};
> +
> +/**
> * The eth device event type for interrupt, and maybe others in the future.
> */
> enum rte_eth_event_type {
> @@ -2448,6 +2475,7 @@ enum rte_eth_event_type {
> RTE_ETH_EVENT_INTR_RESET,
> /**< reset interrupt event, sent to VF on PF reset */
> RTE_ETH_EVENT_VF_MBOX, /**< message from the VF received by PF */
> + RTE_ETH_EVENT_IPSEC, /**< IPsec offload related event */
> RTE_ETH_EVENT_MACSEC, /**< MACsec offload related event */
> RTE_ETH_EVENT_INTR_RMV, /**< device removal event */
> RTE_ETH_EVENT_NEW, /**< port is probed */
next prev parent reply other threads:[~2018-04-10 9:11 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1516626668-9031-0-git-send-email-anoob.joseph@caviumnetworks.com>
2018-02-21 5:37 ` [dpdk-dev] [PATCH 0/5] handle seq no overflow in IPsec offload Anoob Joseph
2018-02-21 5:37 ` [dpdk-dev] [PATCH 1/5] lib/ethdev: support for inline IPsec events Anoob Joseph
2018-02-26 9:35 ` Nicolau, Radu
2018-02-27 6:56 ` Anoob Joseph
2018-02-27 10:19 ` Nicolau, Radu
2018-02-27 11:32 ` Anoob Joseph
2018-02-28 9:30 ` Nicolau, Radu
2018-02-21 5:37 ` [dpdk-dev] [PATCH 2/5] lib/security: add ESN soft limit in conf Anoob Joseph
2018-02-21 5:37 ` [dpdk-dev] [PATCH 3/5] lib/security: extend userdata for IPsec events Anoob Joseph
2018-02-21 5:37 ` [dpdk-dev] [PATCH 4/5] examples/ipsec-secgw: handle ESN soft limit event Anoob Joseph
2018-02-21 5:37 ` [dpdk-dev] [PATCH 5/5] app/testpmd: support for IPsec event Anoob Joseph
2018-03-01 9:21 ` [dpdk-dev] [PATCH v2 0/5] handle seq no overflow in IPsec offload Anoob Joseph
2018-03-01 9:21 ` [dpdk-dev] [PATCH v2 1/5] lib/ethdev: support for inline IPsec events Anoob Joseph
2018-03-01 9:21 ` [dpdk-dev] [PATCH v2 2/5] lib/security: add ESN soft limit in conf Anoob Joseph
2018-03-13 12:19 ` Akhil Goyal
2018-03-14 5:15 ` Anoob Joseph
2018-03-01 9:21 ` [dpdk-dev] [PATCH v2 3/5] lib/security: extend userdata for IPsec events Anoob Joseph
2018-03-01 9:21 ` [dpdk-dev] [PATCH v2 4/5] examples/ipsec-secgw: handle ESN soft limit event Anoob Joseph
2018-03-13 12:24 ` Akhil Goyal
2018-03-14 6:06 ` Anoob Joseph
2018-03-21 5:20 ` Anoob Joseph
2018-03-21 7:30 ` Akhil Goyal
2018-03-01 9:21 ` [dpdk-dev] [PATCH v2 5/5] app/testpmd: support for IPsec event Anoob Joseph
2018-03-08 5:57 ` [dpdk-dev] [PATCH v2 0/5] handle seq no overflow in IPsec offload Anoob Joseph
2018-03-21 11:11 ` [dpdk-dev] " Anoob Joseph
2018-03-21 11:11 ` [dpdk-dev] [PATCH v3 1/5] lib/ethdev: support for inline IPsec events Anoob Joseph
2018-03-21 11:42 ` Akhil Goyal
2018-04-03 14:27 ` Anoob Joseph
2018-04-10 5:10 ` Anoob Joseph
2018-04-10 9:11 ` Thomas Monjalon [this message]
2018-04-11 3:20 ` Anoob Joseph
2018-03-21 11:11 ` [dpdk-dev] [PATCH v3 2/5] lib/security: add ESN soft limit in conf Anoob Joseph
2018-04-03 14:27 ` Anoob Joseph
2018-03-21 11:11 ` [dpdk-dev] [PATCH v3 3/5] lib/security: extend userdata for IPsec events Anoob Joseph
2018-04-03 14:28 ` Anoob Joseph
2018-03-21 11:11 ` [dpdk-dev] [PATCH v3 4/5] examples/ipsec-secgw: handle ESN soft limit event Anoob Joseph
2018-04-03 14:28 ` Anoob Joseph
2018-03-21 11:11 ` [dpdk-dev] [PATCH v3 5/5] app/testpmd: support for IPsec event Anoob Joseph
2018-04-03 14:29 ` Anoob Joseph
2018-04-03 14:26 ` [dpdk-dev] [PATCH v3 0/5] handle seq no overflow in IPsec offload Anoob Joseph
2018-04-11 6:40 ` [dpdk-dev] [PATCH v4 " Anoob Joseph
2018-04-11 6:40 ` [dpdk-dev] [PATCH v4 1/5] lib/ethdev: support for inline IPsec events Anoob Joseph
2018-04-19 9:15 ` Anoob Joseph
2018-04-20 15:14 ` Stephen Hemminger
2018-04-19 10:26 ` Thomas Monjalon
2018-04-11 6:40 ` [dpdk-dev] [PATCH v4 2/5] lib/security: add ESN soft limit in conf Anoob Joseph
2018-04-11 6:40 ` [dpdk-dev] [PATCH v4 3/5] lib/security: extend userdata for IPsec events Anoob Joseph
2018-04-11 6:40 ` [dpdk-dev] [PATCH v4 4/5] examples/ipsec-secgw: handle ESN soft limit event Anoob Joseph
2018-04-11 6:40 ` [dpdk-dev] [PATCH v4 5/5] app/testpmd: support for IPsec event Anoob Joseph
2018-04-19 15:44 ` [dpdk-dev] [PATCH v4 0/5] handle seq no overflow in IPsec offload De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4378194.OM6g8PXIhp@xps \
--to=thomas@monjalon.net \
--cc=akhil.goyal@nxp.com \
--cc=anoob.joseph@caviumnetworks.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=narayanaprasad.athreya@caviumnetworks.com \
--cc=nelio.laranjeiro@6wind.com \
--cc=radu.nicolau@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).