From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: dev@dpdk.org, David Marchand <david.marchand@6wind.com>
Subject: Re: [dpdk-dev] [PATCH] virtio: fix wrong features returned for legacy virtio
Date: Mon, 14 Mar 2016 23:21:04 +0100 [thread overview]
Message-ID: <4392228.eN2PaL5BSa@xps13> (raw)
In-Reply-To: <CALwxeUvJwDUNmparc3hT=8SJz1r36LZm6Z9_fFD_rFssuD7nnA@mail.gmail.com>
2016-03-10 08:43, David Marchand:
> On Thu, Mar 10, 2016 at 8:01 AM, Yuanhan Liu
> <yuanhan.liu@linux.intel.com> wrote:
> > Declare dst as type uint32_t instead of uint64_t, otherwise, we will get
> > a random upper 32 bit feature bits, as the following io port read reads
> > lower 32 bit only. It could lead a feature bits that include VIRTIO_F_VERSION_1
> > (the 32th bit) for legacy virtio, which is obviously wrong.
> >
> > Fixes: b8f04520ad71 ("virtio: use PCI ioport API")
> >
> > Cc: David Marchand <david.marchand@6wind.com>
> > Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
>
> Argh, good catch.
> Relooked at my patch, this should be the only bug (of this kind ;-)).
>
> Reviewed-by: David Marchand <david.marchand@6wind.com>
Applied, thanks
prev parent reply other threads:[~2016-03-14 22:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-10 7:01 Yuanhan Liu
2016-03-10 7:19 ` Tan, Jianfeng
2016-03-10 7:43 ` David Marchand
2016-03-10 7:50 ` Yuanhan Liu
2016-03-14 10:48 ` Bruce Richardson
2016-03-14 12:44 ` Yuanhan Liu
2016-03-14 13:54 ` Bruce Richardson
2016-03-14 22:21 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4392228.eN2PaL5BSa@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).