From: Thomas Monjalon <thomas@monjalon.net>
To: "Xueming(Steven) Li" <xuemingl@mellanox.com>,
Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] ethdev: fix applications failure on configure
Date: Wed, 02 May 2018 12:06:11 +0200 [thread overview]
Message-ID: <4396631.OICrUNRNKa@xps> (raw)
In-Reply-To: <VI1PR05MB16782ECA2529512AEB2A6441AC800@VI1PR05MB1678.eurprd05.prod.outlook.com>
02/05/2018 11:58, Xueming(Steven) Li:
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> > Or as Xueming suggested, we can take rss_hf config as best effort and not return error at all.
> >
> > I think this forces PMDs to have up-to-date flow_type_rss_offloads values, is there any other benefit?
> > What was the initial motivation to add error return on this check?
>
> The original idea is to add rss_hf check on mlx5 PMD, while it looks more generic
> to move the check to ethdev api from discussion[1].
>
> [1] http://www.dpdk.org/ml/archives/dev/2018-April/095136.html
I think it is not correct to not return an error when the app
request an offload which is not supported.
Do we agree to work on PMDs and applications to fix this offload compliance?
And submit a deprecation notice to return an error in a later release?
next prev parent reply other threads:[~2018-05-02 10:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-01 13:33 Ferruh Yigit
2018-05-01 13:50 ` Xueming(Steven) Li
2018-05-01 14:01 ` Thomas Monjalon
2018-05-01 14:08 ` Ferruh Yigit
2018-05-01 14:12 ` Thomas Monjalon
2018-05-01 14:32 ` Ferruh Yigit
2018-05-02 9:58 ` Xueming(Steven) Li
2018-05-02 10:06 ` Thomas Monjalon [this message]
2018-05-02 17:09 ` Shahaf Shuler
2018-05-02 17:24 ` Ferruh Yigit
2018-05-01 15:30 ` Thomas Monjalon
2018-05-01 15:59 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4396631.OICrUNRNKa@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=xuemingl@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).