From: Thomas Monjalon <thomas@monjalon.net>
To: luzhipeng <luzhipeng@cestc.cn>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Jan Viktorin <viktorin@rehivetech.com>,
Bruce Richardson <bruce.richardson@intel.com>, nd <nd@arm.com>,
Ruifeng Wang <Ruifeng.Wang@arm.com>
Subject: Re: [PATCH v3] config/arm: add Phytium FT-2000+
Date: Fri, 08 Jul 2022 14:44:52 +0200 [thread overview]
Message-ID: <4422335.nGQf0TPKTz@thomas> (raw)
In-Reply-To: <AS8PR08MB70805AE674C297B9290E38F89E819@AS8PR08MB7080.eurprd08.prod.outlook.com>
05/07/2022 15:50, Ruifeng Wang:
> > From: luzhipeng <luzhipeng@cestc.cn>
> >
> > Here adds configs for Phytium server.
> >
> > Signed-off-by: luzhipeng <luzhipeng@cestc.cn>
> > Reviewed-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
> > I did some changes in this v3:
> > - PHYTIUM -> Phytium (as on the website)
> > - ft2000plus -> FT-2000+ (as found online)
> > - alphabetical ordering
> > - extra commas for future extensions
> > - g++ as cpp Meson command
> >
> > Please tell how to write your name with spaces and capitals in the order [first
> > name] [family name], thanks.
> > ---
>
> <snip>
>
> > implementer_qualcomm = {
> > 'description': 'Qualcomm',
> > 'flags': [
> > @@ -214,7 +228,7 @@ implementer_qualcomm = {
> > '0xc00': {
> > 'march': 'armv8-a',
> > 'march_features': ['crc']
> > - }
> > + },
>
> Unintentional change?
> The change is valid, but not related to this patch.
>
> Otherwise looks good to me.
> Acked-by: Ruifeng Wang <ruifeng.wang@arm.com>
Applied (without above unintentional change), thanks.
next prev parent reply other threads:[~2022-07-08 12:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 6:24 [PATCH v2] config/arm: add PHYTIUM ft2000plus luzhipeng
2022-07-05 13:30 ` [PATCH v3] config/arm: add Phytium FT-2000+ Thomas Monjalon
2022-07-05 13:50 ` Ruifeng Wang
2022-07-05 13:57 ` Thomas Monjalon
2022-07-08 12:44 ` Thomas Monjalon [this message]
2022-07-05 14:25 ` Morten Brørup
2022-07-05 14:31 ` Morten Brørup
2022-07-06 1:02 ` luzhipeng
2022-07-06 1:28 ` luzhipeng
2022-07-06 6:59 ` Thomas Monjalon
2022-07-06 7:00 ` luzhipeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4422335.nGQf0TPKTz@thomas \
--to=thomas@monjalon.net \
--cc=Ruifeng.Wang@arm.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=luzhipeng@cestc.cn \
--cc=nd@arm.com \
--cc=viktorin@rehivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).