From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ajit Khaparde <ajit.khaparde@broadcom.com>,
dev@dpdk.org, Shahaf Shuler <shahafs@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH v4 2/2] net/bnxt: switch to the new offload API
Date: Fri, 6 Apr 2018 16:11:04 +0100 [thread overview]
Message-ID: <4430e0f2-198c-3f15-90ca-30708035bec8@intel.com> (raw)
In-Reply-To: <20180406002203.87720-2-ajit.khaparde@broadcom.com>
On 4/6/2018 1:22 AM, Ajit Khaparde wrote:
> Update bnxt PMD to new ethdev offloads API.
>
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> --
> v1->v2: return an error if requested offload flags do not
> match supported offload capabilities.
> v2->v3: modify the code based on review comments.
> v3->v4: fix compilation for i686 configuration.
> ---
> drivers/net/bnxt/bnxt_ethdev.c | 62 ++++++++++++++++++++++++++++++------------
Hi Ajit,
I can see there are a few more rxmode.xxx usage in bnxt driver not covered with
this patch.
Expectation is to switch "offloads" version of those. Like, rxmode.hw_strip_crc,
rxmode.enable_lro, rxmode.hw_vlan_filter etc ...
I believe this patch should convert them all. cc'ed Shahaf too.
<...>
next prev parent reply other threads:[~2018-04-06 15:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 19:40 [dpdk-dev] [PATCH] " Ajit Khaparde
2018-03-21 19:08 ` Ferruh Yigit
2018-03-21 19:27 ` Ajit Khaparde
2018-03-22 6:22 ` Shahaf Shuler
2018-03-26 22:47 ` [dpdk-dev] [PATCH v2] " Ajit Khaparde
2018-03-30 10:38 ` Ferruh Yigit
2018-04-02 22:25 ` [dpdk-dev] [PATCH v3 1/2] " Ajit Khaparde
2018-04-02 22:25 ` [dpdk-dev] [PATCH v3 2/2] net/bnxt: fix rx_drop_en setting Ajit Khaparde
2018-04-05 14:36 ` [dpdk-dev] [PATCH v3 1/2] net/bnxt: switch to the new offload API Ferruh Yigit
2018-04-06 0:22 ` [dpdk-dev] [PATCH v4 1/2] net/bnxt: fix rx_drop_en setting Ajit Khaparde
2018-04-06 0:22 ` [dpdk-dev] [PATCH v4 2/2] net/bnxt: switch to the new offload API Ajit Khaparde
2018-04-06 15:11 ` Ferruh Yigit [this message]
2018-04-07 17:40 ` [dpdk-dev] [PATCH v5 1/2] net/bnxt: fix rx_drop_en setting Ajit Khaparde
2018-04-07 17:40 ` [dpdk-dev] [PATCH v5 2/2] net/bnxt: switch to the new offload API Ajit Khaparde
2018-04-09 16:53 ` [dpdk-dev] [dpdk-stable] [PATCH v5 1/2] net/bnxt: fix rx_drop_en setting Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4430e0f2-198c-3f15-90ca-30708035bec8@intel.com \
--to=ferruh.yigit@intel.com \
--cc=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=shahafs@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).