From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
David Marchand <david.marchand@redhat.com>,
dev@dpdk.org
Cc: olivier.matz@6wind.com, Chenbo Xia <chenbo.xia@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] net/virtio: fix virtio-user init when using existing tap
Date: Thu, 30 Sep 2021 11:27:52 +0200 [thread overview]
Message-ID: <4443f090-5321-b1b3-9781-e1576dc83fe7@redhat.com> (raw)
In-Reply-To: <8acaa61f-a5c8-b118-045b-c42b4ad3f6b9@intel.com>
On 9/29/21 15:19, Ferruh Yigit wrote:
> On 9/28/2021 9:51 AM, David Marchand wrote:
>> When attaching to an existing mono queue tap, the virtio-user was not
>> reporting that the virtio device was not properly initialised which
>> prevented from starting the port later.
>>
>> $ ip tuntap add test mode tap
>> $ dpdk-testpmd --vdev \
>> net_virtio_user0,iface=test,path=/dev/vhost-net,queues=2 -- -i
>>
>> ...
>> virtio_user_dev_init_mac(): (/dev/vhost-net) No valid MAC in devargs or
>> device, use random
>> vhost_kernel_open_tap(): TUNSETIFF failed: Invalid argument
>> vhost_kernel_enable_queue_pair(): fail to open tap for vhost kernel
>> virtio_user_start_device(): (/dev/vhost-net) Failed to start device
>> ...
>> Configuring Port 0 (socket 0)
>> vhost_kernel_open_tap(): TUNSETIFF failed: Invalid argument
>> vhost_kernel_enable_queue_pair(): fail to open tap for vhost kernel
>> virtio_set_multiple_queues(): Multiqueue configured but send command
>> failed, this is too late now...
>> Fail to start port 0: Invalid argument
>> Please stop the ports first
>> Done
>>
>> The virtio-user with vhost-kernel backend was going through a lot
>> of complications to initialise tap fds only when using them.
>>
>> For each qp enabled for the first time, a tapfd was created via
>> TUNSETIFF with unneeded additional steps (see below) and then mapped to
>> the right qp in the vhost-net backend.
>> Unneeded steps (as long as it has been done once for the port):
>> - tap features were queried while this is a constant on a running
>> system,
>> - the device name in DPDK was updated,
>> - the mac address of the tap was set,
>>
>> On subsequent qps state change, the vhost-net backend fd mapping was
>> updated and the associated queue/tapfd were disabled/enabled via
>> TUNSETQUEUE.
>>
>> Now, this patch simplifies the whole logic by keeping all tapfds opened
>> and in enabled state (from the tap point of view) at all time.
>>
>> Unused ioctl defines are removed.
>>
>> Tap features are validated earlier to fail initialisation asap.
>> Tap name discovery and mac address configuration are moved when
>> configuring qp 0.
>>
>> To support attaching to mono queue tap, the virtio-user driver now tries
>> to attach in multi queue first, then fallbacks to mono queue.
>>
>> Finally (but this is more for consistency), VIRTIO_NET_F_MQ feature is
>> exposed only if the underlying tap supports multi queue.
>>
>> Signed-off-by: David Marchand <david.marchand@redhat.com>
>
> Do we want to backport this patch? If so can you please provide a fixes tag?
>
No, we don't want to backport it.
Thanks,
Maxime
next prev parent reply other threads:[~2021-09-30 9:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-17 9:33 [dpdk-dev] [PATCH] " David Marchand
2021-09-23 15:39 ` Olivier Matz
2021-09-23 16:45 ` David Marchand
2021-09-28 8:51 ` [dpdk-dev] [PATCH v2] " David Marchand
2021-09-28 10:12 ` Maxime Coquelin
2021-09-29 13:19 ` Ferruh Yigit
2021-09-30 9:27 ` Maxime Coquelin [this message]
2021-09-28 15:38 ` [dpdk-dev] [PATCH] " Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4443f090-5321-b1b3-9781-e1576dc83fe7@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).