From: Thomas Monjalon <thomas@monjalon.net>
To: Xuan Ding <xuan.ding@intel.com>
Cc: mdr@ashroe.eu, andrew.rybchenko@oktetlabs.ru,
ferruh.yigit@xilinx.com, viacheslavo@nvidia.com, dev@dpdk.org,
stephen@networkplumber.org, mb@smartsharesystems.com,
qi.z.zhang@intel.com, asekhar@marvell.com,
pbhagavatula@marvell.com
Subject: Re: [PATCH v2] doc: announce header split deprecation
Date: Sat, 16 Jul 2022 23:28:36 +0200 [thread overview]
Message-ID: <44812611.fMDQidcC6G@thomas> (raw)
In-Reply-To: <20220715203055.64074-1-xuan.ding@intel.com>
15/07/2022 22:30, xuan.ding@intel.com:
> From: Xuan Ding <xuan.ding@intel.com>
>
> RTE_ETH_RX_OFFLOAD_HEADER_SPLIT offload was introduced some time ago to
> substitute bit-field header_split in struct rte_eth_rxmode. It allows
> to enable per-port header split offload with the header size controlled
> using split_hdr_size in the same structure.
>
> Right now, no single PMD actually supports RTE_ETH_RX_OFFLOAD_HEADER_SPLIT
> with above definition. Many examples and test apps initialize the field
> to 0 explicitly. The most of drivers simply ignore split_hdr_size since
> the offload is not advertised, but some double-check that its value is 0.
>
> So the RTE_ETH_RX_OFFLOAD_HEADER_SPLIT and split_header_size field
> will be removed in DPDK 22.11. After DPDK 22.11 LTS, the
> RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT can still be used for per-queue Rx
> packet split offload, which is configured by rte_eth_rxseg_split.
>
> Signed-off-by: Xuan Ding <xuan.ding@intel.com>
> Acked-by: Ray Kinsella <mdr@ashroe.eu>
> Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> Acked-by: Ferruh Yigit <ferruh.yigit@xilinx.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
This v2 is a lot better for the users to understand what happens.
Fixed the indent and moved few words:
* ethdev: Since no single PMD supports ``RTE_ETH_RX_OFFLOAD_HEADER_SPLIT``
offload and the ``split_hdr_size`` field in structure ``rte_eth_rxmode``
to enable per-port header split, they will be removed in DPDK 22.11.
The per-queue Rx packet split offload ``RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT``
can still be used, and it is configured by ``rte_eth_rxseg_split``.
Applied, thanks.
prev parent reply other threads:[~2022-07-16 21:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-23 14:20 [PATCH] " xuan.ding
2022-05-24 14:58 ` Ray Kinsella
2022-07-12 11:43 ` Andrew Rybchenko
2022-07-13 9:49 ` Thomas Monjalon
2022-07-14 5:50 ` Ding, Xuan
2022-07-14 8:08 ` Thomas Monjalon
2022-07-14 12:54 ` Ding, Xuan
2022-07-14 13:25 ` Thomas Monjalon
2022-07-14 14:07 ` Ding, Xuan
2022-07-14 15:58 ` Ferruh Yigit
2022-07-14 16:03 ` Ferruh Yigit
2022-07-15 8:52 ` Ding, Xuan
2022-07-14 16:56 ` Slava Ovsiienko
2022-07-15 8:28 ` Ding, Xuan
2022-07-15 11:34 ` Ferruh Yigit
2022-07-15 12:43 ` Ding, Xuan
2022-07-15 12:13 ` Andrew Rybchenko
2022-07-15 12:44 ` Ding, Xuan
2022-07-15 20:30 ` [PATCH v2] " xuan.ding
2022-07-16 21:28 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44812611.fMDQidcC6G@thomas \
--to=thomas@monjalon.net \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=asekhar@marvell.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@xilinx.com \
--cc=mb@smartsharesystems.com \
--cc=mdr@ashroe.eu \
--cc=pbhagavatula@marvell.com \
--cc=qi.z.zhang@intel.com \
--cc=stephen@networkplumber.org \
--cc=viacheslavo@nvidia.com \
--cc=xuan.ding@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).