From: "Singh, Aman Deep" <aman.deep.singh@intel.com>
To: <rohit.raj@nxp.com>
Cc: <dev@dpdk.org>, <nipun.gupta@nxp.com>, <hemant.agrawal@nxp.com>,
"Sachin Saxena" <sachin.saxena@nxp.com>,
Vanshika Shukla <vanshika.shukla@nxp.com>
Subject: Re: [dpdk-dev] [PATCH v1] examples/l3fwd: fix jumbo packet drop issue
Date: Wed, 11 Aug 2021 15:49:28 +0530 [thread overview]
Message-ID: <4481d0de-e691-110b-1dc4-fd7218a86d30@intel.com> (raw)
In-Reply-To: <20210727092523.22718-1-rohit.raj@nxp.com>
Hi Rohit,
On 7/27/2021 2:55 PM, rohit.raj@nxp.com wrote:
> From: Rohit Raj <rohit.raj@nxp.com>
>
> l3fwd uses mbufs with 2KB data size. If we enable jumbo packets, it is
> not able to store packets with size greater than 2KB, hence these
> packets are dropped.
>
> This patch fixes this issue by enabling scatter for jumbo packet, if
> it is supported by NIC.
>
> If scatter is not supported by NIC and max jumbo packet length is
> greater than default mbuf data size, then application exits with
> proper error message.
>
> Fixes: f68aad7904f ("examples/l3fwd: update")
>
> Signed-off-by: Rohit Raj <rohit.raj@nxp.com>
> Signed-off-by: Sachin Saxena <sachin.saxena@nxp.com>
> Signed-off-by: Vanshika Shukla <vanshika.shukla@nxp.com>
> ---
> examples/l3fwd/main.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c
> index 4cb800aa15..6aaaa8ecb5 100644
> --- a/examples/l3fwd/main.c
> +++ b/examples/l3fwd/main.c
> @@ -1035,6 +1035,20 @@ l3fwd_poll_resource_setup(void)
> "Error during getting device (port %u) info: %s\n",
> portid, strerror(-ret));
>
> + /* Enable Receive side SCATTER, if supported by NIC,
> + * when jumbo packet is enabled.
> + */
> + if (local_port_conf.rxmode.offloads &
> + DEV_RX_OFFLOAD_JUMBO_FRAME){
> + if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_SCATTER)
> + local_port_conf.rxmode.offloads |=
> + DEV_RX_OFFLOAD_SCATTER;
> + else if (local_port_conf.rxmode.max_rx_pkt_len >
> + RTE_MBUF_DEFAULT_DATAROOM)
> + rte_exit(EXIT_FAILURE,
> + "Max packet length greater than default MBUF size\n");
> + }
> +
> if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE)
> local_port_conf.txmode.offloads |=
> DEV_TX_OFFLOAD_MBUF_FAST_FREE;
Acked-by: Aman Deep Singh <aman.deep.singh@intel.com>
next prev parent reply other threads:[~2021-08-11 10:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-27 9:25 rohit.raj
2021-08-11 10:19 ` Singh, Aman Deep [this message]
2021-08-11 11:30 ` Ferruh Yigit
2021-11-12 3:16 ` [PATCH v2] " rohit.raj
2021-11-12 9:40 ` Ananyev, Konstantin
2021-11-16 6:08 ` [EXT] " Rohit Raj
2021-08-13 4:48 [dpdk-dev] [PATCH v1] " Rohit Raj
2021-08-13 8:42 ` Ferruh Yigit
2021-10-19 21:22 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4481d0de-e691-110b-1dc4-fd7218a86d30@intel.com \
--to=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=nipun.gupta@nxp.com \
--cc=rohit.raj@nxp.com \
--cc=sachin.saxena@nxp.com \
--cc=vanshika.shukla@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).