DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Eric Kinzie <ekinzie@brocade.com>
Subject: Re: [dpdk-dev] [PATCH] mk: fix ABI versioning compile error for combined shared library
Date: Mon, 02 Nov 2015 00:24:51 +0100	[thread overview]
Message-ID: <4489406.qekDmzhmkY@xps13> (raw)
In-Reply-To: <1446419842-22920-1-git-send-email-ferruh.yigit@intel.com>

2015-11-01 23:17, Ferruh Yigit:
> Fixes following error:
>   LD libdpdk.so
>   /usr/bin/ld: /root/dpdk/build/lib/libdpdk.so: version node not found
>   for symbol <function>@DPDK_x.y

> --- a/mk/rte.sharelib.mk
> +++ b/mk/rte.sharelib.mk
> @@ -40,6 +40,7 @@ LIB_ONE := lib$(RTE_LIBNAME).so
>  else
>  LIB_ONE := lib$(RTE_LIBNAME).a
>  endif
> +SHARED_LDFLAGS += --version-script=./lib/libdpdk.map
>  endif

It looks to be the right thing to do.

>  ifeq ($(LINK_USING_CC),1)
>  # Override the definition of LD here, since we're linking with CC
>  LD := $(CC) $(CPU_CFLAGS)
> -O_TO_S = $(LD) $(call linkerprefix,$(CPU_LDFLAGS)) \
> +O_TO_S = $(LD) $(call linkerprefix,$(SHARED_LDFLAGS)) \
>  	-shared $(OBJS) -o $(RTE_OUTPUT)/lib/$(LIB_ONE)
>  else
> -O_TO_S = $(LD) $(CPU_LDFLAGS) \
> +O_TO_S = $(LD) $(SHARED_LDFLAGS) \
>  	-shared $(OBJS) -o $(RTE_OUTPUT)/lib/$(LIB_ONE)
>  endif

Why do you remove CPU_LDFLAGS?

  reply	other threads:[~2015-11-01 23:26 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-19 15:36 [dpdk-dev] [PATCH v6 0/4] bonding corrections and additions Eric Kinzie
2015-10-19 15:36 ` [dpdk-dev] [PATCH v6 1/4] bond mode 4: copy entire config structure Eric Kinzie
2015-10-19 15:36 ` [dpdk-dev] [PATCH v6 2/4] bond mode 4: do not ignore multicast Eric Kinzie
2015-10-19 15:36 ` [dpdk-dev] [PATCH v6 3/4] bond mode 4: allow external state machine Eric Kinzie
2015-11-01 18:17   ` Thomas Monjalon
2015-11-01 23:17     ` [dpdk-dev] [PATCH] mk: fix ABI versioning compile error for combined shared library Ferruh Yigit
2015-11-01 23:24       ` Thomas Monjalon [this message]
2015-11-02  0:05         ` Ferruh Yigit
2015-11-02  7:10           ` Thomas Monjalon
2015-11-02 10:20             ` Ferruh Yigit
2015-11-02 15:23               ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2015-11-02 16:26                 ` Thomas Monjalon
2015-11-02 19:18                   ` Ferruh Yigit
2015-11-03  7:06                 ` Panu Matilainen
2015-11-03  9:20                   ` Ferruh Yigit
2015-11-03 10:41                     ` Panu Matilainen
2015-11-03 11:33                       ` Ferruh Yigit
2015-11-03 11:43                         ` Panu Matilainen
2015-11-06 13:58                 ` [dpdk-dev] [PATCH] " Ferruh Yigit
2015-11-06 13:58                   ` Ferruh Yigit
2015-11-02 10:23     ` [dpdk-dev] [PATCH v6 3/4] bond mode 4: allow external state machine Panu Matilainen
2015-11-02 16:42       ` Eric Kinzie
2015-11-03  6:48         ` Panu Matilainen
2015-11-03  8:16           ` Thomas Monjalon
2015-11-03  8:30             ` Panu Matilainen
2015-11-03  9:38               ` Thomas Monjalon
2015-11-03 17:12               ` Eric Kinzie
2015-11-03 11:02           ` Ferruh Yigit
2015-11-03 11:31             ` Panu Matilainen
2015-11-03 11:48               ` Ferruh Yigit
2015-11-20 19:46                 ` Eric Kinzie
2015-11-24 14:52                   ` Panu Matilainen
2015-10-19 15:36 ` [dpdk-dev] [PATCH v6 4/4] bond mode 4: tests for " Eric Kinzie
2015-10-19 16:27 ` [dpdk-dev] [PATCH v6 0/4] bonding corrections and additions Declan Doherty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4489406.qekDmzhmkY@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=ekinzie@brocade.com \
    --cc=ferruh.yigit@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).