DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, "Xia, Chenbo" <chenbo.xia@intel.com>,
	Adrian Moreno Zapata <amorenoz@redhat.com>,
	Olivier Matz <olivier.matz@6wind.com>,
	bnemeth@redhat.com
Subject: Re: [dpdk-dev] [PATCH v3 3/4] net/virtio: allocate fake mbuf in Rx queue
Date: Mon, 15 Mar 2021 18:02:33 +0100	[thread overview]
Message-ID: <44e52bf5-9e2e-7732-47dc-1d019cf64825@redhat.com> (raw)
In-Reply-To: <CAJFAV8wgUZGEwg_uEjMv9CXA3++_JOxe-apzKgvNewo47Ft0ZQ@mail.gmail.com>



On 3/15/21 5:57 PM, David Marchand wrote:
> On Mon, Mar 15, 2021 at 5:46 PM Maxime Coquelin
> <maxime.coquelin@redhat.com> wrote:
>> @@ -612,6 +622,8 @@ virtio_init_queue(struct rte_eth_dev *dev, uint16_t queue_idx)
>>
>>  clean_vq:
>>         hw->cvq = NULL;
>> +       rte_free(fake_mbuf);
>> +free_sw_ring:
>>         rte_free(sw_ring);
>>  free_hdr_mz:
>>         rte_memzone_free(hdr_mz);
>> @@ -641,6 +653,7 @@ virtio_free_queues(struct virtio_hw *hw)
>>
>>                 queue_type = virtio_get_queue_type(hw, i);
>>                 if (queue_type == VTNET_RQ) {
>> +                       free(vq->rxq.fake_mbuf);

Oups, will fix while applying.

Thanks,
Maxime

> 
> rte_free()
> 
> 


  reply	other threads:[~2021-03-15 17:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-15 16:46 [dpdk-dev] [PATCH v3 0/4] net/virtio: make virtqueue struct cache-friendly Maxime Coquelin
2021-03-15 16:46 ` [dpdk-dev] [PATCH v3 1/4] net/virtio: remove reference to virtqueue in vrings Maxime Coquelin
2021-03-15 16:46 ` [dpdk-dev] [PATCH v3 2/4] net/virtio: improve queue init error path Maxime Coquelin
2021-03-15 16:46 ` [dpdk-dev] [PATCH v3 3/4] net/virtio: allocate fake mbuf in Rx queue Maxime Coquelin
2021-03-15 16:57   ` David Marchand
2021-03-15 17:02     ` Maxime Coquelin [this message]
2021-03-15 16:46 ` [dpdk-dev] [PATCH v3 4/4] net/virtio: pack virtqueue struct Maxime Coquelin
2021-03-15 16:59 ` [dpdk-dev] [PATCH v3 0/4] net/virtio: make virtqueue struct cache-friendly David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44e52bf5-9e2e-7732-47dc-1d019cf64825@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=amorenoz@redhat.com \
    --cc=bnemeth@redhat.com \
    --cc=chenbo.xia@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=olivier.matz@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).