From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v7 02/28] librte_ether: add fields from rte_pci_driver to rte_eth_dev_data
Date: Mon, 02 Nov 2015 18:42:56 +0100 [thread overview]
Message-ID: <4517512.rHI39xAYOX@xps13> (raw)
In-Reply-To: <8CEF83825BEC744B83065625E567D7C219F7716B@IRSMSX108.ger.corp.intel.com>
2015-11-02 16:44, Iremonger, Bernard:
> Hi Thomas,
>
> <snip>
>
> > Subject: Re: [dpdk-dev] [PATCH v7 02/28] librte_ether: add fields from
> > rte_pci_driver to rte_eth_dev_data
> >
> > 2015-11-02 10:36, Iremonger, Bernard:
> > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > > > 2015-10-30 15:08, Bernard Iremonger:
> > > > > add dev_flags to rte_eth_dev_data, add macros for dev_flags.
> > > > > add kdrv to rte_eth_dev_data.
> > > > > add numa_node to rte_eth_dev_data.
> > > > > add drv_name to rte_eth_dev_data.
> > > >
> > > > A commit message should explain why things are done.
> > > >
> > > > > + uint32_t dev_flags; /**< Flags controlling handling of device.
> > > > > +*/
> > > >
> > > > Where are defined this flags? What is the scope?
> > >
> > > These flags are defined in the following file:
> > >
> > > lib/librte_ether/rte_ethdev.h
> > >
> > > These flags are visible to all the vdevs and pdevs.
> >
> > I mean it should be more explicit. Having an enum name will help.
> > Note: I understand your patch. I'm just asking the questions an user will ask
> > when trying to use your new API.
> > Thanks
>
> I will try to be clearer in the commit message.
> I tried an enum for the dev_flags but it does not work well.
> There can be multiple flags set in dev_flags, it is intended to be a bit field similar to the pci flags.
Yes. You can assign some bits in an enum.
But if you prefer the defines, it's also OK if they are clearly identifiable:
with a prefix and good comments allowing to map the structure field and the flags.
> I have squashed down to 19 patches now, I don't want to over squash.
The proposal of 5 patches was good.
next prev parent reply other threads:[~2015-11-02 17:44 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <PATCH v7>
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 00/28] remove pci driver from vdevs Bernard Iremonger
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 01/28] librte_eal: add RTE_KDRV_NONE for vdevs Bernard Iremonger
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 02/28] librte_ether: add fields from rte_pci_driver to rte_eth_dev_data Bernard Iremonger
2015-11-01 21:12 ` Thomas Monjalon
2015-11-02 10:36 ` Iremonger, Bernard
2015-11-02 16:32 ` Thomas Monjalon
2015-11-02 16:44 ` Iremonger, Bernard
2015-11-02 17:42 ` Thomas Monjalon [this message]
2015-11-01 21:41 ` Thomas Monjalon
2015-11-02 10:33 ` Iremonger, Bernard
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 03/28] librte_ether: add function rte_eth_copy_dev_info Bernard Iremonger
2015-11-01 21:30 ` Thomas Monjalon
2015-11-02 10:24 ` Iremonger, Bernard
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 04/28] ixgbe: copy pci device info to eth_dev data Bernard Iremonger
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 05/28] e1000: " Bernard Iremonger
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 06/28] i40e: " Bernard Iremonger
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 07/28] fm10k: " Bernard Iremonger
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 08/28] bnx2x: " Bernard Iremonger
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 09/28] cxgbe: " Bernard Iremonger
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 10/28] enic: " Bernard Iremonger
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 11/28] mlx4: " Bernard Iremonger
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 12/28] virtio: " Bernard Iremonger
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 13/28] vmxnet3: " Bernard Iremonger
2015-10-31 8:39 ` Yong Wang
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 14/28] null: copy " Bernard Iremonger
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 15/28] ring: " Bernard Iremonger
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 16/28] pcap: " Bernard Iremonger
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 17/28] af_packet: " Bernard Iremonger
2015-10-30 15:17 ` John W. Linville
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 18/28] xenvirt: " Bernard Iremonger
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 19/28] mpipe: " Bernard Iremonger
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 20/28] bonding: " Bernard Iremonger
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 21/28] librte_ether: remove branches on pci_dev Bernard Iremonger
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 22/28] null: remove pci device Bernard Iremonger
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 23/28] ring: " Bernard Iremonger
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 24/28] pcap: " Bernard Iremonger
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 25/28] af_packet: " Bernard Iremonger
2015-10-30 15:19 ` John W. Linville
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 26/28] xenvirt: " Bernard Iremonger
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 27/28] mpipe: " Bernard Iremonger
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 28/28] bonding: " Bernard Iremonger
2015-11-01 21:35 ` Thomas Monjalon
2015-11-02 10:27 ` Iremonger, Bernard
2015-10-30 15:21 ` [dpdk-dev] [PATCH v7 00/28] remove pci driver from vdevs Thomas Monjalon
2015-10-30 15:28 ` Iremonger, Bernard
2015-11-02 5:28 ` Qiu, Michael
2015-11-02 7:35 ` Thomas Monjalon
2015-11-02 10:13 ` Iremonger, Bernard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4517512.rHI39xAYOX@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).