From: Thomas Monjalon <thomas@monjalon.net>
To: Harman Kalra <hkalra@marvell.com>
Cc: stable@dpdk.org, jerinj@marvell.com
Subject: Re: [dpdk-stable] [PATCH v2 1/2] metrics: new API to deinitialise metrics library
Date: Fri, 05 Apr 2019 15:14:09 +0200 [thread overview]
Message-ID: <4534168.qckUeH1snz@xps> (raw)
In-Reply-To: <1551434386-31464-1-git-send-email-hkalra@marvell.com>
01/03/2019 11:00, Harman Kalra:
> Once the library usage is over, it must be deinitialized which
> will free the shared memory reserved during initialization.
>
> Fixes: observed an issue while running 'metrics_autotest'
> continuously without quiting. For the first run 'metrics_autotest'
> passes all test cases but second run onwards first test case
> fails because metrics library is already initialized during
> first run.
> Cc: stable@dpdk.org
>
> Signed-off-by: Harman Kalra <hkalra@marvell.com>
I was waiting for an ack on this patch,
and realized that there was one already on v1.
When sending v2, you should have reported the Ack.
And to ease review between versions, please keep all the versions
in the same thread with --in-reply-to.
Would be nice if old contributors from Marvell would guide you.
Thanks
> ---
> v2:
> * Adding stable@dpdk.org into cc as this patch falls between bug fix
> and new feature.
I would vote for not backporting this new API.
Any other opinion?
next prev parent reply other threads:[~2019-04-05 13:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 10:00 Harman Kalra
2019-03-01 10:00 ` [dpdk-stable] [PATCH v2 2/2] test/metrics: first test case fails on continuous execution Harman Kalra
2019-04-05 13:14 ` Thomas Monjalon [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-02-27 10:51 [dpdk-stable] [PATCH 1/2] metrics: new API to deinitialise metrics library Harman Kalra
2019-03-01 10:07 ` [dpdk-stable] [PATCH v2 " Harman Kalra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4534168.qckUeH1snz@xps \
--to=thomas@monjalon.net \
--cc=hkalra@marvell.com \
--cc=jerinj@marvell.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).