DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Mokhtar, Amr" <amr.mokhtar@intel.com>
Cc: "Chalupnik, KamilX" <kamilx.chalupnik@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] doc: update bbdev library documentation
Date: Mon, 23 Apr 2018 13:12:10 +0200	[thread overview]
Message-ID: <4551437.8ZCrZuEaxO@xps> (raw)
In-Reply-To: <3D3765A8CDB52A4C8B410430AA19CB236ECAFFC8@IRSMSX101.ger.corp.intel.com>

23/04/2018 12:56, Mokhtar, Amr:
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > 04/04/2018 16:05, KamilX Chalupnik:
> > > From: "Chalupnik, KamilX" <kamilx.chalupnik@intel.com>
> > 
> > >  doc/guides/prog_guide/bbdev.rst               | 247
> > +++++++++++++++++++++++---
> > >  doc/guides/prog_guide/img/turbo_tb_decode.png | Bin 0 -> 43552
> > bytes
> > >  doc/guides/prog_guide/img/turbo_tb_encode.png | Bin 0 -> 46944
> > bytes
> > >  3 files changed, 222 insertions(+), 25 deletions(-)
> > >  create mode 100644 doc/guides/prog_guide/img/turbo_tb_decode.png
> > >  create mode 100644 doc/guides/prog_guide/img/turbo_tb_encode.png
> > 
> > No, sorry, you cannot add binary file in this repository.
> > It is an Open Source project, we provide sources.
> > For figures, the SVG format is preferred.
> > 
> > I'm sorry that your Intel colleagues did not warn you.
> > 
> 
> I wasn't aware there is specific preference for figures, this can be fixed.
> There is no specific reason for choosing .png except that there are files already
> in prog_guide/img/* of type .png. So it was assumed that its ok.
> And BTW, did I miss it somewhere in DPDK documentation what particular image
> types should be submitted.

Yes, it is in this doc:
	http://dpdk.org/doc/guides/contributing/documentation.html#images

> Will get this fixed. Thanks.

Thanks

  reply	other threads:[~2018-04-23 11:12 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-04 14:05 KamilX Chalupnik
2018-04-04 14:05 ` [dpdk-dev] [PATCH] baseband/turbo_sw: offload cost measurement test KamilX Chalupnik
2018-04-13 23:18   ` Mokhtar, Amr
2018-04-13 23:37   ` Mokhtar, Amr
2018-04-17 14:27   ` [dpdk-dev] [PATCH v2] " KamilX Chalupnik
2018-04-17 16:50     ` Mokhtar, Amr
2018-04-24 17:44     ` De Lara Guarch, Pablo
2018-04-24 19:09       ` Mokhtar, Amr
2018-04-25  7:45         ` De Lara Guarch, Pablo
2018-04-04 14:05 ` [dpdk-dev] [PATCH] baseband/turbo_sw: optimization of turbo software driver KamilX Chalupnik
2018-04-13 19:56   ` Mokhtar, Amr
2018-04-17 14:34   ` [dpdk-dev] [PATCH v2] " KamilX Chalupnik
2018-04-17 16:55     ` Mokhtar, Amr
2018-04-24 17:53     ` De Lara Guarch, Pablo
     [not found]       ` <EEA9FF629BF25B47BD67ADE995041EE23CF5C650@IRSMSX103.ger.corp.intel.com>
2018-04-25 10:00         ` De Lara Guarch, Pablo
2018-04-04 14:05 ` [dpdk-dev] [PATCH] baseband/turbo_sw: splitting Queue Groups KamilX Chalupnik
2018-04-13 23:19   ` Mokhtar, Amr
2018-04-17 14:39   ` [dpdk-dev] [PATCH v2] " KamilX Chalupnik
2018-04-17 16:55     ` Mokhtar, Amr
2018-04-24 15:30     ` De Lara Guarch, Pablo
2018-04-24 17:20       ` De Lara Guarch, Pablo
2018-04-04 14:05 ` [dpdk-dev] [PATCH] baseband/turbo_sw: update Turbo Software driver KamilX Chalupnik
2018-04-13 19:58   ` Mokhtar, Amr
2018-04-17 14:43   ` [dpdk-dev] [PATCH v2] " KamilX Chalupnik
2018-04-17 16:56     ` Mokhtar, Amr
2018-04-19 14:31       ` De Lara Guarch, Pablo
2018-04-24 17:55     ` De Lara Guarch, Pablo
2018-04-24 18:53       ` Mokhtar, Amr
2018-04-25  7:37         ` De Lara Guarch, Pablo
2018-04-04 14:06 ` [dpdk-dev] [PATCH] app/bbdev: remove improper WARNING printouts KamilX Chalupnik
2018-04-13 23:20   ` Mokhtar, Amr
2018-04-18  9:26   ` [dpdk-dev] [PATCH v2] " KamilX Chalupnik
2018-04-18 14:16     ` Mokhtar, Amr
2018-04-24 14:10     ` De Lara Guarch, Pablo
2018-04-04 14:06 ` [dpdk-dev] [PATCH] app/bbdev: update test vectors KamilX Chalupnik
2018-04-13 23:22   ` Mokhtar, Amr
2018-04-24 14:56   ` De Lara Guarch, Pablo
2018-04-24 15:41     ` Mokhtar, Amr
2018-04-04 14:06 ` [dpdk-dev] [PATCH] app/bbdev: dynamic lib support KamilX Chalupnik
2018-04-17 17:01   ` Mokhtar, Amr
2018-04-24 14:18   ` De Lara Guarch, Pablo
     [not found]     ` <EEA9FF629BF25B47BD67ADE995041EE23CF5B5C4@IRSMSX103.ger.corp.intel.com>
2018-04-25 16:10       ` De Lara Guarch, Pablo
     [not found]         ` <EEA9FF629BF25B47BD67ADE995041EE23CF5DBFE@IRSMSX103.ger.corp.intel.com>
2018-04-26  9:47           ` De Lara Guarch, Pablo
2018-04-26 11:28           ` De Lara Guarch, Pablo
     [not found]             ` <EEA9FF629BF25B47BD67ADE995041EE23CF5DD78@IRSMSX103.ger.corp.intel.com>
2018-04-26 13:22               ` De Lara Guarch, Pablo
     [not found]                 ` <EEA9FF629BF25B47BD67ADE995041EE23CF5DE21@IRSMSX103.ger.corp.intel.com>
2018-04-26 14:29                   ` De Lara Guarch, Pablo
2018-04-13 19:30 ` [dpdk-dev] [PATCH] doc: update bbdev library documentation Mokhtar, Amr
2018-04-19 14:29   ` De Lara Guarch, Pablo
2018-04-22 20:17 ` Thomas Monjalon
2018-04-23 10:24   ` De Lara Guarch, Pablo
2018-04-23 10:56   ` Mokhtar, Amr
2018-04-23 11:12     ` Thomas Monjalon [this message]
2018-04-23 12:15       ` Mokhtar, Amr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4551437.8ZCrZuEaxO@xps \
    --to=thomas@monjalon.net \
    --cc=amr.mokhtar@intel.com \
    --cc=dev@dpdk.org \
    --cc=kamilx.chalupnik@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).