From: Thomas Monjalon <thomas@monjalon.net>
To: Nagadheeraj Rottela <rnagadheeraj@marvell.com>,
Akhil Goyal <akhil.goyal@nxp.com>
Cc: dev@dpdk.org, "jsrikanth@marvell.com" <jsrikanth@marvell.com>
Subject: Re: [dpdk-dev] [PATCH] crypto/nitrox: fix coverity defects
Date: Thu, 20 Feb 2020 12:51:22 +0100 [thread overview]
Message-ID: <4553285.yaVYbkx8dN@xps> (raw)
In-Reply-To: <VE1PR04MB66394AC008E0F17DB28A8FB1E6130@VE1PR04MB6639.eurprd04.prod.outlook.com>
20/02/2020 12:07, Akhil Goyal:
> >
> > Address the defects reported by coverity: Unintended sign extension
> > and Out-of-bounds access.
> >
> > Coverity issue: 349899, 349905, 349911, 349921, 349923, 349926
> >
> > Fixes: 32e4930d5a3b ("crypto/nitrox: add hardware queue management")
> > Fixes: 9fdef0cc2385 ("crypto/nitrox: create symmetric cryptodev")
> >
> > Signed-off-by: Nagadheeraj Rottela <rnagadheeraj@marvell.com>
> > ---
> Thomas,
>
> Can you take this directly on master.
No sorry, I can't because there is no review and test.
And I think we should not have general patches for Coverity defects.
Instead we must do one patch per issue. Here two:
- sign of constants
- out-of-bound access
In each patch, we must have a description of the consequence of the issue.
Thanks
next prev parent reply other threads:[~2020-02-20 11:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 11:04 Nagadheeraj Rottela
2020-02-20 11:07 ` Akhil Goyal
2020-02-20 11:51 ` Thomas Monjalon [this message]
2020-02-25 9:46 ` [dpdk-dev] [PATCH v2 1/2] crypto/nitrox: fix invalid CSR register address generation Nagadheeraj Rottela
2020-02-25 9:46 ` [dpdk-dev] [PATCH v2 2/2] crypto/nitrox: fix array out of bounds access Nagadheeraj Rottela
2020-03-25 9:10 ` [dpdk-dev] [PATCH v2 1/2] crypto/nitrox: fix invalid CSR register address generation Akhil Goyal
2020-03-27 13:42 ` [dpdk-dev] [PATCH v3 " Nagadheeraj Rottela
2020-03-27 13:42 ` [dpdk-dev] [PATCH v3 2/2] crypto/nitrox: fix array out of bounds access Nagadheeraj Rottela
2020-04-05 16:55 ` Akhil Goyal
2020-04-05 16:54 ` [dpdk-dev] [PATCH v3 1/2] crypto/nitrox: fix invalid CSR register address generation Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4553285.yaVYbkx8dN@xps \
--to=thomas@monjalon.net \
--cc=akhil.goyal@nxp.com \
--cc=dev@dpdk.org \
--cc=jsrikanth@marvell.com \
--cc=rnagadheeraj@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).