From: Ferruh Yigit <ferruh.yigit@xilinx.com>
To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>, <dev@dpdk.org>
Cc: Adrien Mazarguil <adrien.mazarguil@6wind.com>,
Harry van Haaren <harry.van.haaren@intel.com>,
Thomas Monjalon <thomas@monjalon.net>,
John McNamara <john.mcnamara@intel.com>,
David Marchand <david.marchand@redhat.com>
Subject: Re: [PATCH 1/1] doc: add author name on cc to git fixline alias
Date: Mon, 13 Jun 2022 08:47:22 +0100 [thread overview]
Message-ID: <45f33ca8-40f0-1866-5f06-2e9dcaa424c8@xilinx.com> (raw)
In-Reply-To: <20220612114007.23012-1-heinrich.schuchardt@canonical.com>
On 6/12/2022 12:40 PM, Heinrich Schuchardt wrote:
> We should add both the author name and the author email address to
> the Cc: line of a blamed patch.
>
> Fixes: f9ef083c6cfe ("doc: add author on cc to git fixline alias")
> Cc: Harry van Haaren <harry.van.haaren@intel.com>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
> doc/guides/contributing/patches.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/doc/guides/contributing/patches.rst b/doc/guides/contributing/patches.rst
> index bebcaf3925..aad2429e58 100644
> --- a/doc/guides/contributing/patches.rst
> +++ b/doc/guides/contributing/patches.rst
> @@ -260,7 +260,7 @@ Here are some guidelines for the body of a commit message:
> You can generate the required lines using the following git alias, which prints
> the commit SHA and the author of the original code::
>
> - git config alias.fixline "log -1 --abbrev=12 --format='Fixes: %h (\"%s\")%nCc: %ae'"
> + git config alias.fixline "log -1 --abbrev=12 --format='Fixes: %h (\"%s\")%nCc: %an <%ae>'"
>
Hi Heinrich,
We don't keep the 'Cc: ' lines in commit lines when pushing to repo,
it is mainly added to be sure author of the original change is cc'ed
since 'git send-email' picks emails from commit log.
So although it doesn't hurt, it is also not needed to have full name &
email since it will be stripped explicitly.
Thanks,
ferruh
prev parent reply other threads:[~2022-06-13 7:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-12 11:40 Heinrich Schuchardt
2022-06-13 7:47 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45f33ca8-40f0-1866-5f06-2e9dcaa424c8@xilinx.com \
--to=ferruh.yigit@xilinx.com \
--cc=adrien.mazarguil@6wind.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=heinrich.schuchardt@canonical.com \
--cc=john.mcnamara@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).