From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Kumara Parameshwaran <kumaraparamesh92@gmail.com>,
hujiayu.hu@foxmail.com
Cc: dev@dpdk.org
Subject: Re: [PATCH v5] gro : packets not getting flushed in heavy-weight mode API
Date: Wed, 7 Feb 2024 22:57:10 +0000 [thread overview]
Message-ID: <460c72b5-0b6f-440f-99bd-251f5ce3713e@amd.com> (raw)
In-Reply-To: <20240118083626.432048-1-kumaraparamesh92@gmail.com>
On 1/18/2024 8:36 AM, Kumara Parameshwaran wrote:
> In heavy-weight mode GRO which is based on timer, the GRO packets
> will not be flushed in spite of timer expiry if there is no packet
> in the current poll. If timer mode GRO is enabled the
> rte_gro_timeout_flush API should be invoked.
>
Agree on the problem, need a way to flush existing packets in GRO
context when no more packet receiving.
> Signed-off-by: Kumara Parameshwaran <kumaraparamesh92@gmail.com>
> ---
> v1:
> Changes to make sure that the GRO flush API is invoked if there are no packets in
> current poll and timer expiry.
>
> v2:
> Fix code organisation issue
>
> v3:
> Fix warnings
>
> v4:
> Fix error and warnings
>
> v5:
> Fix compilation issue when GRO is not defined
>
> app/test-pmd/csumonly.c | 15 +++++++++++----
> 1 file changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c
> index c103e54111..6d9ce99500 100644
> --- a/app/test-pmd/csumonly.c
> +++ b/app/test-pmd/csumonly.c
> @@ -863,16 +863,23 @@ pkt_burst_checksum_forward(struct fwd_stream *fs)
>
> /* receive a burst of packet */
> nb_rx = common_fwd_stream_receive(fs, pkts_burst, nb_pkt_per_burst);
> +#ifndef RTE_LIB_GRO
> if (unlikely(nb_rx == 0))
> return false;
> -
> +#else
> + gro_enable = gro_ports[fs->rx_port].enable;
> + if (unlikely(nb_rx == 0)) {
> + if (gro_enable && (gro_flush_cycles != GRO_DEFAULT_FLUSH_CYCLES))
> + goto init;
>
Rest of the function expects 'nb_rx' non zero, so I am concerned about
unexpected side effects, like:
- GRO reassembles packets and flush, how reassembles behaves with zero
nb_rx?
- If there is no packet in GRO context, what happens to call with zero
nb_rx?
To address above issue, what about add 'rte_gro_get_pkt_count()' check
and only continue if it return not zero.
Also in below GRO block, call 'rte_gro_reassemble()' only when 'nb_rx'
is not zero.
> + else
> + return false;
>
'goto' can be prevented by changing the condition in if block.
> + }
> +init:
>
Label name 'init' is not a good name.
> +#endif
> rx_bad_ip_csum = 0;
> rx_bad_l4_csum = 0;
> rx_bad_outer_l4_csum = 0;
> rx_bad_outer_ip_csum = 0;
> -#ifdef RTE_LIB_GRO
> - gro_enable = gro_ports[fs->rx_port].enable;
> -#endif
>
> txp = &ports[fs->tx_port];
> tx_offloads = txp->dev_conf.txmode.offloads;
next prev parent reply other threads:[~2024-02-07 22:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-17 19:52 [PATCH v1] " Kumara Parameshwaran
2024-01-17 19:57 ` kumaraparameshwaran rathinavel
2024-01-17 20:14 ` [PATCH v2] " Kumara Parameshwaran
2024-01-17 20:20 ` [PATCH v3] " Kumara Parameshwaran
2024-01-17 20:24 ` [PATCH v4] " Kumara Parameshwaran
2024-01-18 8:36 ` [PATCH v5] " Kumara Parameshwaran
2024-02-07 22:57 ` Ferruh Yigit [this message]
2024-02-11 4:55 ` [PATCH v6] " Kumara Parameshwaran
2024-02-12 15:05 ` Ferruh Yigit
2024-02-16 3:40 ` [PATCH v7] app/testpmd : fix " Kumara Parameshwaran
2024-02-16 4:13 ` Stephen Hemminger
2024-02-16 3:47 ` [PATCH v8] " Kumara Parameshwaran
2024-02-16 13:56 ` Ferruh Yigit
2024-02-21 18:02 ` Ferruh Yigit
2024-02-22 11:15 ` kumaraparameshwaran rathinavel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=460c72b5-0b6f-440f-99bd-251f5ce3713e@amd.com \
--to=ferruh.yigit@amd.com \
--cc=dev@dpdk.org \
--cc=hujiayu.hu@foxmail.com \
--cc=kumaraparamesh92@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).