From: "lihuisong (C)" <lihuisong@huawei.com>
To: Ferruh Yigit <ferruh.yigit@amd.com>, <dev@dpdk.org>,
<andrew.rybchenko@oktetlabs.ru>
Cc: <thomas@monjalon.net>, <liudongdong3@huawei.com>,
<huangdaode@huawei.com>, <fengchengwen@huawei.com>
Subject: Re: [PATCH V4 1/5] drivers/bus: restore driver assignment at front of probing
Date: Thu, 12 Jan 2023 10:44:06 +0800 [thread overview]
Message-ID: <461a4536-fbbd-3848-af8d-2aa1ebaf8ccb@huawei.com> (raw)
In-Reply-To: <79192ffa-eb80-e56c-5c64-4a22374c7a1a@amd.com>
在 2023/1/11 20:51, Ferruh Yigit 写道:
> On 12/6/2022 9:26 AM, Huisong Li wrote:
>> The driver assignment was moved back at the end of the device probing
>> because there is no something to use rte_driver during the phase of
>> probing. See commit 391797f04208 ("drivers/bus: move driver assignment
>> to end of probing")
>>
>> However, it is necessary for probing callback to reference rte_driver
>> before probing. For example, probing callback may call some APIs which
>> access the rte_pci_driver::driver by the device::driver pointer to get
>> driver information. In this case, a segment fault will occur in probing
>> callback if there is not this assignment.
>>
> Probing callback gets driver as parameter, so callback function can
> access it via 'drv->driver', is there a specific usecase that
> 'dev->device->driver' needs to be accessed explicitly?
>
> I assume this is related to coming patches that setting up device in
> testpmd event callback, but can you please clarify exact need.
For example, rte_eth_dev_info_get is called in this event callback to get
driver name.
>
>> Further, some comments in code need to be updated if we do that. The
>> driver pointer in rte_device is set before probing and needs to be reset
>> if probing failed. And rte_dev_is_probed can not be called inside probing.
>>
>> Fixes: 391797f04208 ("drivers/bus: move driver assignment to end of probing")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Huisong Li <lihuisong@huawei.com>
>> ---
>> drivers/bus/auxiliary/auxiliary_common.c | 9 +++++++--
>> drivers/bus/dpaa/dpaa_bus.c | 9 +++++++--
>> drivers/bus/fslmc/fslmc_bus.c | 8 +++++++-
>> drivers/bus/ifpga/ifpga_bus.c | 12 +++++++++---
>> drivers/bus/pci/pci_common.c | 9 +++++++--
>> drivers/bus/vdev/vdev.c | 10 ++++++++--
>> drivers/bus/vmbus/vmbus_common.c | 9 +++++++--
>> 7 files changed, 52 insertions(+), 14 deletions(-)
>>
>> diff --git a/drivers/bus/auxiliary/auxiliary_common.c b/drivers/bus/auxiliary/auxiliary_common.c
>> index ff1369353a..13cb3fe0f8 100644
>> --- a/drivers/bus/auxiliary/auxiliary_common.c
>> +++ b/drivers/bus/auxiliary/auxiliary_common.c
>> @@ -132,16 +132,21 @@ rte_auxiliary_probe_one_driver(struct rte_auxiliary_driver *drv,
>> }
>>
>> dev->driver = drv;
>> + /*
>> + * Reference rte_driver before probing so as to this pointer can
>> + * be used to get driver information in case of segment fault in
>> + * probing callback.
>> + */
>> + dev->device.driver = &drv->driver;
>>
>> AUXILIARY_LOG(INFO, "Probe auxiliary driver: %s device: %s (NUMA node %i)",
>> drv->driver.name, dev->name, dev->device.numa_node);
>> ret = drv->probe(drv, dev);
>> if (ret != 0) {
>> dev->driver = NULL;
>> + dev->device.driver = NULL;
>> rte_intr_instance_free(dev->intr_handle);
>> dev->intr_handle = NULL;
>> - } else {
>> - dev->device.driver = &drv->driver;
>> }
>>
>> return ret;
>> diff --git a/drivers/bus/dpaa/dpaa_bus.c b/drivers/bus/dpaa/dpaa_bus.c
>> index e57159f5d8..f1b817e58c 100644
>> --- a/drivers/bus/dpaa/dpaa_bus.c
>> +++ b/drivers/bus/dpaa/dpaa_bus.c
>> @@ -693,17 +693,22 @@ rte_dpaa_bus_probe(void)
>> (dev->device.devargs &&
>> dev->device.devargs->policy == RTE_DEV_BLOCKED))
>> continue;
>> -
>> + /*
>> + * Reference rte_driver before probing so as to this
>> + * pointer can be used to get driver information in case
>> + * of segment fault in probing callback.
>> + */
>> + dev->device.driver = &drv->driver;
>> if (probe_all ||
>> (dev->device.devargs &&
>> dev->device.devargs->policy == RTE_DEV_ALLOWED)) {
>> ret = drv->probe(drv, dev);
>> if (ret) {
>> + dev->device.driver = NULL;
>> DPAA_BUS_ERR("unable to probe:%s",
>> dev->name);
>> } else {
>> dev->driver = drv;
>> - dev->device.driver = &drv->driver;
>> }
>> }
>> break;
>> diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.c
>> index 57bfb5111a..4bc0c6d3d4 100644
>> --- a/drivers/bus/fslmc/fslmc_bus.c
>> +++ b/drivers/bus/fslmc/fslmc_bus.c
>> @@ -471,15 +471,21 @@ rte_fslmc_probe(void)
>> continue;
>> }
>>
>> + /*
>> + * Reference rte_driver before probing so as to this
>> + * pointer can be used to get driver information in case
>> + * of segment fault in probing callback.
>> + */
>> + dev->device.driver = &drv->driver;
>> if (probe_all ||
>> (dev->device.devargs &&
>> dev->device.devargs->policy == RTE_DEV_ALLOWED)) {
>> ret = drv->probe(drv, dev);
>> if (ret) {
>> + dev->device.driver = NULL;
>> DPAA2_BUS_ERR("Unable to probe");
>> } else {
>> dev->driver = drv;
>> - dev->device.driver = &drv->driver;
>> }
>> }
>> break;
>> diff --git a/drivers/bus/ifpga/ifpga_bus.c b/drivers/bus/ifpga/ifpga_bus.c
>> index bb943b58b5..5f23446f41 100644
>> --- a/drivers/bus/ifpga/ifpga_bus.c
>> +++ b/drivers/bus/ifpga/ifpga_bus.c
>> @@ -293,13 +293,19 @@ ifpga_probe_one_driver(struct rte_afu_driver *drv,
>>
>> /* reference driver structure */
>> afu_dev->driver = drv;
>> + /*
>> + * Reference rte_driver before probing so as to this pointer can
>> + * be used to get driver information in case of segment fault in
>> + * probing callback.
>> + */
>> + afu_dev->device.driver = &drv->driver;
>>
>> /* call the driver probe() function */
>> ret = drv->probe(afu_dev);
>> - if (ret)
>> + if (ret) {
>> afu_dev->driver = NULL;
>> - else
>> - afu_dev->device.driver = &drv->driver;
>> + afu_dev->device.driver = NULL;
>> + }
>>
>> return ret;
>> }
>> diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c
>> index bc3a7f39fe..efaa1792e9 100644
>> --- a/drivers/bus/pci/pci_common.c
>> +++ b/drivers/bus/pci/pci_common.c
>> @@ -302,6 +302,12 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr,
>> return ret;
>> }
>> }
>> + /*
>> + * Reference rte_driver before probing so as to this pointer can
>> + * be used to get driver information in case of segment fault in
>> + * probing callback.
>> + */
>> + dev->device.driver = &dr->driver;
>> }
>>
>> RTE_LOG(INFO, EAL, "Probe PCI driver: %s (%x:%x) device: "PCI_PRI_FMT" (socket %i)\n",
>> @@ -314,6 +320,7 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr,
>> return ret; /* no rollback if already succeeded earlier */
>> if (ret) {
>> dev->driver = NULL;
>> + dev->device.driver = NULL;
>> if ((dr->drv_flags & RTE_PCI_DRV_NEED_MAPPING) &&
>> /* Don't unmap if device is unsupported and
>> * driver needs mapped resources.
>> @@ -325,8 +332,6 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr,
>> dev->vfio_req_intr_handle = NULL;
>> rte_intr_instance_free(dev->intr_handle);
>> dev->intr_handle = NULL;
>> - } else {
>> - dev->device.driver = &dr->driver;
>> }
>>
>> return ret;
>> diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c
>> index 41bc07dde7..2e3f0f2e12 100644
>> --- a/drivers/bus/vdev/vdev.c
>> +++ b/drivers/bus/vdev/vdev.c
>> @@ -207,9 +207,15 @@ vdev_probe_all_drivers(struct rte_vdev_device *dev)
>> return -1;
>> }
>>
>> + /*
>> + * Reference rte_driver before probing so as to this pointer can
>> + * be used to get driver information in case of segment fault in
>> + * probing callback.
>> + */
>> + dev->device.driver = &driver->driver;
>> ret = driver->probe(dev);
>> - if (ret == 0)
>> - dev->device.driver = &driver->driver;
>> + if (ret != 0)
>> + dev->device.driver = NULL;
>> return ret;
>> }
>>
>> diff --git a/drivers/bus/vmbus/vmbus_common.c b/drivers/bus/vmbus/vmbus_common.c
>> index 8d32d66504..feb1651984 100644
>> --- a/drivers/bus/vmbus/vmbus_common.c
>> +++ b/drivers/bus/vmbus/vmbus_common.c
>> @@ -110,6 +110,12 @@ vmbus_probe_one_driver(struct rte_vmbus_driver *dr,
>>
>> /* reference driver structure */
>> dev->driver = dr;
>> + /*
>> + * Reference rte_driver before probing so as to this pointer can
>> + * be used to get driver information in case of segment fault in
>> + * probing callback.
>> + */
>> + dev->device.driver = &dr->driver;
>>
>> if (dev->device.numa_node < 0 && rte_socket_count() > 1)
>> VMBUS_LOG(INFO, "Device %s is not NUMA-aware", guid);
>> @@ -119,9 +125,8 @@ vmbus_probe_one_driver(struct rte_vmbus_driver *dr,
>> ret = dr->probe(dr, dev);
>> if (ret) {
>> dev->driver = NULL;
>> + dev->device.driver = NULL;
>> rte_vmbus_unmap_device(dev);
>> - } else {
>> - dev->device.driver = &dr->driver;
>> }
>>
>> return ret;
> .
next prev parent reply other threads:[~2023-01-12 2:44 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220825024425.10534-1-lihuisong@huawei.com>
2022-09-15 12:45 ` [PATCH V2 0/6] [PATCH 0/6] app/testpmd: support attach and detach port for MP Huisong Li
2022-09-15 12:45 ` [PATCH V2 1/6] bus/pci: fix a segfault when call callback Huisong Li
2022-10-10 19:49 ` Thomas Monjalon
2022-10-25 3:25 ` lihuisong (C)
2022-09-15 12:45 ` [PATCH V2 2/6] bus/vdev: " Huisong Li
2022-09-15 12:45 ` [PATCH V2 3/6] ethdev: fix push new event Huisong Li
2022-09-27 10:49 ` Thomas Monjalon
2022-10-08 4:09 ` lihuisong (C)
2022-10-25 3:26 ` lihuisong (C)
2022-09-15 12:45 ` [PATCH V2 4/6] app/testpmd: check the validity of the port Huisong Li
2022-09-22 5:07 ` Singh, Aman Deep
2022-09-15 12:45 ` [PATCH V2 5/6] app/testpmd: support attach and detach port for MP Huisong Li
2022-09-15 12:45 ` [PATCH V2 6/6] app/testpmd: stop packet forwarding in new and destroy event Huisong Li
2022-12-06 6:45 ` [PATCH V3 0/5] app/testpmd: support mulitple process attach and detach port Huisong Li
2022-12-06 6:45 ` [PATCH V3 1/5] drivers/bus: restore driver assignment at front of probing Huisong Li
2022-12-06 6:45 ` [PATCH V3 2/5] ethdev: fix skip valid port in probing callback Huisong Li
2022-12-06 6:45 ` [PATCH V3 3/5] app/testpmd: check the validity of the port Huisong Li
2022-12-06 6:45 ` [PATCH V3 4/5] app/testpmd: add attach and detach port for multiple process Huisong Li
2022-12-06 6:45 ` [PATCH V3 5/5] app/testpmd: stop forwarding in new or destroy event Huisong Li
2022-12-06 9:26 ` [PATCH V4 0/5] app/testpmd: support mulitple process attach and detach port Huisong Li
2022-12-06 9:26 ` [PATCH V4 1/5] drivers/bus: restore driver assignment at front of probing Huisong Li
2023-01-11 12:51 ` Ferruh Yigit
2023-01-12 2:44 ` lihuisong (C) [this message]
2023-02-15 16:09 ` Ferruh Yigit
2023-02-28 2:21 ` lihuisong (C)
2023-06-06 16:12 ` Ferruh Yigit
2023-06-07 10:11 ` lihuisong (C)
2023-06-15 2:21 ` lihuisong (C)
2022-12-06 9:26 ` [PATCH V4 2/5] ethdev: fix skip valid port in probing callback Huisong Li
2023-01-11 12:51 ` Ferruh Yigit
2023-01-12 4:12 ` lihuisong (C)
2022-12-06 9:26 ` [PATCH V4 3/5] app/testpmd: check the validity of the port Huisong Li
2022-12-06 9:26 ` [PATCH V4 4/5] app/testpmd: add attach and detach port for multiple process Huisong Li
2023-01-11 12:51 ` Ferruh Yigit
2023-01-12 4:14 ` lihuisong (C)
2022-12-06 9:26 ` [PATCH V4 5/5] app/testpmd: stop forwarding in new or destroy event Huisong Li
2023-01-11 12:52 ` Ferruh Yigit
2023-01-12 4:16 ` lihuisong (C)
2023-01-09 12:38 ` [PATCH V4 0/5] app/testpmd: support mulitple process attach and detach port lihuisong (C)
2023-01-10 16:51 ` Ferruh Yigit
2023-01-11 0:53 ` lihuisong (C)
2023-01-11 10:27 ` Ferruh Yigit
2023-01-11 10:46 ` Ferruh Yigit
2023-01-12 2:26 ` lihuisong (C)
2023-01-18 14:12 ` Thomas Monjalon
2023-01-19 10:31 ` lihuisong (C)
2023-01-19 14:35 ` Thomas Monjalon
2023-01-28 1:39 ` lihuisong (C)
2023-01-31 3:33 ` [PATCH V5 0/5] app/testpmd: support multiple " Huisong Li
2023-01-31 3:33 ` [PATCH V5 1/5] drivers/bus: restore driver assignment at front of probing Huisong Li
2023-01-31 3:33 ` [PATCH V5 2/5] ethdev: fix skip valid port in probing callback Huisong Li
2023-05-22 11:04 ` fengchengwen
2023-05-27 1:58 ` lihuisong (C)
2023-01-31 3:33 ` [PATCH V5 3/5] app/testpmd: check the validity of the port Huisong Li
2023-01-31 3:33 ` [PATCH V5 4/5] app/testpmd: add attach and detach port for multiple process Huisong Li
2023-01-31 3:33 ` [PATCH V5 5/5] app/testpmd: stop forwarding in new or destroy event Huisong Li
2023-05-16 11:27 ` [PATCH V5 0/5] app/testpmd: support multiple process attach and detach port lihuisong (C)
2023-05-23 0:46 ` fengchengwen
2023-05-27 2:11 ` [PATCH V6 " Huisong Li
2023-05-27 2:11 ` [PATCH V6 1/5] drivers/bus: restore driver assignment at front of probing Huisong Li
2023-05-27 2:11 ` [PATCH V6 2/5] ethdev: fix skip valid port in probing callback Huisong Li
2023-05-27 2:11 ` [PATCH V6 3/5] app/testpmd: check the validity of the port Huisong Li
2023-05-27 2:11 ` [PATCH V6 4/5] app/testpmd: add attach and detach port for multiple process Huisong Li
2023-05-27 2:11 ` [PATCH V6 5/5] app/testpmd: stop forwarding in new or destroy event Huisong Li
2023-06-06 16:26 ` [PATCH V6 0/5] app/testpmd: support multiple process attach and detach port Ferruh Yigit
2023-06-07 10:14 ` lihuisong (C)
2023-07-14 7:21 ` lihuisong (C)
2023-08-02 3:15 ` [PATCH RESEND v6 " Huisong Li
2023-08-02 3:15 ` [PATCH RESEND v6 1/5] drivers/bus: restore driver assignment at front of probing Huisong Li
2023-08-02 3:15 ` [PATCH RESEND v6 2/5] ethdev: fix skip valid port in probing callback Huisong Li
2023-08-02 3:15 ` [PATCH RESEND v6 3/5] app/testpmd: check the validity of the port Huisong Li
2023-08-02 3:15 ` [PATCH RESEND v6 4/5] app/testpmd: add attach and detach port for multiple process Huisong Li
2023-08-02 3:16 ` [PATCH RESEND v6 5/5] app/testpmd: stop forwarding in new or destroy event Huisong Li
2023-10-09 10:34 ` [PATCH RESEND v6 0/5] app/testpmd: support multiple process attach and detach port lihuisong (C)
2023-10-30 12:17 ` lihuisong (C)
2023-12-08 2:25 ` lihuisong (C)
2024-01-30 6:36 ` [PATCH v7 " Huisong Li
2024-01-30 6:36 ` [PATCH v7 1/5] drivers/bus: restore driver assignment at front of probing Huisong Li
2024-01-30 6:36 ` [PATCH v7 2/5] ethdev: fix skip valid port in probing callback Huisong Li
2024-01-30 6:36 ` [PATCH v7 3/5] app/testpmd: check the validity of the port Huisong Li
2024-01-30 6:36 ` [PATCH v7 4/5] app/testpmd: add attach and detach port for multiple process Huisong Li
2024-01-30 6:36 ` [PATCH v7 5/5] app/testpmd: stop forwarding in new or destroy event Huisong Li
2024-03-08 10:38 ` [PATCH v7 0/5] app/testpmd: support multiple process attach and detach port lihuisong (C)
2024-04-23 11:17 ` lihuisong (C)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=461a4536-fbbd-3848-af8d-2aa1ebaf8ccb@huawei.com \
--to=lihuisong@huawei.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=ferruh.yigit@amd.com \
--cc=huangdaode@huawei.com \
--cc=liudongdong3@huawei.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).