DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ami Sabo <amis@radware.com>, yuanhan.liu@linux.intel.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 0/2] Fix virtio-user multi-process crash.
Date: Thu, 06 Apr 2017 22:14:59 +0200	[thread overview]
Message-ID: <4691348.WVCvaACybL@xps13> (raw)
In-Reply-To: <1655428.Al161abRzh@xps13>

Ping

2017-03-08 12:40, Thomas Monjalon:
> 2017-03-02 11:00, Ami Sabo:
> > The patchset fixes secondary process crash issue when it tries
> > to access virtio-user pmd (e.g. via rte_eth_rx_burst).
> > 
> > The crash happens because in virtio_user probing,
> > eth_dev_attach_secondary is not being called, as it does from
> > rte_eth_dev_pci_probe. Therefore, the device is not properly
> > initialized.
> > 
> > The patchset contains 2 patches:
> > 1. Export rte_eth_dev_attach_secondary, so non-pci drivers will be
> > allowed to call it.
> > 2. Fix the actual bug by calling the function during virtio_user probe.
> 
> I do not understand why nobody complains for other virtual devices.
> We should have the same issue with pcap, tap, ring, af_packet, etc.
> Probably that other drivers are broken in secondary processes.
> Or should we make a fix to handle every secondary vdev in
> rte_eth_dev_allocate() ?

Any opinion?

  reply	other threads:[~2017-04-06 20:15 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-23 11:58 [dpdk-dev] [PATCH] net/virtio-user: fix multi-process issue Ami Sabo
2017-02-24  8:22 ` Yuanhan Liu
2017-02-26  9:55 ` [dpdk-dev] [PATCH 0/2] Fix virtio-user multi-process crash Ami Sabo
2017-02-26  9:55   ` [dpdk-dev] [PATCH 1/2] lib/librte_ether: export secondary attach function Ami Sabo
2017-02-28  6:37     ` Yuanhan Liu
2017-03-02  7:51     ` [dpdk-dev] [PATCH v2 0/3] Fix virtio-user multi-process crash Ami Sabo
2017-03-02  7:51       ` [dpdk-dev] [PATCH v2 1/3] lib/librte_ether: export secondary attach function Ami Sabo
2017-03-02  7:51       ` [dpdk-dev] [PATCH v2 2/3] net/virtio-user: fix multi-process issue Ami Sabo
2017-03-02  7:51       ` [dpdk-dev] [PATCH v2 3/3] lib/librte_ether: fix code style issues Ami Sabo
2017-03-02  8:12         ` Yuanhan Liu
2017-03-02  9:00     ` [dpdk-dev] [PATCH 0/2] Fix virtio-user multi-process crash Ami Sabo
2017-03-02  9:00       ` [dpdk-dev] [PATCH 1/2] lib/librte_ether: export secondary attach function Ami Sabo
2017-03-02  9:00       ` [dpdk-dev] [PATCH 2/2] net/virtio-user: fix multi-process issue Ami Sabo
2017-03-08 11:40       ` [dpdk-dev] [PATCH 0/2] Fix virtio-user multi-process crash Thomas Monjalon
2017-04-06 20:14         ` Thomas Monjalon [this message]
2017-04-07  6:33           ` Tan, Jianfeng
2017-04-14 12:13       ` Thomas Monjalon
2017-02-26  9:55   ` [dpdk-dev] [PATCH 2/2] net/virtio-user: fix multi-process issue Ami Sabo
2017-02-28  6:40     ` Yuanhan Liu
2017-02-28  7:50       ` Ami Sabo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4691348.WVCvaACybL@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=amis@radware.com \
    --cc=dev@dpdk.org \
    --cc=yuanhan.liu@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).