From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/thunderx: add device speed capability info
Date: Wed, 30 Aug 2017 14:31:07 +0100 [thread overview]
Message-ID: <469dafbe-eefc-bb0b-1c5b-e300431f6a41@intel.com> (raw)
In-Reply-To: <20170830113007.28620-1-jerin.jacob@caviumnetworks.com>
On 8/30/2017 12:30 PM, Jerin Jacob wrote:
> updated nicvf feature file to mark support.
>
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---
> doc/guides/nics/features/thunderx.ini | 1 +
> drivers/net/thunderx/nicvf_ethdev.c | 9 +++++++++
> 2 files changed, 10 insertions(+)
>
> diff --git a/doc/guides/nics/features/thunderx.ini b/doc/guides/nics/features/thunderx.ini
> index b9720be6b..626858971 100644
> --- a/doc/guides/nics/features/thunderx.ini
> +++ b/doc/guides/nics/features/thunderx.ini
> @@ -4,6 +4,7 @@
> ; Refer to default.ini for the full list of available PMD features.
> ;
> [Features]
> +Speed capabilities = Y
> Link status = Y
> Link status event = Y
> Queue start/stop = Y
> diff --git a/drivers/net/thunderx/nicvf_ethdev.c b/drivers/net/thunderx/nicvf_ethdev.c
> index edc17f1d4..bfad07933 100644
> --- a/drivers/net/thunderx/nicvf_ethdev.c
> +++ b/drivers/net/thunderx/nicvf_ethdev.c
> @@ -1380,6 +1380,15 @@ nicvf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
>
> dev_info->pci_dev = RTE_ETH_DEV_TO_PCI(dev);
>
> + /* Autonegotiation may be disabled */
> + dev_info->speed_capa = ETH_LINK_SPEED_FIXED;
> + dev_info->speed_capa |= ETH_LINK_SPEED_10M;
> + dev_info->speed_capa |= ETH_LINK_SPEED_100M;
> + dev_info->speed_capa |= ETH_LINK_SPEED_1G;
> + dev_info->speed_capa |= ETH_LINK_SPEED_10G;
Why not just "|" them, same result with less code ...
> + if (nicvf_hw_version(nic) != PCI_SUB_DEVICE_ID_CN81XX_NICVF)
> + dev_info->speed_capa |= ETH_LINK_SPEED_40G;
> +
> dev_info->min_rx_bufsize = ETHER_MIN_MTU;
> dev_info->max_rx_pktlen = NIC_HW_MAX_FRS;
> dev_info->max_rx_queues =
>
next prev parent reply other threads:[~2017-08-30 13:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 11:30 Jerin Jacob
2017-08-30 13:31 ` Ferruh Yigit [this message]
2017-09-04 6:12 ` Jerin Jacob
2017-09-04 15:10 ` [dpdk-dev] [PATCH v2] " Jerin Jacob
2017-09-11 13:42 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=469dafbe-eefc-bb0b-1c5b-e300431f6a41@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).