From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>,
Fan Zhang <roy.fan.zhang@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/2] mk: move crypto scheduler library
Date: Tue, 31 Jan 2017 14:20:59 +0000 [thread overview]
Message-ID: <46e1fa65-9013-121f-da7f-51eaa24cf6df@intel.com> (raw)
In-Reply-To: <1747389.KZLHpWvR9T@xps13>
On 1/31/2017 2:10 PM, Thomas Monjalon wrote:
> 2017-01-31 11:59, Ferruh Yigit:
>> There is already a block for crypto libraries, move the PMD library to
>> that block.
>>
>> This prevents extra ifdef check for cryptodev.
>
> That's why I thought also when reading this patch:
> http://dpdk.org/commit/dbb336407
> Then I've read its message:
> "Different than other cryptodev PMDs, scheduler PMD is required to be built
> as shared libraries."
This patch requires following patch for shared library compilation:
http://dpdk.org/dev/patchwork/patch/20091/
I tried to separate patches, but it seems not able to completely.
Overall, for this patch and above referenced one, need to decide how to
link PMDs with APIs (like bonding, xenvirt)
>
> I guess the explanation is that it has an API (like bonding has):
> drivers/crypto/scheduler/rte_cryptodev_scheduler.h
>
> However, it is neither referenced in doc/api/doxy-api.conf nor
> doc/api/doxy-api-index.md.
>
>
<...>
next prev parent reply other threads:[~2017-01-31 14:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 11:59 [dpdk-dev] [PATCH 1/2] mk: move libs that don't dependent PMD libs out of whole archive Ferruh Yigit
2017-01-31 11:59 ` [dpdk-dev] [PATCH 2/2] mk: move crypto scheduler library Ferruh Yigit
2017-01-31 14:10 ` Thomas Monjalon
2017-01-31 14:20 ` Ferruh Yigit [this message]
2017-01-31 13:59 ` [dpdk-dev] [PATCH 1/2] mk: move libs that don't dependent PMD libs out of whole archive Thomas Monjalon
2017-01-31 15:01 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2017-02-09 21:48 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46e1fa65-9013-121f-da7f-51eaa24cf6df@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
--cc=roy.fan.zhang@intel.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).