From: Andrew Rybchenko <arybchenko@solarflare.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>, <dev@dpdk.org>
Cc: Ivan Malov <ivan.malov@oktetlabs.ru>, <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH 01/30] net/sfc: log port ID as 16-bit unsigned integer on panic
Date: Fri, 8 Feb 2019 13:31:54 +0300 [thread overview]
Message-ID: <46fa4465-1513-57c3-e273-ba9729929cb5@solarflare.com> (raw)
In-Reply-To: <2d03e53f-66a5-413a-66fd-6db2842c4a37@intel.com>
Hi Ferruh,
On 2/8/19 1:13 PM, Ferruh Yigit wrote:
> On 2/7/2019 12:17 PM, Andrew Rybchenko wrote:
>> From: Ivan Malov <ivan.malov@oktetlabs.ru>
>>
>> Fixes: f8244c6399d9 ("ethdev: increase port id range")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
>> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
>> ---
>> drivers/net/sfc/sfc_debug.h | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/sfc/sfc_debug.h b/drivers/net/sfc/sfc_debug.h
>> index 6b600ff4d..62f3937e8 100644
>> --- a/drivers/net/sfc/sfc_debug.h
>> +++ b/drivers/net/sfc/sfc_debug.h
>> @@ -27,7 +27,8 @@
>> do { \
>> const struct sfc_adapter *_sa = (sa); \
>> \
>> - rte_panic("sfc " PCI_PRI_FMT " #%" PRIu8 ": " fmt "\n", \
>> + rte_panic("sfc " PCI_PRI_FMT \
>> + " #%" PRIu16 ": " fmt "\n", \
>> _sa->pci_addr.domain, _sa->pci_addr.bus, \
>> _sa->pci_addr.devid, _sa->pci_addr.function, \
>> _sa->port_id, ##args); \
>>
> Overall it may not be good idea to call rte_panic() from driver. rte_panic()
> cause the DPDK application to terminate, if a driver fails application may
> prefer to handle that error and continue to run, so terminate decision should be
> from application not library.
>
> Can you please double check if rte_panic() usages in the driver can be converted
> to error reporting?
Thanks a lot for reminder. We use it in few places, but even those can be
improved. We'll do it.
Andrew.
next prev parent reply other threads:[~2019-02-08 10:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1549541873-17403-1-git-send-email-arybchenko@solarflare.com>
2019-02-07 12:17 ` [dpdk-stable] " Andrew Rybchenko
2019-02-08 10:13 ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
2019-02-08 10:31 ` Andrew Rybchenko [this message]
2019-02-07 12:17 ` [dpdk-stable] [PATCH 02/30] net/sfc: remove control path logging from Rx queue count Andrew Rybchenko
2019-02-07 12:17 ` [dpdk-stable] [PATCH 03/30] net/sfc: fix logging from secondary process Andrew Rybchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46fa4465-1513-57c3-e273-ba9729929cb5@solarflare.com \
--to=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=ivan.malov@oktetlabs.ru \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).