From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Andrey Chilikin <andrey.chilikin@intel.com>, dev@dpdk.org
Cc: beilei.xing@intel.com, jingjing.wu@intel.com
Subject: Re: [dpdk-dev] [PATCH v2 2/2] app/testpmd: enable ddp remove profile feature
Date: Tue, 27 Jun 2017 10:55:51 +0100 [thread overview]
Message-ID: <4760b55e-875a-c6a7-dde2-ae0bd3ea4e33@intel.com> (raw)
In-Reply-To: <1498551492-17214-3-git-send-email-andrey.chilikin@intel.com>
On 6/27/2017 9:18 AM, Andrey Chilikin wrote:
> New command 'ddp del (port) (profile_path)' removes previously
> loaded profile and deletes it from the list of the loaded profiles.
>
> Signed-off-by: Andrey Chilikin <andrey.chilikin@intel.com>
<...>
> @@ -12860,6 +12863,9 @@ cmd_ddp_add_parsed(
> struct cmd_ddp_add_result *res = parsed_result;
> uint8_t *buff;
> uint32_t size;
> + char *filepath;
> + char *file_fld[2];
> + int file_num;
> int ret = -ENOTSUP;
>
> if (res->port_id > nb_ports) {
> @@ -12872,9 +12878,18 @@ cmd_ddp_add_parsed(
> return;
> }
>
> - buff = open_ddp_package_file(res->filepath, &size);
> - if (!buff)
> + filepath = strdup(res->filepath);
> + if (filepath == NULL) {
> + printf("Failed to allocate memory\n");
> return;
> + }
> + file_num = rte_strsplit(filepath, strlen(filepath), file_fld, 2, ',');
> +
> + buff = open_ddp_package_file(file_fld[0], &size);
> + if (!buff) {
> + free((void *)filepath);
> + return;
> + }
<...>
Can you please export ddp_add related changes into different patch?
Thanks,
ferruh
next prev parent reply other threads:[~2017-06-27 9:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-27 16:04 [dpdk-dev] [PATCH] net/i40e: extended list of operations for ddp processing Andrey Chilikin
2017-06-27 8:18 ` [dpdk-dev] [PATCH v2 0/2] " Andrey Chilikin
2017-06-27 8:18 ` [dpdk-dev] [PATCH v2 1/2] " Andrey Chilikin
2017-06-27 8:18 ` [dpdk-dev] [PATCH v2 2/2] app/testpmd: enable ddp remove profile feature Andrey Chilikin
2017-06-27 9:55 ` Ferruh Yigit [this message]
2017-06-27 13:35 ` [dpdk-dev] [PATCH v3 0/2] net/i40e: extended list of operations for ddp processing Andrey Chilikin
2017-06-27 13:35 ` [dpdk-dev] [PATCH v3 1/2] " Andrey Chilikin
2017-06-28 6:57 ` Xing, Beilei
2017-06-28 7:40 ` Chilikin, Andrey
2017-06-28 8:03 ` Xing, Beilei
2017-06-27 13:35 ` [dpdk-dev] [PATCH v3 2/2] app/testpmd: enable ddp remove profile feature Andrey Chilikin
2017-06-28 6:40 ` Xing, Beilei
2017-06-28 8:15 ` [dpdk-dev] [PATCH v4 0/2] net/i40e: extended list of operations for ddp processing Andrey Chilikin
2017-06-28 9:47 ` Ferruh Yigit
2017-06-28 8:15 ` [dpdk-dev] [PATCH v4 1/2] " Andrey Chilikin
2017-06-28 8:25 ` Xing, Beilei
2017-06-28 8:15 ` [dpdk-dev] [PATCH v4 2/2] app/testpmd: enable ddp remove profile feature Andrey Chilikin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4760b55e-875a-c6a7-dde2-ae0bd3ea4e33@intel.com \
--to=ferruh.yigit@intel.com \
--cc=andrey.chilikin@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).