From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>,
Nitin Saxena <nitin.saxena@caviumnetworks.com>
Cc: Narayana Prasad <narayanaprasad.athreya@caviumnetworks.com>,
dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/thunderx: fix MTU configuration for jumbo pkts
Date: Wed, 18 Apr 2018 18:03:16 +0100 [thread overview]
Message-ID: <47649369-11ad-228a-1730-52c9d1320b57@intel.com> (raw)
In-Reply-To: <20180418045653.GA6696@jerin>
On 4/18/2018 5:56 AM, Jerin Jacob wrote:
> -----Original Message-----
>> Date: Mon, 16 Apr 2018 10:44:47 +0000
>> From: Nitin Saxena <nitin.saxena@caviumnetworks.com>
>> To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
>> Cc: Nitin Saxena <nitin.saxena@caviumnetworks.com>, Narayana Prasad
>> <narayanaprasad.athreya@caviumnetworks.com>, dev@dpdk.org
>> Subject: [PATCH] net/thunderx: fix MTU configuration for jumbo pkts
>> X-Mailer: git-send-email 2.7.4
>>
>> thunderx pmd driver passes dev_info.max_rx_pktlen as
>> 9200 (via rte_eth_dev_info_get()) to application.
>> But, when application tries to set MTU as
>> (9200 - sizeof(ethernet_header_t)) the operation fails
>> because of missing CRC and VLAN additions.
>>
>> This patch fixes the following for thunderx pmd driver:
>> - Sets NIC_HW_MAX_FRS to 9216 (instead of 9200)
>> - Sets NIC_HW_MAX_MTU to 9190 (NIC_HW_MAX_FRS - ETH_HLEN
>> - ETHER_CRC_LEN - 2*VLAN_HLEN)
>> - Sets dev_info->max_rx_pkt_len to NIC_HW_MAX_MTU +
>> ETH_HLEN (instead of 9200)
>> - Allows rte_eth_dev_set_mtu() to pass if application
>> (like VPP) calls rte_eth_dev_set_mtu() before
>> rte_eth_dev_start() by putting appropriate check for
>> dev->data->dev_started
>>
>> Fixes: 65d9804edc05 ("net/thunderx: support MTU configuration")
>>
>
> Cc: stable@dpdk.org
>
>> Signed-off-by: Nitin Saxena <nitin.saxena@caviumnetworks.com>
>
> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Applied to dpdk-next-net/master, thanks.
prev parent reply other threads:[~2018-04-18 17:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-16 10:44 Nitin Saxena
2018-04-18 4:56 ` Jerin Jacob
2018-04-18 17:03 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47649369-11ad-228a-1730-52c9d1320b57@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=narayanaprasad.athreya@caviumnetworks.com \
--cc=nitin.saxena@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).