From: Thomas Monjalon <thomas@monjalon.net>
To: Dariusz Sosnowski <dsosnowski@nvidia.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>, Ori Kam <orika@nvidia.com>,
Xiaoyun Li <xiaoyun.li@intel.com>,
Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>,
dev@dpdk.org, Slava Ovsiienko <viacheslavo@nvidia.com>
Subject: Re: [PATCH] app/testpmd: register metadata dynfield on modify field
Date: Mon, 14 Mar 2022 21:42:51 +0100 [thread overview]
Message-ID: <4790656.0VBMTVartN@thomas> (raw)
In-Reply-To: <BY5PR12MB422769CD49FDE5C1EEC11575A40A9@BY5PR12MB4227.namprd12.prod.outlook.com>
09/03/2022 12:50, Dariusz Sosnowski:
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> > On 3/1/2022 11:51 AM, Dariusz Sosnowski wrote:
> > > This patch adds implicit registration of metadata dynamic field and
> > > flag
> >
> > Hi Dariusz,
> >
> > metaday dynamic field is explicitly registered when testpmd command used
> > to enable tx metadata, or rte flow rule created with "set_meta" action.
> >
> > Can you please document more when this implicit enablement is required?
> > And why that case doesn't cover above explicit enable cases?
>
> Before this patch, when a user inserted a flow rule with MODIFY_FIELD action,
> which modified packet metadata, the metadata dynamic field was not registered, as opposed to
> what happened with SET_META action. Goal of this patch is to make the behavior consistent
> between these two actions.
I think consistency should be ensured by the PMD.
Why not registering the field in the PMD?
prev parent reply other threads:[~2022-03-14 20:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 11:51 Dariusz Sosnowski
2022-03-03 12:20 ` Ferruh Yigit
2022-03-09 11:50 ` Dariusz Sosnowski
2022-03-14 20:42 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4790656.0VBMTVartN@thomas \
--to=thomas@monjalon.net \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=ferruh.yigit@intel.com \
--cc=orika@nvidia.com \
--cc=viacheslavo@nvidia.com \
--cc=xiaoyun.li@intel.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).