From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Rasesh Mody <rasesh.mody@cavium.com>, dev@dpdk.org
Cc: Dept-EngDPDKDev@cavium.com
Subject: Re: [dpdk-dev] [PATCH 8/9] net/qede: use newer packet mbuf allocate API
Date: Thu, 29 Jun 2017 13:55:28 +0100 [thread overview]
Message-ID: <47bf845e-61a1-14c2-428b-5a42864355d4@intel.com> (raw)
In-Reply-To: <1498729889-21524-9-git-send-email-rasesh.mody@cavium.com>
On 6/29/2017 10:51 AM, Rasesh Mody wrote:
> Use rte_pktmbuf_alloc() API instead of rte_mbuf_raw_alloc().
>
> Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>
> ---
> drivers/net/qede/qede_rxtx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c
> index 8063233..6b047a3 100644
> --- a/drivers/net/qede/qede_rxtx.c
> +++ b/drivers/net/qede/qede_rxtx.c
> @@ -16,7 +16,7 @@ static inline int qede_alloc_rx_buffer(struct qede_rx_queue *rxq)
> dma_addr_t mapping;
> uint16_t idx = rxq->sw_rx_prod & NUM_RX_BDS(rxq);
>
> - new_mb = rte_mbuf_raw_alloc(rxq->mb_pool);
> + new_mb = rte_pktmbuf_alloc(rxq->mb_pool);
rte_pktmbuf_alloc() is more expensive call, because of
rte_pktmbuf_reset() it has.
Are you sure you want to switch, what is the motivation?
> if (unlikely(!new_mb)) {
> PMD_RX_LOG(ERR, rxq,
> "Failed to allocate rx buffer "
>
next prev parent reply other threads:[~2017-06-29 12:55 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 9:51 [dpdk-dev] [PATCH 0/9] net/qede: update PMD to 2.5.1.1 Rasesh Mody
2017-06-29 9:51 ` [dpdk-dev] [PATCH 1/9] net/qede: fix DMA memory leak Rasesh Mody
2017-06-29 9:51 ` [dpdk-dev] [PATCH 2/9] net/qede: add notifying HW errors Rasesh Mody
2017-06-29 9:51 ` [dpdk-dev] [PATCH 3/9] net/qede: limit ring size to 32k Rasesh Mody
2017-06-29 9:51 ` [dpdk-dev] [PATCH 4/9] net/qede: comments traces and format changes Rasesh Mody
2017-06-29 9:51 ` [dpdk-dev] [PATCH 5/9] net/qede: change debug verbosity of PMD messages Rasesh Mody
2017-06-29 9:51 ` [dpdk-dev] [PATCH 6/9] net/qede: set mdump flag Rasesh Mody
2017-06-29 9:51 ` [dpdk-dev] [PATCH 7/9] net/qede: add missing check for VNI Rasesh Mody
2017-06-29 9:51 ` [dpdk-dev] [PATCH 8/9] net/qede: use newer packet mbuf allocate API Rasesh Mody
2017-06-29 12:55 ` Ferruh Yigit [this message]
2017-07-01 19:34 ` Mody, Rasesh
2017-06-29 9:51 ` [dpdk-dev] [PATCH 9/9] net/qede: update PMD version to 2.5.1.1 Rasesh Mody
2017-06-29 12:16 ` [dpdk-dev] [PATCH 0/9] net/qede: update PMD " Ferruh Yigit
2017-07-01 19:29 ` [dpdk-dev] [PATCH v2 0/8] " Rasesh Mody
2017-07-05 10:01 ` Ferruh Yigit
2017-07-08 18:35 ` Mody, Rasesh
2017-07-01 19:29 ` [dpdk-dev] [PATCH v2 1/8] net/qede: fix DMA memory leak Rasesh Mody
2017-07-01 19:29 ` [dpdk-dev] [PATCH v2 2/8] net/qede: add notifying HW errors Rasesh Mody
2017-07-01 19:29 ` [dpdk-dev] [PATCH v2 3/8] net/qede: limit ring size to 32k Rasesh Mody
2017-07-01 19:29 ` [dpdk-dev] [PATCH v2 4/8] net/qede: comments traces and format changes Rasesh Mody
2017-07-01 19:29 ` [dpdk-dev] [PATCH v2 5/8] net/qede: change debug verbosity of PMD messages Rasesh Mody
2017-07-01 19:30 ` [dpdk-dev] [PATCH v2 6/8] net/qede: set mdump flag Rasesh Mody
2017-07-01 19:30 ` [dpdk-dev] [PATCH v2 7/8] net/qede: add missing check for VNI Rasesh Mody
2017-07-03 10:08 ` Ferruh Yigit
2017-07-01 19:30 ` [dpdk-dev] [PATCH v2 8/8] net/qede: update PMD version to 2.5.1.1 Rasesh Mody
2017-07-03 10:06 ` Ferruh Yigit
2017-07-05 9:57 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47bf845e-61a1-14c2-428b-5a42864355d4@intel.com \
--to=ferruh.yigit@intel.com \
--cc=Dept-EngDPDKDev@cavium.com \
--cc=dev@dpdk.org \
--cc=rasesh.mody@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).