DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Jianbo Liu <jianbo.liu@linaro.org>, cristian.dumitrescu@intel.com
Cc: dev@dpdk.org, jerin.jacob@caviumnetworks.com,
	ashwin.sekhar@caviumnetworks.com
Subject: Re: [dpdk-dev] [PATCH] examples/ip_pipeline: use crc32 in hash functions for arm64
Date: Mon, 03 Jul 2017 23:11:34 +0200	[thread overview]
Message-ID: <4804120.hkK0KHU9aJ@xps> (raw)
In-Reply-To: <1495098540-8303-1-git-send-email-jianbo.liu@linaro.org>

18/05/2017 11:09, Jianbo Liu:
> Implement the same hash functions with crc32 on arm platform.
> 
> Signed-off-by: Jianbo Liu <jianbo.liu@linaro.org>
> ---
>  examples/ip_pipeline/pipeline/hash_func.h       |   2 +
>  examples/ip_pipeline/pipeline/hash_func_arm64.h | 245 ++++++++++++++++++++++++
>  2 files changed, 247 insertions(+)
>  create mode 100644 examples/ip_pipeline/pipeline/hash_func_arm64.h

I don't understand why this code is in an example.
We have some CRC code in librte_hash, librte_net and ip_pipeline.
Cristian, Jianbo,
does it make sense to move these functions somewhere else?

  reply	other threads:[~2017-07-03 21:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-18  9:09 Jianbo Liu
2017-07-03 21:11 ` Thomas Monjalon [this message]
2017-07-03 23:19   ` Dumitrescu, Cristian
2017-07-03 23:25     ` Thomas Monjalon
2017-07-04 13:55       ` De Lara Guarch, Pablo
2017-07-05  3:38         ` Jianbo Liu
2017-10-24 15:38           ` Dumitrescu, Cristian
2017-10-25  7:01             ` Jianbo Liu
2017-10-27  9:25 ` [dpdk-dev] [PATCH v2] " Jianbo Liu
2017-10-27  9:55   ` Dumitrescu, Cristian
2017-11-07  7:51     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4804120.hkK0KHU9aJ@xps \
    --to=thomas@monjalon.net \
    --cc=ashwin.sekhar@caviumnetworks.com \
    --cc=cristian.dumitrescu@intel.com \
    --cc=dev@dpdk.org \
    --cc=jerin.jacob@caviumnetworks.com \
    --cc=jianbo.liu@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).