From: "Nicolau, Radu" <radu.nicolau@intel.com>
To: Ruifeng Wang <Ruifeng.Wang@arm.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "beilei.xing@intel.com" <beilei.xing@intel.com>,
"jia.guo@intel.com" <jia.guo@intel.com>,
"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
"konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com>,
"jerinjacobk@gmail.com" <jerinjacobk@gmail.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>,
"fiona.trahe@intel.com" <fiona.trahe@intel.com>,
"wei.zhao1@intel.com" <wei.zhao1@intel.com>, nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH v8 2/4] net/i40e: use WC store to update queue tail registers
Date: Mon, 20 Jul 2020 09:54:39 +0100 [thread overview]
Message-ID: <482f5554-912f-cbf7-2679-b3295929068d@intel.com> (raw)
In-Reply-To: <HE1PR0801MB20259127DCC633248A515F809E7B0@HE1PR0801MB2025.eurprd08.prod.outlook.com>
On 7/20/2020 7:46 AM, Ruifeng Wang wrote:
>> -----Original Message-----
>> From: Radu Nicolau <radu.nicolau@intel.com>
>> Sent: Friday, July 17, 2020 6:50 PM
>> To: dev@dpdk.org
>> Cc: beilei.xing@intel.com; jia.guo@intel.com; bruce.richardson@intel.com;
>> konstantin.ananyev@intel.com; jerinjacobk@gmail.com;
>> david.marchand@redhat.com; fiona.trahe@intel.com; wei.zhao1@intel.com;
>> Ruifeng Wang <Ruifeng.Wang@arm.com>; Radu Nicolau
>> <radu.nicolau@intel.com>
>> Subject: [PATCH v8 2/4] net/i40e: use WC store to update queue tail registers
>>
>> Performance improvement: use a write combining store instead of a regular
>> mmio write to update queue tail registers.
>>
>> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
>> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>> ---
>> drivers/net/i40e/base/i40e_osdep.h | 5 +++++
>> drivers/net/i40e/i40e_rxtx.c | 8 ++++----
>> drivers/net/i40e/i40e_rxtx_vec_avx2.c | 4 ++--
>> drivers/net/i40e/i40e_rxtx_vec_sse.c | 4 ++--
>> 4 files changed, 13 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/net/i40e/base/i40e_osdep.h
>> b/drivers/net/i40e/base/i40e_osdep.h
>> index 58be396..69ab717 100644
>> --- a/drivers/net/i40e/base/i40e_osdep.h
>> +++ b/drivers/net/i40e/base/i40e_osdep.h
>> @@ -138,6 +138,11 @@ static inline uint32_t i40e_read_addr(volatile void
>> *addr)
>> #define I40E_PCI_REG_WRITE_RELAXED(reg, value) \
>> rte_write32_relaxed((rte_cpu_to_le_32(value)), reg)
>>
>> +#define I40E_PCI_REG_WC_WRITE(queue, reg, value) \
> 'queue' is not necessary since it will not be used. It can be removed?
Yes, I will remove it - in the first version we had a flag in the queue
struct, and this macro was not properly updated.
>
> Thanks.
> /Ruifeng
>> + rte_write32_wc((rte_cpu_to_le_32(value)), reg) #define
>> +I40E_PCI_REG_WC_WRITE_RELAXED(queue, reg, value) \
>> + rte_write32_wc_relaxed((rte_cpu_to_le_32(value)), reg)
>> +
>> #define I40E_WRITE_FLUSH(a) I40E_READ_REG(a, I40E_GLGEN_STAT)
>> #define I40EVF_WRITE_FLUSH(a) I40E_READ_REG(a, I40E_VFGEN_RSTAT)
>>
>> diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c index
>> 840b6f3..64e43ac 100644
>> --- a/drivers/net/i40e/i40e_rxtx.c
>> +++ b/drivers/net/i40e/i40e_rxtx.c
>> @@ -760,7 +760,7 @@ i40e_recv_pkts(void *rx_queue, struct rte_mbuf
>> **rx_pkts, uint16_t nb_pkts)
>> if (nb_hold > rxq->rx_free_thresh) {
>> rx_id = (uint16_t) ((rx_id == 0) ?
>> (rxq->nb_rx_desc - 1) : (rx_id - 1));
>> - I40E_PCI_REG_WRITE(rxq->qrx_tail, rx_id);
>> + I40E_PCI_REG_WC_WRITE(rxq, rxq->qrx_tail, rx_id);
>> nb_hold = 0;
>> }
>> rxq->nb_rx_hold = nb_hold;
>> @@ -938,7 +938,7 @@ i40e_recv_scattered_pkts(void *rx_queue,
>> if (nb_hold > rxq->rx_free_thresh) {
>> rx_id = (uint16_t)(rx_id == 0 ?
>> (rxq->nb_rx_desc - 1) : (rx_id - 1));
>> - I40E_PCI_REG_WRITE(rxq->qrx_tail, rx_id);
>> + I40E_PCI_REG_WC_WRITE(rxq, rxq->qrx_tail, rx_id);
>> nb_hold = 0;
>> }
>> rxq->nb_rx_hold = nb_hold;
>> @@ -1249,7 +1249,7 @@ i40e_xmit_pkts(void *tx_queue, struct rte_mbuf
>> **tx_pkts, uint16_t nb_pkts)
>> (unsigned) tx_id, (unsigned) nb_tx);
>>
>> rte_cio_wmb();
>> - I40E_PCI_REG_WRITE_RELAXED(txq->qtx_tail, tx_id);
>> + I40E_PCI_REG_WC_WRITE_RELAXED(txq, txq->qtx_tail, tx_id);
>> txq->tx_tail = tx_id;
>>
>> return nb_tx;
>> @@ -1400,7 +1400,7 @@ tx_xmit_pkts(struct i40e_tx_queue *txq,
>> txq->tx_tail = 0;
>>
>> /* Update the tx tail register */
>> - I40E_PCI_REG_WRITE(txq->qtx_tail, txq->tx_tail);
>> + I40E_PCI_REG_WC_WRITE(txq, txq->qtx_tail, txq->tx_tail);
>>
>> return nb_pkts;
>> }
>> diff --git a/drivers/net/i40e/i40e_rxtx_vec_avx2.c
>> b/drivers/net/i40e/i40e_rxtx_vec_avx2.c
>> index 3bcef13..294c1c4 100644
>> --- a/drivers/net/i40e/i40e_rxtx_vec_avx2.c
>> +++ b/drivers/net/i40e/i40e_rxtx_vec_avx2.c
>> @@ -134,7 +134,7 @@ i40e_rxq_rearm(struct i40e_rx_queue *rxq)
>> (rxq->nb_rx_desc - 1) : (rxq->rxrearm_start - 1));
>>
>> /* Update the tail pointer on the NIC */
>> - I40E_PCI_REG_WRITE(rxq->qrx_tail, rx_id);
>> + I40E_PCI_REG_WC_WRITE(rxq, rxq->qrx_tail, rx_id);
>> }
>>
>> #ifndef RTE_LIBRTE_I40E_16BYTE_RX_DESC
>> @@ -921,7 +921,7 @@ i40e_xmit_fixed_burst_vec_avx2(void *tx_queue,
>> struct rte_mbuf **tx_pkts,
>>
>> txq->tx_tail = tx_id;
>>
>> - I40E_PCI_REG_WRITE(txq->qtx_tail, txq->tx_tail);
>> + I40E_PCI_REG_WC_WRITE(txq, txq->qtx_tail, txq->tx_tail);
>>
>> return nb_pkts;
>> }
>> diff --git a/drivers/net/i40e/i40e_rxtx_vec_sse.c
>> b/drivers/net/i40e/i40e_rxtx_vec_sse.c
>> index 6985183..a4635e0 100644
>> --- a/drivers/net/i40e/i40e_rxtx_vec_sse.c
>> +++ b/drivers/net/i40e/i40e_rxtx_vec_sse.c
>> @@ -86,7 +86,7 @@ i40e_rxq_rearm(struct i40e_rx_queue *rxq)
>> (rxq->nb_rx_desc - 1) : (rxq->rxrearm_start - 1));
>>
>> /* Update the tail pointer on the NIC */
>> - I40E_PCI_REG_WRITE(rxq->qrx_tail, rx_id);
>> + I40E_PCI_REG_WC_WRITE(rxq, rxq->qrx_tail, rx_id);
>> }
>>
>> #ifndef RTE_LIBRTE_I40E_16BYTE_RX_DESC
>> @@ -733,7 +733,7 @@ i40e_xmit_fixed_burst_vec(void *tx_queue, struct
>> rte_mbuf **tx_pkts,
>>
>> txq->tx_tail = tx_id;
>>
>> - I40E_PCI_REG_WRITE(txq->qtx_tail, txq->tx_tail);
>> + I40E_PCI_REG_WC_WRITE(txq, txq->qtx_tail, txq->tx_tail);
>>
>> return nb_pkts;
>> }
>> --
>> 2.7.4
next prev parent reply other threads:[~2020-07-20 8:54 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 10:11 [dpdk-dev] [PATCH v1 1/2] eal/x86: add WC store function Radu Nicolau
2020-06-11 10:11 ` [dpdk-dev] [PATCH v1 2/2] net/i40e: use movdiri to update queue tail registers Radu Nicolau
2020-06-11 12:23 ` [dpdk-dev] [PATCH v1 1/2] eal/x86: add WC store function Jerin Jacob
2020-06-11 13:56 ` Nicolau, Radu
2020-06-11 15:33 ` Jerin Jacob
2020-06-15 11:11 ` Ananyev, Konstantin
2020-06-19 12:06 ` [dpdk-dev] [PATCH v2 1/2] eal: add WC store functions Radu Nicolau
2020-06-19 12:06 ` [dpdk-dev] [PATCH v2 2/2] net/i40e: use WC store to update queue tail registers Radu Nicolau
2020-07-01 13:15 ` Bruce Richardson
2020-07-01 13:14 ` [dpdk-dev] [PATCH v2 1/2] eal: add WC store functions Bruce Richardson
2020-07-01 14:15 ` [dpdk-dev] [PATCH v3 0/2] " Radu Nicolau
2020-07-01 14:15 ` [dpdk-dev] [PATCH v3 1/2] " Radu Nicolau
2020-07-01 14:15 ` [dpdk-dev] [PATCH v3 2/2] net/i40e: use WC store to update queue tail registers Radu Nicolau
2020-07-02 9:23 ` [dpdk-dev] [PATCH v4 0/2] eal: add WC store functions Radu Nicolau
2020-07-02 9:23 ` [dpdk-dev] [PATCH v4 1/2] " Radu Nicolau
2020-07-03 15:19 ` David Marchand
2020-07-06 9:15 ` Nicolau, Radu
2020-07-02 9:23 ` [dpdk-dev] [PATCH v4 2/2] net/i40e: use WC store to update queue tail registers Radu Nicolau
2020-07-06 12:29 ` [dpdk-dev] [PATCH v5 0/2] eal: add WC store functions Radu Nicolau
2020-07-06 12:29 ` [dpdk-dev] [PATCH v5 1/2] " Radu Nicolau
2020-07-06 12:30 ` [dpdk-dev] [PATCH v5 2/2] net/i40e: use WC store to update queue tail registers Radu Nicolau
2020-07-13 12:27 ` [dpdk-dev] [PATCH v6 0/4] eal: add WC store functions Radu Nicolau
2020-07-13 12:27 ` [dpdk-dev] [PATCH v6 1/4] " Radu Nicolau
2020-07-13 12:27 ` [dpdk-dev] [PATCH v6 2/4] net/i40e: use WC store to update queue tail registers Radu Nicolau
2020-07-13 12:27 ` [dpdk-dev] [PATCH v6 3/4] qat: " Radu Nicolau
2020-07-13 12:44 ` Bruce Richardson
2020-07-13 12:52 ` Trahe, Fiona
2020-07-13 12:57 ` Bruce Richardson
2020-07-13 12:27 ` [dpdk-dev] [PATCH v6 4/4] net/ixgbe: use WC store to update doorbell register Radu Nicolau
2020-07-16 12:29 ` [dpdk-dev] [PATCH v7 0/4] eal: add WC store functions Radu Nicolau
2020-07-16 12:29 ` [dpdk-dev] [PATCH v7 1/4] " Radu Nicolau
2020-07-16 12:29 ` [dpdk-dev] [PATCH v7 2/4] net/i40e: use WC store to update queue tail registers Radu Nicolau
2020-07-16 12:29 ` [dpdk-dev] [PATCH v7 3/4] common/qat: " Radu Nicolau
2020-07-16 12:29 ` [dpdk-dev] [PATCH v7 4/4] net/ixgbe: use WC store to update doorbell register Radu Nicolau
2020-07-17 10:49 ` [dpdk-dev] [PATCH v8 0/4] eal: add WC store functions Radu Nicolau
2020-07-17 10:49 ` [dpdk-dev] [PATCH v8 1/4] " Radu Nicolau
2020-07-20 6:42 ` Ruifeng Wang
2020-07-20 8:52 ` Nicolau, Radu
2020-07-17 10:49 ` [dpdk-dev] [PATCH v8 2/4] net/i40e: use WC store to update queue tail registers Radu Nicolau
2020-07-20 6:46 ` Ruifeng Wang
2020-07-20 8:54 ` Nicolau, Radu [this message]
2020-07-17 10:49 ` [dpdk-dev] [PATCH v8 3/4] common/qat: " Radu Nicolau
2020-07-17 16:42 ` Trahe, Fiona
2020-07-17 10:49 ` [dpdk-dev] [PATCH v8 4/4] net/ixgbe: " Radu Nicolau
2020-07-17 11:18 ` Ananyev, Konstantin
2020-07-20 9:12 ` [dpdk-dev] [PATCH v9 0/4] eal: add WC store functions Radu Nicolau
2020-07-20 9:12 ` [dpdk-dev] [PATCH v9 1/4] " Radu Nicolau
2020-07-20 12:20 ` David Marchand
2020-07-21 8:56 ` Nicolau, Radu
2020-07-20 9:12 ` [dpdk-dev] [PATCH v9 2/4] net/i40e: use WC store to update queue tail registers Radu Nicolau
2020-07-20 9:12 ` [dpdk-dev] [PATCH v9 3/4] common/qat: " Radu Nicolau
2020-07-20 9:12 ` [dpdk-dev] [PATCH v9 4/4] net/ixgbe: " Radu Nicolau
2020-07-21 11:31 ` [dpdk-dev] [PATCH v10 0/4] eal: add WC store functions Radu Nicolau
2020-07-21 11:31 ` [dpdk-dev] [PATCH v10 1/4] " Radu Nicolau
2020-07-21 11:31 ` [dpdk-dev] [PATCH v10 2/4] net/i40e: use WC store to update queue tail registers Radu Nicolau
2020-07-21 11:31 ` [dpdk-dev] [PATCH v10 3/4] common/qat: " Radu Nicolau
2020-07-21 11:31 ` [dpdk-dev] [PATCH v10 4/4] net/ixgbe: " Radu Nicolau
2020-08-26 9:55 ` [dpdk-dev] [PATCH v11 0/5] eal: add WC store functions Radu Nicolau
2020-08-26 9:55 ` [dpdk-dev] [PATCH v11 1/5] " Radu Nicolau
2020-08-26 9:55 ` [dpdk-dev] [PATCH v11 2/5] net/i40e: use WC store to update queue tail registers Radu Nicolau
2020-09-23 1:19 ` Lu, Wenzhuo
2020-08-26 9:55 ` [dpdk-dev] [PATCH v11 3/5] common/qat: " Radu Nicolau
2020-08-26 9:55 ` [dpdk-dev] [PATCH v11 4/5] net/ixgbe: " Radu Nicolau
2020-09-23 1:20 ` Lu, Wenzhuo
2020-08-26 9:55 ` [dpdk-dev] [PATCH v11 5/5] net/ice: " Radu Nicolau
2020-09-23 1:20 ` Lu, Wenzhuo
2020-09-23 14:22 ` [dpdk-dev] [PATCH v12 0/5] eal: add WC store functions Radu Nicolau
2020-09-23 14:22 ` [dpdk-dev] [PATCH v12 1/5] " Radu Nicolau
2020-09-23 14:22 ` [dpdk-dev] [PATCH v12 2/5] net/i40e: use WC store to update queue tail registers Radu Nicolau
2020-09-23 14:22 ` [dpdk-dev] [PATCH v12 3/5] common/qat: " Radu Nicolau
2020-09-23 14:22 ` [dpdk-dev] [PATCH v12 4/5] net/ixgbe: " Radu Nicolau
2020-09-23 14:22 ` [dpdk-dev] [PATCH v12 5/5] net/ice: " Radu Nicolau
2020-10-08 7:28 ` [dpdk-dev] [PATCH v12 0/5] eal: add WC store functions David Marchand
2020-10-08 9:51 ` Nicolau, Radu
2020-10-13 8:57 ` Ferruh Yigit
2020-10-13 12:50 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=482f5554-912f-cbf7-2679-b3295929068d@intel.com \
--to=radu.nicolau@intel.com \
--cc=Ruifeng.Wang@arm.com \
--cc=beilei.xing@intel.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=jerinjacobk@gmail.com \
--cc=jia.guo@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=nd@arm.com \
--cc=wei.zhao1@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).