From: Thomas Monjalon <thomas@monjalon.net>
To: Ori Kam <orika@mellanox.com>
Cc: dev@dpdk.org, adrien.mazarguil@6wind.com, john.mcnamara@intel.com
Subject: Re: [dpdk-dev] [PATCH v2] examples/flow_filtering: demo of simple rte flow
Date: Fri, 27 Oct 2017 01:14:15 +0200 [thread overview]
Message-ID: <4865583.3QcsuuSVpe@xps> (raw)
In-Reply-To: <28eeef90ebaf5e8afb31837fade1b36c484f29a5.1508953769.git.orika@mellanox.com>
Few comments below, Ori:
25/10/2017 19:58, Ori Kam:
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -978,3 +978,7 @@ F: examples/tep_termination/
> F: examples/vmdq/
> F: examples/vmdq_dcb/
> F: doc/guides/sample_app_ug/vmdq_dcb_forwarding.rst
> +
> +M: Ori Kam <orika@mellanox.com>
> +F: examples/flow_filtering/
> +F: doc/guides/sample_app_ug/flow_filtering.rst
Please keep examples in alphabetical order.
> --- a/doc/guides/sample_app_ug/index.rst
> +++ b/doc/guides/sample_app_ug/index.rst
> @@ -77,6 +77,7 @@ Sample Applications User Guides
> ptpclient
> performance_thread
> ipsec_secgw
> + flow_filtering
I don't know whether there is an order in this index.
> --- a/examples/Makefile
> +++ b/examples/Makefile
> @@ -100,5 +100,6 @@ endif
> endif
>
> DIRS-y += eventdev_pipeline_sw_pmd
> +DIRS-y += flow_filtering
Most of apps are in alphabetical order in this Makefile.
> --- /dev/null
> +++ b/examples/flow_filtering/Makefile
> @@ -0,0 +1,17 @@
A license header is required.
> +ifeq ($(RTE_SDK),)
> +$(error "Please define RTE_SDK environment variable")
> +endif
> +
> +# Default target, can be overridden by command line or environment
> +RTE_TARGET ?= x86_64-native-linuxapp-gcc
> +
> +include $(RTE_SDK)/mk/rte.vars.mk
> +
> +APP = flow
> +
> +SRCS-y := main.c
> +
> +CFLAGS += -g3
-g3 ? Is it a mistake?
> --- /dev/null
> +++ b/examples/flow_filtering/main.c
> @@ -0,0 +1,244 @@
> +/*-
> + * BSD LICENSE
> + *
> + * Copyright 2017 Mellanox.
> + *
> + * Redistribution and use in source and binary forms, with or without
> + * modification, are permitted provided that the following conditions
> + * are met:
> + *
> + * * Redistributions of source code must retain the above copyright
> + * notice, this list of conditions and the following disclaimer.
> + * * Redistributions in binary form must reproduce the above copyright
> + * notice, this list of conditions and the following disclaimer in
> + * the documentation and/or other materials provided with the
> + * distribution.
> + * * Neither the name of 6WIND S.A. nor the names of its
Wrong copyright holder reference here.
next prev parent reply other threads:[~2017-10-26 23:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 10:04 [dpdk-dev] [PATCH 0/2] flow rules example Ori Kam
2017-10-25 17:58 ` [dpdk-dev] [PATCH v2] examples/flow_filtering: demo of simple rte flow Ori Kam
2017-10-26 23:14 ` Thomas Monjalon [this message]
2017-10-29 16:04 ` Ori Kam
2017-11-01 9:42 ` [dpdk-dev] [PATCH v3] " Ori Kam
2017-11-07 21:32 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4865583.3QcsuuSVpe@xps \
--to=thomas@monjalon.net \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=orika@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).