From: Thomas Monjalon <thomas@monjalon.net>
To: David Marchand <david.marchand@redhat.com>
Cc: "Hunt, David" <david.hunt@intel.com>,
Ruifeng Wang <Ruifeng.Wang@arm.com>,
dev@dpdk.org, nd <nd@arm.com>, Feifei Wang <Feifei.Wang2@arm.com>
Subject: Re: 回复: [PATCH v1 3/3] examples/l3fwd-power: enable PMD power mgmt on Arm
Date: Thu, 20 Oct 2022 22:41:33 +0200 [thread overview]
Message-ID: <4960501.eGJsNajkDb@thomas> (raw)
In-Reply-To: <AS8PR08MB7718F7817C12F9EA1A07C0C1C8239@AS8PR08MB7718.eurprd08.prod.outlook.com>
11/10/2022 09:56, Feifei Wang:
> David Marchand <david.marchand@redhat.com>
> > > On 25/08/2022 07:42, Feifei Wang wrote:
> > > > --- a/examples/l3fwd-power/main.c
> > > > +++ b/examples/l3fwd-power/main.c
> > > > @@ -432,8 +432,16 @@ static void
> > > > signal_exit_now(int sigtype)
> > > > {
> > > >
> > > > - if (sigtype == SIGINT)
> > > > + if (sigtype == SIGINT) {
> > > > +#if defined(RTE_ARCH_ARM64)
> >
> > Having a arch specific behavior in the application shows that there is
> > something wrong either in the API, or in the Arm implementation of the API.
> > I don't think this is a good solution.
> >
> > Can't we find a better alternative? By changing the API probably?
> Sorry I do not understand ' shows that there is something wrong either in the API'
David means the application developer should not have to be aware
of the arch differences.
When you use an API, you don't check how it is implemented,
and you are not supposed to use #ifdef.
The API must be arch-agnostic.
> Here we call ' rte_power_monitor_wakeup' API is due to that we need to wake
> up all cores from WFE instructions in arm, and then l3fwd can exit correctly.
>
> This is due to that arm arch is different from x86, if there is no packets received, x86's
> 'UMONITOR' can automatically exit from energy-saving state after waiting for a period of time.
> But arm's 'WFE' can not exit automatically. It will wait 'SEV' instructions in wake_up API to wake
> up it.
>
> Finally, if user want to exit l3fwd by 'SIGINT' in arm, main core should firstly call 'wake_up' API
> to force worker cores to exit from energy-saving state.
> Otherwise, the worker will stay in the energy-saving state forever if no packet is received.
Please find a way to have a common API,
even if the API implementation is empty in x86 case.
> >
> >
> > > > + /**
> > > > + * wake_up api does not need input parameter on Arm,
> > > > + * so 0 is meaningless here.
> > > > + */
> > > > + rte_power_monitor_wakeup(0); #endif
> > > > quit_signal = true;
> > > > + }
next prev parent reply other threads:[~2022-10-20 20:41 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 6:42 [PATCH v1 0/3] Enable PMD power management " Feifei Wang
2022-08-25 6:42 ` [PATCH v1 1/3] eal: add 8 bits case for wait scheme Feifei Wang
2022-08-25 6:42 ` [PATCH v1 2/3] eal: add power mgmt support on Arm Feifei Wang
2022-08-25 6:42 ` [PATCH v1 3/3] examples/l3fwd-power: enable PMD power mgmt " Feifei Wang
2022-08-29 12:48 ` Hunt, David
2022-10-03 7:12 ` David Marchand
2022-10-11 7:56 ` 回复: " Feifei Wang
2022-10-20 20:41 ` Thomas Monjalon [this message]
2022-10-27 9:38 ` 回复: " Feifei Wang
2022-10-20 22:09 ` Stephen Hemminger
2022-10-27 9:43 ` 回复: " Feifei Wang
2022-11-07 7:04 ` [PATCH v2 0/3] Enable PMD power management " Feifei Wang
2022-11-07 7:04 ` [PATCH v2 1/3] eal: add 8 bits case for wait scheme Feifei Wang
2022-11-07 7:04 ` [PATCH v2 2/3] eal: add power mgmt support on Arm Feifei Wang
2022-11-07 7:04 ` [PATCH v2 3/3] examples/l3fwd-power: enable PMD power monitor " Feifei Wang
2022-11-07 16:01 ` Stephen Hemminger
2022-11-08 3:25 ` 回复: " Feifei Wang
2022-11-11 7:26 ` [PATCH v3 0/3] Enable PMD power management " Feifei Wang
2022-11-11 7:26 ` [PATCH v3 1/3] eal: add 8 bits case for wait scheme Feifei Wang
2022-11-11 7:26 ` [PATCH v3 2/3] eal: add power mgmt support on Arm Feifei Wang
2022-11-11 7:26 ` [PATCH v3 3/3] examples/l3fwd-power: enable PMD power monitor " Feifei Wang
2022-11-11 8:22 ` Thomas Monjalon
2022-11-11 10:21 ` 回复: " Feifei Wang
2022-11-11 10:20 ` [PATCH v4 0/4] Enable PMD power management " Feifei Wang
2022-11-11 10:20 ` [PATCH v4 1/4] eal: add 8 bits case for wait scheme Feifei Wang
2022-11-11 10:20 ` [PATCH v4 2/4] eal: add power mgmt support on Arm Feifei Wang
2022-11-11 10:20 ` [PATCH v4 3/4] power: add power monitor support check Feifei Wang
2022-11-11 10:20 ` [PATCH v4 4/4] examples/l3fwd-power: add power monitor wake up API Feifei Wang
2022-12-14 8:14 ` [PATCH v5 0/2] Enable PMD power management on Arm Feifei Wang
2022-12-14 8:14 ` [PATCH v5 1/2] eal: add 8 bits case for wait scheme Feifei Wang
2022-12-14 8:14 ` [PATCH v5 2/2] eal: add power mgmt support on Arm Feifei Wang
2023-02-17 16:23 ` Stephen Hemminger
2023-02-20 1:56 ` 回复: " Feifei Wang
2023-02-17 8:26 ` 回复: [PATCH v5 0/2] Enable PMD power management " Feifei Wang
2023-02-20 8:51 ` [PATCH v6 " Feifei Wang
2023-02-20 8:51 ` [PATCH v6 1/2] eal: add 8 bits case for wait scheme Feifei Wang
2023-02-20 8:51 ` [PATCH v6 2/2] eal: add power mgmt support on Arm Feifei Wang
2023-02-20 12:07 ` [PATCH v6 0/2] Enable PMD power management " David Marchand
2023-02-21 2:37 ` 回复: " Feifei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4960501.eGJsNajkDb@thomas \
--to=thomas@monjalon.net \
--cc=Feifei.Wang2@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=david.hunt@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).