From: "Dai, Wei" <wei.dai@intel.com>
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"thomas.monjalon@6wind.com" <thomas.monjalon@6wind.com>,
"harish.patil@cavium.com" <harish.patil@cavium.com>,
"rasesh.mody@cavium.com" <rasesh.mody@cavium.com>,
"stephen.hurd@broadcom.com" <stephen.hurd@broadcom.com>,
"ajit.khaparde@broadcom.com" <ajit.khaparde@broadcom.com>,
"Zhang, Helin" <helin.zhang@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"Chen, Jing D" <jing.d.chen@intel.com>,
"adrien.mazarguil@6wind.com" <adrien.mazarguil@6wind.com>,
"nelio.laranjeiro@6wind.com" <nelio.laranjeiro@6wind.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"yuanhan.liu@linux.intel.com" <yuanhan.liu@linux.intel.com>,
"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v4 1/3] ethdev: fix adding invalid MAC addr
Date: Sat, 29 Apr 2017 06:09:06 +0000 [thread overview]
Message-ID: <49759EB36A64CF4892C1AFEC9231E8D650A7836A@PGSMSX106.gar.corp.intel.com> (raw)
In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B59B6C1@shsmsx102.ccr.corp.intel.com>
HI, Wenzhuo
> >
> > int bnxt_link_update_op(struct rte_eth_dev *eth_dev, int
> > wait_to_complete) diff --git a/drivers/net/e1000/base/e1000_api.c
> > b/drivers/net/e1000/base/e1000_api.c
> > index f7cf83b..dcb53f7 100644
> > --- a/drivers/net/e1000/base/e1000_api.c
> > +++ b/drivers/net/e1000/base/e1000_api.c
> > @@ -855,7 +855,7 @@ int e1000_rar_set(struct e1000_hw *hw, u8 *addr,
> > u32 index)
> > if (hw->mac.ops.rar_set)
> > return hw->mac.ops.rar_set(hw, addr, index);
> >
> > - return E1000_SUCCESS;
> > + return E1000_ERR_NO_SPACE;
> > }
> NACK here. Normally we try to avoid changing base code. And I don't think the
> change is necessary.
If this code is not changed, the code in ethdev may get wrong return value and assume
the failed MAC addr is added.
Anyway, we can ask the base code to be revised by the associated team.
next prev parent reply other threads:[~2017-04-29 6:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1492071245.git.wei.dai@intel.com>
[not found] ` <1491987746-10155-1-git-send-email-wei.dai@intel.com>
2017-04-12 9:02 ` [dpdk-stable] [PATCH v3 " Wei Dai
2017-04-12 9:30 ` Nélio Laranjeiro
2017-04-13 8:21 ` [dpdk-stable] [PATCH v4 " Wei Dai
2017-04-13 8:44 ` Nélio Laranjeiro
2017-04-13 9:22 ` Dai, Wei
2017-04-20 5:31 ` Yuanhan Liu
2017-04-20 21:43 ` Thomas Monjalon
2017-04-21 6:43 ` Lu, Wenzhuo
2017-04-29 6:09 ` Dai, Wei [this message]
2017-05-02 1:21 ` Lu, Wenzhuo
2017-05-02 1:51 ` Dai, Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49759EB36A64CF4892C1AFEC9231E8D650A7836A@PGSMSX106.gar.corp.intel.com \
--to=wei.dai@intel.com \
--cc=adrien.mazarguil@6wind.com \
--cc=ajit.khaparde@broadcom.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=harish.patil@cavium.com \
--cc=helin.zhang@intel.com \
--cc=jing.d.chen@intel.com \
--cc=jingjing.wu@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=nelio.laranjeiro@6wind.com \
--cc=rasesh.mody@cavium.com \
--cc=stable@dpdk.org \
--cc=stephen.hurd@broadcom.com \
--cc=thomas.monjalon@6wind.com \
--cc=wenzhuo.lu@intel.com \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).