From: "Dai, Wei" <wei.dai@intel.com>
To: "Wu, Jingjing" <jingjing.wu@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>,
"Liang, Cunming" <cunming.liang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH 1/2] net/i40e: fix VFIO interrupt mapping in VF
Date: Fri, 3 Nov 2017 05:48:43 +0000 [thread overview]
Message-ID: <49759EB36A64CF4892C1AFEC9231E8D6515552A0@PGSMSX111.gar.corp.intel.com> (raw)
In-Reply-To: <9BB6961774997848B5B42BEC655768F810EAC7C4@SHSMSX103.ccr.corp.intel.com>
Hi, Jingjing
Thanks for your feedback.
> > Subject: [PATCH 1/2] net/i40e: fix VFIO interrupt mapping in VF
> >
> > When a VF port is bound to VFIO-PIC, only miscellaneous interrupt is
> > mapped to VFIO vector 0 in i40evf_dev_init( ).
> > In ixgbevf_dev_interrupt_handler( ), if previous VFIO interrupt
> > mapping set in
>
> Ixgbevf? Should be i40evf?
Yes, it is my typo error, it should be i40evf.
>
> > i40evf_dev_init( ) is not cleard, it will fail when calling
> > rte_intr_enable( ) tries to map Rx queue interrupt to other VFIO
> > vectors. This patch clears the VFIO interrupt mappings before setting
> > both miscellaneous and Rx queue interrupt mappings again to avoid
> failure.
> >
> > Fixes: 4b90a3ff26c5 ("i40evf: support Rx interrupt")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Wei Dai <wei.dai@intel.com>
> > ---
> > drivers/net/i40e/i40e_ethdev_vf.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/i40e/i40e_ethdev_vf.c
> > b/drivers/net/i40e/i40e_ethdev_vf.c
> > index 3b76c9e..567b7d0 100644
> > --- a/drivers/net/i40e/i40e_ethdev_vf.c
> > +++ b/drivers/net/i40e/i40e_ethdev_vf.c
> > @@ -1432,8 +1432,9 @@ i40evf_dev_interrupt_handler(void *param)
> > " do nothing");
> >
> > done:
> > - i40evf_enable_irq0(hw);
> > + rte_intr_disable(dev->intr_handle);
> > rte_intr_enable(dev->intr_handle);
> > + i40evf_enable_irq0(hw);
>
> If that reason, you can move the rte_intr_disable to dev_start when deal
> with the rxq setting in intr_conf.
Yes, I have followed your suggestion and tested it with my following code change.
it works well.
The function rte_intr_disable( ) can be moved into i40evf_dev_start( ) and only
be called it if rx queue interrupt is enabled.
Meanwhile, the calling of rte_intr_enable( ) in i40evf_dev_interrupt_handle( )
and i40evf_dev_rx_queue_intr_enable( ) can also be removed.
> > }
> >
> > static int
> > --
> > 2.7.5
next prev parent reply other threads:[~2017-11-03 5:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1509628256-16300-1-git-send-email-wei.dai@intel.com>
2017-11-02 13:10 ` Wei Dai
2017-11-03 2:25 ` Wu, Jingjing
2017-11-03 5:48 ` Dai, Wei [this message]
2017-11-02 13:10 ` [dpdk-stable] [PATCH 2/2] net/i40e: fix Rx queue " Wei Dai
2017-11-03 2:17 ` Wu, Jingjing
2017-11-03 5:51 ` Dai, Wei
[not found] ` <1509693243-43101-1-git-send-email-wei.dai@intel.com>
2017-11-03 7:14 ` [dpdk-stable] [PATCH v2 1/2] net/i40e: fix VFIO " Wei Dai
2017-11-03 7:14 ` [dpdk-stable] [PATCH v2 2/2] net/i40e: fix Rx queue " Wei Dai
[not found] ` <1509698850-13301-1-git-send-email-wei.dai@intel.com>
2017-11-03 8:47 ` [dpdk-stable] [PATCH v3 1/2] net/i40e: fix VFIO " Wei Dai
2017-11-03 10:36 ` Wu, Jingjing
2017-11-03 8:47 ` [dpdk-stable] [PATCH v3 2/2] net/i40e: fix Rx queue " Wei Dai
2017-11-03 10:37 ` Wu, Jingjing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49759EB36A64CF4892C1AFEC9231E8D6515552A0@PGSMSX111.gar.corp.intel.com \
--to=wei.dai@intel.com \
--cc=beilei.xing@intel.com \
--cc=cunming.liang@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).