From: "Dai, Wei" <wei.dai@intel.com>
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/ixgbe: fix VF RX hang
Date: Wed, 22 Nov 2017 01:18:28 +0000 [thread overview]
Message-ID: <49759EB36A64CF4892C1AFEC9231E8D6515653D6@PGSMSX112.gar.corp.intel.com> (raw)
In-Reply-To: <1511149065-15646-1-git-send-email-wenzhuo.lu@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu
> Sent: Monday, November 20, 2017 11:38 AM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/ixgbe: fix VF RX hang
>
> The datasheet says, if using MSI-X mode, the PBA support bit of the GPIE
> register must be set to 1.
> DPDK uses polling mode, we cannot hit this issue in the scenario DPDK PF +
> DPDK VF. If we use DPDK PF + kernel VF, as the kernel driver uses interrpt
> mode, VF may hit RX hang after running hours.
>
> Fixes: 00e30184daa0 ("ixgbe: add PF support")
> Cc: stable@dpdk.org
>
> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
Acked-by: Wei Dai <wei.dai@intel.com>
Thank you, Wenzhuo.
This bug-fix address to Rx hang after long time running.
It has also been confirmed by Intel NIC firmware team and tested by one of our customers.
> ---
> drivers/net/ixgbe/ixgbe_pf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_pf.c b/drivers/net/ixgbe/ixgbe_pf.c index
> 676e92c..0114694 100644
> --- a/drivers/net/ixgbe/ixgbe_pf.c
> +++ b/drivers/net/ixgbe/ixgbe_pf.c
> @@ -273,7 +273,7 @@ int ixgbe_pf_host_configure(struct rte_eth_dev
> *eth_dev)
>
> gpie = IXGBE_READ_REG(hw, IXGBE_GPIE);
> gpie &= ~IXGBE_GPIE_VTMODE_MASK;
> - gpie |= IXGBE_GPIE_MSIX_MODE;
> + gpie |= IXGBE_GPIE_MSIX_MODE | IXGBE_GPIE_PBA_SUPPORT;
>
> switch (RTE_ETH_DEV_SRIOV(eth_dev).active) {
> case ETH_64_POOLS:
> --
> 1.9.3
next prev parent reply other threads:[~2017-11-22 1:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-20 3:37 [dpdk-stable] " Wenzhuo Lu
2017-11-22 1:18 ` Dai, Wei [this message]
2017-12-20 6:09 ` [dpdk-stable] [dpdk-dev] " Zhang, Helin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49759EB36A64CF4892C1AFEC9231E8D6515653D6@PGSMSX112.gar.corp.intel.com \
--to=wei.dai@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).