From: "Dai, Wei" <wei.dai@intel.com>
To: "Wu, Jingjing" <jingjing.wu@intel.com>,
"Peng, Yuan" <yuan.peng@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] app/testpmd: fix commands to config some offload
Date: Fri, 20 Jul 2018 02:34:39 +0000 [thread overview]
Message-ID: <49759EB36A64CF4892C1AFEC9231E8D66D063048@PGSMSX112.gar.corp.intel.com> (raw)
In-Reply-To: <1532002875-29504-1-git-send-email-wei.dai@intel.com>
Hi, Yuan
How about your test result ?
Thanks a lot!
> -----Original Message-----
> From: Dai, Wei
> Sent: Thursday, July 19, 2018 8:21 PM
> To: Wu, Jingjing <jingjing.wu@intel.com>; yuan.peng@intle.com
> Cc: dev@dpdk.org; stable@dpdk.org; Dai, Wei <wei.dai@intel.com>
> Subject: [PATCH] app/testpmd: fix commands to config some offload
>
> Without this patch, testpmd command to config Rx offload keep_crc would
> fail and report "Bad argument".
> This patch aslo fix the command to config the Tx offload mbuf_fast_free.
>
> Fixes: 70815c9ecadd ("ethdev: add new offload flag to keep CRC")
> Fixes: c73a9071877a ("app/testpmd: add commands to test new offload
> API")
> Cc: stable@dpdk.org
>
> Signed-off-by: Wei Dai <wei.dai@intel.com>
> ---
> app/test-pmd/cmdline.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
> 5885289..a0ed3a0 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -16665,7 +16665,7 @@ struct cmd_config_per_port_rx_offload_result
> {
> offload,
> "vlan_strip#ipv4_cksum#udp_cksum#tcp_cksum#tcp_lro#"
> "qinq_strip#outer_ipv4_cksum#macsec_strip#"
> "header_split#vlan_filter#vlan_extend#jumbo_frame#"
> - "crc_strip#scatter#timestamp#security");
> + "crc_strip#scatter#timestamp#security#keep_crc");
> cmdline_parse_token_string_t
> cmd_config_per_port_rx_offload_result_on_off =
> TOKEN_STRING_INITIALIZER
> (struct cmd_config_per_port_rx_offload_result,
> @@ -16744,7 +16744,7 @@ struct cmd_config_per_port_rx_offload_result
> {
> .help_str = "port config <port_id> rx_offload vlan_strip|ipv4_cksum|"
>
> "udp_cksum|tcp_cksum|tcp_lro|qinq_strip|outer_ipv4_cksum|"
> "macsec_strip|header_split|vlan_filter|vlan_extend|"
> - "jumbo_frame|crc_strip|scatter|timestamp|security "
> +
> "jumbo_frame|crc_strip|scatter|timestamp|security|keep_crc "
> "on|off",
> .tokens = {
> (void *)&cmd_config_per_port_rx_offload_result_port,
> @@ -16794,7 +16794,7 @@ struct
> cmd_config_per_queue_rx_offload_result {
> offload,
> "vlan_strip#ipv4_cksum#udp_cksum#tcp_cksum#tcp_lro#"
> "qinq_strip#outer_ipv4_cksum#macsec_strip#"
> "header_split#vlan_filter#vlan_extend#jumbo_frame#"
> - "crc_strip#scatter#timestamp#security");
> + "crc_strip#scatter#timestamp#security#keep_crc");
> cmdline_parse_token_string_t
> cmd_config_per_queue_rx_offload_result_on_off =
> TOKEN_STRING_INITIALIZER
> (struct cmd_config_per_queue_rx_offload_result,
> @@ -16846,7 +16846,7 @@ struct
> cmd_config_per_queue_rx_offload_result {
> "vlan_strip|ipv4_cksum|"
>
> "udp_cksum|tcp_cksum|tcp_lro|qinq_strip|outer_ipv4_cksum|"
> "macsec_strip|header_split|vlan_filter|vlan_extend|"
> - "jumbo_frame|crc_strip|scatter|timestamp|security "
> +
> "jumbo_frame|crc_strip|scatter|timestamp|security|keep_crc "
> "on|off",
> .tokens = {
> (void *)&cmd_config_per_queue_rx_offload_result_port,
> @@ -17063,7 +17063,7 @@ struct cmd_config_per_port_tx_offload_result
> {
> "sctp_cksum#tcp_tso#udp_tso#outer_ipv4_cksum#"
> "qinq_insert#vxlan_tnl_tso#gre_tnl_tso#"
> "ipip_tnl_tso#geneve_tnl_tso#macsec_insert#"
> - "mt_lockfree#multi_segs#fast_free#security");
> + "mt_lockfree#multi_segs#mbuf_fast_free#security");
> cmdline_parse_token_string_t
> cmd_config_per_port_tx_offload_result_on_off =
> TOKEN_STRING_INITIALIZER
> (struct cmd_config_per_port_tx_offload_result,
> @@ -17144,7 +17144,7 @@ struct cmd_config_per_port_tx_offload_result
> {
> "sctp_cksum|tcp_tso|udp_tso|outer_ipv4_cksum|"
> "qinq_insert|vxlan_tnl_tso|gre_tnl_tso|"
> "ipip_tnl_tso|geneve_tnl_tso|macsec_insert|"
> - "mt_lockfree|multi_segs|fast_free|security "
> + "mt_lockfree|multi_segs|mbuf_fast_free|security "
> "on|off",
> .tokens = {
> (void *)&cmd_config_per_port_tx_offload_result_port,
> @@ -17195,7 +17195,7 @@ struct
> cmd_config_per_queue_tx_offload_result {
> "sctp_cksum#tcp_tso#udp_tso#outer_ipv4_cksum#"
> "qinq_insert#vxlan_tnl_tso#gre_tnl_tso#"
> "ipip_tnl_tso#geneve_tnl_tso#macsec_insert#"
> - "mt_lockfree#multi_segs#fast_free#security");
> + "mt_lockfree#multi_segs#mbuf_fast_free#security");
> cmdline_parse_token_string_t
> cmd_config_per_queue_tx_offload_result_on_off =
> TOKEN_STRING_INITIALIZER
> (struct cmd_config_per_queue_tx_offload_result,
> @@ -17248,7 +17248,7 @@ struct
> cmd_config_per_queue_tx_offload_result {
> "sctp_cksum|tcp_tso|udp_tso|outer_ipv4_cksum|"
> "qinq_insert|vxlan_tnl_tso|gre_tnl_tso|"
> "ipip_tnl_tso|geneve_tnl_tso|macsec_insert|"
> - "mt_lockfree|multi_segs|fast_free|security "
> + "mt_lockfree|multi_segs|mbuf_fast_free|security "
> "on|off",
> .tokens = {
> (void *)&cmd_config_per_queue_tx_offload_result_port,
> --
> 1.8.3.1
next parent reply other threads:[~2018-07-20 2:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1532002875-29504-1-git-send-email-wei.dai@intel.com>
2018-07-20 2:34 ` Dai, Wei [this message]
[not found] <1532054553-21844-1-git-send-email-wei.dai@intel.com>
2018-07-20 3:20 ` Peng, Yuan
2018-07-24 3:45 Wei Dai
2018-08-02 1:32 ` Wei Dai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49759EB36A64CF4892C1AFEC9231E8D66D063048@PGSMSX112.gar.corp.intel.com \
--to=wei.dai@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=stable@dpdk.org \
--cc=yuan.peng@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).