DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Neil Horman <nhorman@tuxdriver.com>,
	John McNamara <john.mcnamara@intel.com>,
	Marko Kovacevic <marko.kovacevic@intel.com>,
	dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 2/2] ethdev: add new offload flag to keep CRC
Date: Wed, 21 Mar 2018 22:05:53 +0100	[thread overview]
Message-ID: <4994557.sDfdp0IYcD@xps> (raw)
In-Reply-To: <20180321194730.52068-2-ferruh.yigit@intel.com>

21/03/2018 20:47, Ferruh Yigit:
> DEV_RX_OFFLOAD_KEEP_CRC offload flag added.
> 
> DEV_RX_OFFLOAD_CRC_STRIP flag will remain one more release but default
> behavior in PMDs is to strip the CRC independent from this flag.
> 
> Until DEV_RX_OFFLOAD_CRC_STRIP flag is removed:
> - Setting both KEEP_CRC & CRC_STRIP is INVALID
> - Setting only CRC_STRIP PMD should strip the CRC
> - Setting only KEEP_CRC PMD should keep the CRC
> - Not setting both PMD should strip the CRC

It is the same as saying that DEV_RX_OFFLOAD_CRC_STRIP has no effect :)

  reply	other threads:[~2018-03-21 21:05 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-20 11:26 [dpdk-dev] [PATCH] doc: announce ethdev CRC strip flag deprecation Ferruh Yigit
2018-03-20 11:35 ` Thomas Monjalon
2018-03-20 17:23   ` Ferruh Yigit
2018-03-21 19:47 ` [dpdk-dev] [PATCH v2 1/2] " Ferruh Yigit
2018-03-21 19:47   ` [dpdk-dev] [PATCH v2 2/2] ethdev: add new offload flag to keep CRC Ferruh Yigit
2018-03-21 21:05     ` Thomas Monjalon [this message]
2018-03-29  5:38     ` Shahaf Shuler
2018-03-29  7:43       ` Thomas Monjalon
2018-03-29  7:56         ` Shahaf Shuler
2018-03-29 13:32           ` Ferruh Yigit
2018-04-01  7:10             ` Shahaf Shuler
2018-04-16 17:23               ` Ferruh Yigit
2018-04-16 22:13                 ` Thomas Monjalon
2018-04-17 13:12   ` [dpdk-dev] [PATCH v3] doc: announce ethdev CRC strip flag deprecation Ferruh Yigit
2018-04-17 13:31     ` Andrew Rybchenko
2018-04-17 13:36     ` Ferruh Yigit
2018-04-17 13:39     ` [dpdk-dev] [PATCH v4] " Ferruh Yigit
2018-04-17 13:47       ` Shahaf Shuler
2018-05-28  1:05         ` Thomas Monjalon
2018-08-01 15:27       ` Maxime Coquelin
2018-08-02  8:50         ` Shahaf Shuler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4994557.sDfdp0IYcD@xps \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=john.mcnamara@intel.com \
    --cc=marko.kovacevic@intel.com \
    --cc=nhorman@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).