From: "Varghese, Vipin" <vipin.varghese@intel.com>
To: "Kovacevic, Marko" <marko.kovacevic@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "thomas@monjalon.net" <thomas@monjalon.net>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v1] mk: support building with renamed makefile
Date: Mon, 29 Jan 2018 16:14:48 +0000 [thread overview]
Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D191E4C@BGSMSX101.gar.corp.intel.com> (raw)
In-Reply-To: <20180122105905.6996-1-marko.kovacevic@intel.com>
> -----Original Message-----
> From: Kovacevic, Marko
> Sent: Monday, January 22, 2018 4:29 PM
> To: dev@dpdk.org
> Cc: thomas@monjalon.net; Varghese, Vipin <vipin.varghese@intel.com>;
> Kovacevic, Marko <marko.kovacevic@intel.com>; stable@dpdk.org
> Subject: [PATCH v1] mk: support building with renamed makefile
>
> The build system made a recursive call to "make" after creating the build
> directory. This recursive call used the hard-coded filename "Makefile", which
> prevented builds from working if the file was renamed and make called using
> "make -f". Taking the filename from MAKEFILES_LIST make variable fixes this.
>
> Fixes: af75078fece3 ("first public release")
> Cc: stable@dpdk.org
>
> Signed-off-by: Marko Kovacevic <marko.kovacevic@intel.com>
> ---
> mk/internal/rte.extvars.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mk/internal/rte.extvars.mk b/mk/internal/rte.extvars.mk index
> 94f27e9..19594da 100644
> --- a/mk/internal/rte.extvars.mk
> +++ b/mk/internal/rte.extvars.mk
> @@ -20,7 +20,7 @@ ifeq ("$(origin M)", "command line") RTE_EXTMK :=
> $(abspath $(M)) endif endif -RTE_EXTMK ?= $(RTE_SRCDIR)/Makefile
> +RTE_EXTMK ?= $(RTE_SRCDIR)/$(firstword $(MAKEFILE_LIST))
> export RTE_EXTMK
>
> # RTE_SDK_BIN must point to .config, include/ and lib/.
> --
> 2.9.5
I have validated on Linux environment with custom make file name as 'Makefile.test'.
Acked-by: Vipin Varghese <vipin.varghese@intel.com>
next prev parent reply other threads:[~2018-01-29 16:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 10:59 Marko Kovacevic
2018-01-29 16:14 ` Varghese, Vipin [this message]
2018-01-30 23:43 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2018-02-05 9:29 ` Olivier Matz
2018-02-05 9:53 ` [dpdk-stable] [PATCH v2] mk: support renamed Makefile in external project Marko Kovacevic
2018-02-05 10:00 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C9E0AB70F954A408CC4ADDBF0F8FA7D4D191E4C@BGSMSX101.gar.corp.intel.com \
--to=vipin.varghese@intel.com \
--cc=dev@dpdk.org \
--cc=marko.kovacevic@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).