From: "Varghese, Vipin" <vipin.varghese@intel.com>
To: "Pattan, Reshma" <reshma.pattan@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Mcnamara, John" <john.mcnamara@intel.com>
Subject: Re: [dpdk-dev] [PATCH] app/pdump: check for ports
Date: Mon, 26 Feb 2018 11:48:32 +0000 [thread overview]
Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D19BE28@BGSMSX101.gar.corp.intel.com> (raw)
In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A2A4011@irsmsx110.ger.corp.intel.com>
> -----Original Message-----
> From: Pattan, Reshma
> Sent: Monday, February 26, 2018 11:02 AM
> To: Varghese, Vipin <vipin.varghese@intel.com>; dev@dpdk.org
> Cc: Mcnamara, John <john.mcnamara@intel.com>
> Subject: RE: [PATCH] app/pdump: check for ports
>
>
>
> > -----Original Message-----
> > From: Varghese, Vipin
> > Sent: Monday, February 26, 2018 4:30 PM
> > To: dev@dpdk.org; Pattan, Reshma <reshma.pattan@intel.com>
> > Cc: Mcnamara, John <john.mcnamara@intel.com>; Varghese, Vipin
> > <vipin.varghese@intel.com>
> > Subject: [PATCH] app/pdump: check for ports
> >
<snipped>
> > + if (rte_eth_dev_count() == 0)
> > + rte_exit(EXIT_FAILURE, "Failed to fetch ports for
> PDUMP!\n");
> > +
>
> Good one, can you just change the failure log to rte_exit(EXIT_FAILURE, "No
> Ethernet ports - bye\n"); As, I see most of the other examples and apps do
> use the similar check and log as above. :-)
>
Sure, I will send a v2 patch with updated log information.
> Thanks,
> Reshma
prev parent reply other threads:[~2018-02-26 11:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-26 16:30 Vipin Varghese
2018-02-26 6:22 ` [dpdk-dev] [PATCH v2] " Vipin Varghese
2018-02-28 11:04 ` Pattan, Reshma
2018-04-22 23:13 ` Thomas Monjalon
2018-02-26 11:02 ` [dpdk-dev] [PATCH] " Pattan, Reshma
2018-02-26 11:48 ` Varghese, Vipin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C9E0AB70F954A408CC4ADDBF0F8FA7D4D19BE28@BGSMSX101.gar.corp.intel.com \
--to=vipin.varghese@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=reshma.pattan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).