From: "Varghese, Vipin" <vipin.varghese@intel.com>
To: "Varghese, Vipin" <vipin.varghese@intel.com>,
"Yang, Qiming" <qiming.yang@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Yang, Qiming" <qiming.yang@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] lib: add warning for NULL pointer
Date: Wed, 5 Dec 2018 05:15:59 +0000 [thread overview]
Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2C4C1A@BGSMSX101.gar.corp.intel.com> (raw)
In-Reply-To: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2C4BF6@BGSMSX101.gar.corp.intel.com>
Do you plan to check for all iteration for ' flows->last_cmplt ' is successful?
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Varghese, Vipin
> Sent: Wednesday, December 5, 2018 10:07 AM
> To: Yang, Qiming <qiming.yang@intel.com>; dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] lib: add warning for NULL pointer
>
> Hi,
>
> Should not the warning be stated for ' alloc_completion' failure
>
> Snipped
>
> > flows->num_packets * flows->categories);
> > }
> >
> > + if (flows->last_cmplt == NULL)
> > + RTE_LOG(WARNING, MALLOC, "packet tries allocate
> > failed");
>
> Why is that we want to try this outside block?
>
> > +
> > /* set completion parameters and starting index for this slot */
> > parms[n].cmplt = flows->last_cmplt;
> > transition =
> > --
> > 2.9.5
next prev parent reply other threads:[~2018-12-05 5:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 11:55 [dpdk-stable] " Qiming Yang
2018-12-05 4:37 ` [dpdk-stable] [dpdk-dev] " Varghese, Vipin
2018-12-05 5:15 ` Varghese, Vipin [this message]
2018-12-05 17:06 ` Stephen Hemminger
2019-01-14 12:39 ` Ananyev, Konstantin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2C4C1A@BGSMSX101.gar.corp.intel.com \
--to=vipin.varghese@intel.com \
--cc=dev@dpdk.org \
--cc=qiming.yang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).