DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Varghese, Vipin" <vipin.varghese@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Mcnamara, John" <john.mcnamara@intel.com>,
	 "Kovacevic, Marko" <marko.kovacevic@intel.com>,
	"Yigit, Ferruh" <ferruh.yigit@intel.com>,
	"Padubidri, Sanjay A" <sanjay.padubidri@intel.com>,
	 "Patel, Amol" <amol.patel@intel.com>
Subject: Re: [dpdk-dev] [PATCH v4] doc/patches: add meson build to contributing guide
Date: Mon, 28 Jan 2019 14:27:15 +0000	[thread overview]
Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2F769B@BGSMSX101.gar.corp.intel.com> (raw)
In-Reply-To: <1830265.56Hsnbp04L@xps>

Hi Thomas,

snipped 
> > +Compilation of patches is to be tested with ``test-meson-builds.sh``
> > +script in ``devtools`` directory of the DPDK repo::
> 
> Would be more straight-forward to give the full path:
> 	devtools/test-meson-builds.sh
I also like to use ' devtools/test-meson-builds.sh', but based I followed the formatting used for 'test-build.sh'. 

Which is ``` Compilation of patches and changes should be tested using the test-build.sh script in the devtools directory of the DPDK repo```. 

> No need to add "DPDK repo".
> 
> > +
> > +   devtools/test-meson-builds.sh
> 
> Do we really need to repeat the script name here?
Same as above. 

Note: please let me know if you still require the change for above items?

> 
> > +
> > +The script internally checks for dependencies and tool chain. Then
> > +builds with
> 
> tool chain -> toolchain
I will fix this and share the updated version.

> 
> > +shared and static libraries for Linux and BSD targets.
> 
> Why "Linux and BSD" ? It is just testing for the running OS.
The default execution generates for default targets as ' build-gcc-shared, build-gcc-static & build-x86-default'. If cross build is supported ' build-clang-shared & build-clang-static'.

As per my understanding this will true for Linux and BSD (Windows I am not aware). Hence I mention it as 'Linux and BSD'.

Note: 
1. If it is with regard to wording I can reword from ' Then builds with shared and static libraries for Linux and BSD targets' to 'Then binaries are built with static and shared library for default and arm cross build on Linux and BSD'
2.if support & built infrastructure works for Windows I can reword from ' Then builds with shared and static libraries for Linux and BSD targets' to 'Then binaries are built with static and shared library for default and arm cross build for Host OS'

Please let me know is 1 or 2 is right one?

> 
> 

  reply	other threads:[~2019-01-28 14:27 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-30  4:56 [dpdk-dev] [PATCH v1] doc: " Vipin Varghese
2018-10-30 10:54 ` Bruce Richardson
2018-10-30 14:13 ` [dpdk-dev] [PATCH v2] " Vipin Varghese
2018-10-30 14:18   ` [dpdk-dev] [PATCH v3] " Vipin Varghese
2018-11-14 14:30     ` Kovacevic, Marko
2018-11-24 18:57       ` Thomas Monjalon
2019-01-10 16:37         ` Varghese, Vipin
2019-01-24 23:05     ` [dpdk-dev] [PATCH v4] doc/patches: " Vipin Varghese
2019-01-28  0:39       ` Thomas Monjalon
2019-01-28 14:27         ` Varghese, Vipin [this message]
2019-01-28 14:52           ` Thomas Monjalon
2019-01-28 15:40             ` Varghese, Vipin
2019-01-29 10:10       ` [dpdk-dev] [PATCH v5] " Vipin Varghese
2019-02-12  9:36         ` Thomas Monjalon
2019-02-13  5:38           ` Varghese, Vipin
2019-02-13  5:41         ` [dpdk-dev] [PATCH v6] " Vipin Varghese
2019-02-25 17:12           ` [dpdk-dev] [PATCH v7 0/2] guide to debug and troubleshoot Vipin Varghese
2019-02-25 17:12             ` [dpdk-dev] [PATCH v7 1/2] doc: add svg for debug and troubleshoot guide Vipin Varghese
2019-04-01 14:56               ` Mcnamara, John
2019-04-01 14:56                 ` Mcnamara, John
2019-02-25 17:12             ` [dpdk-dev] [PATCH v7 2/2] doc: add guide for debug and troubleshoot Vipin Varghese
2019-04-01 14:56               ` Mcnamara, John
2019-04-01 14:56                 ` Mcnamara, John
2019-04-05  8:49                 ` Thomas Monjalon
2019-04-05  8:49                   ` Thomas Monjalon
2019-04-08  3:18                   ` Varghese, Vipin
2019-04-08  3:18                     ` Varghese, Vipin
2019-04-08  6:45                     ` Thomas Monjalon
2019-04-08  6:45                       ` Thomas Monjalon
2019-04-09  6:33                       ` Varghese, Vipin
2019-04-09  6:33                         ` Varghese, Vipin
2019-04-09  6:33               ` [dpdk-dev] [PATCH v8 0/2] guide to " Vipin Varghese
2019-04-09  6:33                 ` Vipin Varghese
2019-04-09  6:33                 ` [dpdk-dev] [PATCH v8 1/2] doc: add svg for debug and troubleshoot guide Vipin Varghese
2019-04-09  6:33                   ` Vipin Varghese
2019-04-09  6:33                 ` [dpdk-dev] [PATCH v8 2/2] doc: add guide for debug and troubleshoot Vipin Varghese
2019-04-09  6:33                   ` Vipin Varghese
2019-05-04 22:26                 ` [dpdk-dev] [PATCH v8 0/2] guide to " Thomas Monjalon
2019-05-04 22:26                   ` Thomas Monjalon
2019-04-01  4:08             ` [dpdk-dev] [PATCH v7 " Varghese, Vipin
2019-04-01  4:08               ` Varghese, Vipin
2019-02-27 11:41           ` [dpdk-dev] [PATCH v6] doc/patches: add meson build to contributing guide Thomas Monjalon
2019-02-27 12:13             ` Varghese, Vipin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2F769B@BGSMSX101.gar.corp.intel.com \
    --to=vipin.varghese@intel.com \
    --cc=amol.patel@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=john.mcnamara@intel.com \
    --cc=marko.kovacevic@intel.com \
    --cc=sanjay.padubidri@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).