From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Nirmoy Das <ndas@suse.de>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] kni: define HAVE_VF_VLAN_PROTO for SLES12SP3
Date: Fri, 31 Mar 2017 15:10:30 +0100 [thread overview]
Message-ID: <4a0093ff-6ef4-702d-897a-ac3611d932da@intel.com> (raw)
In-Reply-To: <20170331113240.2399-1-ndas@suse.de>
On 3/31/2017 12:32 PM, Nirmoy Das wrote:
> Add support for SLES12SP3, which uses kernel 4.4,
> but backported features from newer kernels.
>
> Signed-off-by: Nirmoy Das <ndas@suse.de>
> ---
> lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h b/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h
> index 84826b26e..3d22d8e69 100644
> --- a/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h
> +++ b/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h
> @@ -3929,8 +3929,10 @@ skb_set_hash(struct sk_buff *skb, __u32 hash, __always_unused int type)
> #define vlan_tx_tag_present skb_vlan_tag_present
> #endif
>
> -#if ( LINUX_VERSION_CODE >= KERNEL_VERSION(4,9,0) )
> +#if (( LINUX_VERSION_CODE >= KERNEL_VERSION(4,9,0) ) \
> + || (defined(CONFIG_SUSE_KERNEL) && \
> + (LINUX_VERSION_CODE >= KERNEL_VERSION(4,4,57))))
> #define HAVE_VF_VLAN_PROTO
> -#endif /* >= 4.9.0 */
> +#endif /* >= 4.9.0, >= SLES12SP3 */
To make condition simple, what about separating SUSE related check?
There is already "#ifdef CONFIG_SUSE_KERNEL" check in line 699, which is
mainly to set SLE_VERSION_CODE, but this check can be added end of that
block, what do you think?
Thanks,
ferruh
>
> #endif /* _KCOMPAT_H_ */
>
next prev parent reply other threads:[~2017-03-31 14:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-31 11:32 Nirmoy Das
2017-03-31 14:10 ` Ferruh Yigit [this message]
2017-04-03 8:05 ` Nirmoy Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a0093ff-6ef4-702d-897a-ac3611d932da@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=ndas@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).